From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, stable@kernel.org
Subject: Re: [PATCH 1/3] drm/i915: Ivybridge still has fences!
Date: Sun, 23 Oct 2011 12:18:09 +0200 [thread overview]
Message-ID: <20111023121809.2b36aaf6@jbarnes-x220> (raw)
In-Reply-To: <20111023101200.GC2953@phenom.ffwll.local>
On Sun, 23 Oct 2011 12:12:00 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Oct 10, 2011 at 10:58:22AM -0700, Jesse Barnes wrote:
> > On Sun, 9 Oct 2011 21:52:01 +0200
> > Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >
> > > So don't forget to restore them on resume and dump them into
> > > the error state.
> >
> > This should probably just be >= 6 instead; I don't think we're
> > getting rid of fences anytime soon.
>
> As discussed on irc >= 6 is a bit hard to do in a switch
> statement ;-) Do you want me to resend the patches using the gcc
> ranged switch extension suggested by Adam Jackson (i.e. 6..UINT_MAX)?
> Or can you slap your r-b on them as-is?
I was suggesting that you convert it to an if ladder with the >= 6 at
the top. That should be a separate patch though.
Jesse
next prev parent reply other threads:[~2011-10-23 10:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 19:52 [PATCH 1/3] drm/i915: Ivybridge still has fences! Daniel Vetter
2011-10-09 19:52 ` [PATCH 2/3] drm/i915: add constants to size fence arrays and fields Daniel Vetter
2011-10-09 19:54 ` Daniel Vetter
2011-10-09 19:52 ` [PATCH 3/3] drm/i915: enable support for 32 fences on ivybridge Daniel Vetter
2011-10-10 17:58 ` [PATCH 1/3] drm/i915: Ivybridge still has fences! Jesse Barnes
2011-10-23 10:12 ` Daniel Vetter
2011-10-23 10:18 ` Jesse Barnes [this message]
2011-10-23 11:23 ` Chris Wilson
2011-10-23 12:09 ` Daniel Vetter
2011-10-23 12:35 ` Chris Wilson
2011-11-03 16:23 ` Keith Packard
2011-10-23 20:45 ` Kenneth Graunke
2011-10-23 22:16 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023121809.2b36aaf6@jbarnes-x220 \
--to=jbarnes@virtuousgeek.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox