Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: swizzling support for snb/ivb
Date: Sat, 04 Feb 2012 19:13:41 -0800	[thread overview]
Message-ID: <4F2DF3E5.80309@bwidawsk.net> (raw)
In-Reply-To: <20120202084001.GA4107@phenom.ffwll.local>

On 02/02/12 00:40, Daniel Vetter wrote:
> On Wed, Feb 01, 2012 at 09:30:57PM -0800, Ben Widawsky wrote:
> [...]
>> I'd also say it's not a bad idea to elaborate the assumption that we
>> never have less than 256MB of memory WARN_ON(dimm_c0 + dimm_c1 == 0).
>
> I'm pretty sure that we can't boot with 0mb of ram ;-) The other thing is
> that swizzling is a pure preformance optimization - if we enable it on
> setup where it's not required we'll only annoy the memory controller with
> less efficient access patterns.

What I meant was, this value is still 0 in say, a system with 2
128MB DIMMs.

 > [...]

  reply	other threads:[~2012-02-05  3:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31 15:47 [PATCH 1/3] drm/i915: swizzling support for snb/ivb Daniel Vetter
2012-01-31 15:47 ` [PATCH 2/3] drm/i915: consolidate swizzling control bit frobbing Daniel Vetter
2012-02-01 21:37   ` Ben Widawsky
2012-02-01 22:23     ` Daniel Vetter
2012-02-08 22:17   ` Ben Widawsky
2012-02-08 22:19     ` Daniel Vetter
2012-01-31 15:47 ` [PATCH 3/3] drm/i915: add gen6+ registers to i915_swizzle_info Daniel Vetter
2012-02-01 21:39   ` Ben Widawsky
2012-02-08 22:20     ` Daniel Vetter
2012-02-01 21:35 ` [PATCH 1/3] drm/i915: swizzling support for snb/ivb Ben Widawsky
2012-02-01 22:16   ` Daniel Vetter
2012-02-01 22:26     ` Chris Wilson
2012-02-01 23:15       ` [PATCH] " Daniel Vetter
2012-02-02  5:30         ` Ben Widawsky
2012-02-02  8:40           ` Daniel Vetter
2012-02-05  3:13             ` Ben Widawsky [this message]
2012-02-06 16:06               ` Daniel Vetter
2012-02-02  8:58           ` Daniel Vetter
2012-02-04 20:59             ` Eric Anholt
2012-02-06 15:45               ` Daniel Vetter
2012-02-07 19:56                 ` Eric Anholt
2012-02-08 22:17                   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2DF3E5.80309@bwidawsk.net \
    --to=ben@bwidawsk.net \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox