public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/i915: pnv has a backlight polarity control bit, too
Date: Tue, 12 Jun 2012 11:41:41 -0300	[thread overview]
Message-ID: <4FD75525.3040504@linux.intel.com> (raw)
In-Reply-To: <1338883631-3493-1-git-send-email-daniel.vetter@ffwll.ch>

On 06/05/2012 05:07 AM, Daniel Vetter wrote:
> We already correctly ignore bit0 on gen < 4, now we also now why ;-)

s/now/know

> I've decided that losing that single bit of precision isn't worth the
> trouble to sprinkle IS_PINEVIEW checks all over the backlight control
> code - that code is way too fragile imo.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni

      parent reply	other threads:[~2012-06-12 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  8:07 [PATCH 1/4] drm/i915: pnv has a backlight polarity control bit, too Daniel Vetter
2012-06-05  8:07 ` [PATCH 2/4] drm/i915: clear up backlight #define confusion on gen4+ Daniel Vetter
2012-06-12 15:06   ` Eugeni Dodonov
2012-06-05  8:07 ` [PATCH 3/4] drm/i915: properly enable the blc controller on the right pipe Daniel Vetter
2012-06-05 11:15   ` Daniel Vetter
2012-06-05 10:14     ` [PATCH] " Daniel Vetter
2012-06-12 15:15       ` Eugeni Dodonov
2012-06-05  8:07 ` [PATCH 4/4] drm/i915: allow pipe A for lvds on gen4 Daniel Vetter
2012-06-12 15:35   ` Eugeni Dodonov
2012-06-12 17:29     ` Daniel Vetter
2012-06-05  9:25 ` [PATCH 1/4] drm/i915: pnv has a backlight polarity control bit, too Paul Menzel
2012-06-12 14:41 ` Eugeni Dodonov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD75525.3040504@linux.intel.com \
    --to=eugeni.dodonov@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=eugeni.dodonov@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox