* [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro
@ 2022-12-13 12:00 Nirmoy Das
2022-12-13 12:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Nirmoy Das @ 2022-12-13 12:00 UTC (permalink / raw)
To: intel-gfx; +Cc: andrzej.hajda, matthew.auld, dri-devel, Nirmoy Das
Use MI_USE_GGTT instead of hardcoded value.
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
index c228fe4aba50..3bef1beec7cb 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
@@ -222,7 +222,7 @@ static int gpu_set(struct context *ctx, unsigned long offset, u32 v)
}
if (GRAPHICS_VER(ctx->engine->i915) >= 8) {
- *cs++ = MI_STORE_DWORD_IMM_GEN4 | 1 << 22;
+ *cs++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT;
*cs++ = lower_32_bits(i915_ggtt_offset(vma) + offset);
*cs++ = upper_32_bits(i915_ggtt_offset(vma) + offset);
*cs++ = v;
--
2.38.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/selftests: Remove hardcoded value with a macro
2022-12-13 12:00 [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro Nirmoy Das
@ 2022-12-13 12:17 ` Patchwork
2022-12-13 12:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-12-13 12:17 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Remove hardcoded value with a macro
URL : https://patchwork.freedesktop.org/series/111891/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Function parameter or member 'dsb' not described in 'intel_dsb_reg_write'
./drivers/gpu/drm/i915/display/intel_dsb.c:201: warning: Excess function parameter 'crtc_state' description in 'intel_dsb_reg_write'
^ permalink raw reply [flat|nested] 6+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Remove hardcoded value with a macro
2022-12-13 12:00 [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro Nirmoy Das
2022-12-13 12:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
@ 2022-12-13 12:38 ` Patchwork
2022-12-15 11:17 ` Das, Nirmoy
2022-12-13 13:04 ` [Intel-gfx] [PATCH] " Matthew Auld
2022-12-13 14:14 ` Andrzej Hajda
3 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2022-12-13 12:38 UTC (permalink / raw)
To: Nirmoy Das; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3733 bytes --]
== Series Details ==
Series: drm/i915/selftests: Remove hardcoded value with a macro
URL : https://patchwork.freedesktop.org/series/111891/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12501 -> Patchwork_111891v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111891v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111891v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/index.html
Participating hosts (38 -> 19)
------------------------------
ERROR: It appears as if the changes made in Patchwork_111891v1 prevented too many machines from booting.
Additional (1): fi-skl-guc
Missing (20): fi-kbl-soraka bat-dg1-6 bat-dg1-5 bat-adlp-6 fi-skl-6600u fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-bwr-2160 bat-adln-1 bat-atsm-1 bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick bat-dg1-7 bat-kbl-2 bat-adlp-9 bat-adlp-4
Known issues
------------
Here are the changes found in Patchwork_111891v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@gem_lmem_swapping@basic.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [PASS][2] -> [INCOMPLETE][3] ([i915#4817])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12501/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-guc: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-guc: NOTRUN -> [SKIP][5] ([fdo#109271]) +9 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][6] ([i915#7229]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12501/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
Build changes
-------------
* Linux: CI_DRM_12501 -> Patchwork_111891v1
CI-20190529: 20190529
CI_DRM_12501: 1b38b5a419ab3d838b6ac95d22f1fe057fc8889d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7091: b8015f920c9f469d3733854263cb878373c1df51 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111891v1: 1b38b5a419ab3d838b6ac95d22f1fe057fc8889d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
eaf43d121582 drm/i915/selftests: Remove hardcoded value with a macro
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/index.html
[-- Attachment #2: Type: text/html, Size: 4603 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Remove hardcoded value with a macro
2022-12-13 12:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-12-15 11:17 ` Das, Nirmoy
0 siblings, 0 replies; 6+ messages in thread
From: Das, Nirmoy @ 2022-12-15 11:17 UTC (permalink / raw)
To: intel-gfx, Patchwork, Nirmoy Das; +Cc: Matthew Auld, Andrzej Hajda
[-- Attachment #1: Type: text/plain, Size: 4084 bytes --]
On 12/13/2022 1:38 PM, Patchwork wrote:
> Project List - Patchwork *Patch Details*
> *Series:* drm/i915/selftests: Remove hardcoded value with a macro
> *URL:* https://patchwork.freedesktop.org/series/111891/
> *State:* failure
> *Details:*
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/index.html
>
>
> CI Bug Log - changes from CI_DRM_12501 -> Patchwork_111891v1
>
>
> Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_111891v1 absolutely need
> to be
> verified manually.
>
This is a bit stretch, the patch didn't change any thing functional. We
can ignore the failure.
Nirmoy
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_111891v1, please notify your bug team to allow
> them
> to document this new failure mode, which will reduce false positives
> in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/index.html
>
>
> Participating hosts (38 -> 19)
>
> ERROR: It appears as if the changes made in Patchwork_111891v1
> prevented too many machines from booting.
>
> Additional (1): fi-skl-guc
> Missing (20): fi-kbl-soraka bat-dg1-6 bat-dg1-5 bat-adlp-6
> fi-skl-6600u fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-bwr-2160
> bat-adln-1 bat-atsm-1 bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick
> bat-dg1-7 bat-kbl-2 bat-adlp-9 bat-adlp-4
>
>
> Known issues
>
> Here are the changes found in Patchwork_111891v1 that come from known
> issues:
>
>
> IGT changes
>
>
> Issues hit
>
> *
>
> igt@gem_lmem_swapping@basic:
>
> o fi-skl-guc: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@gem_lmem_swapping@basic.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> i915#4613
> <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3
> similar issues
> *
>
> igt@i915_suspend@basic-s3-without-i915:
>
> o fi-rkl-11600: PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12501/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html>
> -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html>
> (i915#4817 <https://gitlab.freedesktop.org/drm/intel/issues/4817>)
> *
>
> igt@kms_chamelium@hdmi-crc-fast:
>
> o fi-skl-guc: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@kms_chamelium@hdmi-crc-fast.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
> fdo#111827
> <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8
> similar issues
> *
>
> igt@kms_setmode@basic-clone-single-crtc:
>
> o fi-skl-guc: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-skl-guc/igt@kms_setmode@basic-clone-single-crtc.html>
> (fdo#109271
> <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +9
> similar issues
>
>
> Possible fixes
>
> * igt@gem_exec_gttfill@basic:
> o fi-pnv-d510: FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12501/fi-pnv-d510/igt@gem_exec_gttfill@basic.html>
> (i915#7229
> <https://gitlab.freedesktop.org/drm/intel/issues/7229>) ->
> PASS
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111891v1/fi-pnv-d510/igt@gem_exec_gttfill@basic.html>
>
>
> Build changes
>
> * Linux: CI_DRM_12501 -> Patchwork_111891v1
>
> CI-20190529: 20190529
> CI_DRM_12501: 1b38b5a419ab3d838b6ac95d22f1fe057fc8889d @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7091: b8015f920c9f469d3733854263cb878373c1df51 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_111891v1: 1b38b5a419ab3d838b6ac95d22f1fe057fc8889d @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> Linux commits
>
> eaf43d121582 drm/i915/selftests: Remove hardcoded value with a macro
>
[-- Attachment #2: Type: text/html, Size: 6983 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro
2022-12-13 12:00 [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro Nirmoy Das
2022-12-13 12:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-12-13 12:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2022-12-13 13:04 ` Matthew Auld
2022-12-13 14:14 ` Andrzej Hajda
3 siblings, 0 replies; 6+ messages in thread
From: Matthew Auld @ 2022-12-13 13:04 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx; +Cc: andrzej.hajda, dri-devel
On 13/12/2022 12:00, Nirmoy Das wrote:
> Use MI_USE_GGTT instead of hardcoded value.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro
2022-12-13 12:00 [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro Nirmoy Das
` (2 preceding siblings ...)
2022-12-13 13:04 ` [Intel-gfx] [PATCH] " Matthew Auld
@ 2022-12-13 14:14 ` Andrzej Hajda
3 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2022-12-13 14:14 UTC (permalink / raw)
To: Nirmoy Das, intel-gfx; +Cc: matthew.auld, dri-devel
On 13.12.2022 13:00, Nirmoy Das wrote:
> Use MI_USE_GGTT instead of hardcoded value.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> index c228fe4aba50..3bef1beec7cb 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c
> @@ -222,7 +222,7 @@ static int gpu_set(struct context *ctx, unsigned long offset, u32 v)
> }
>
> if (GRAPHICS_VER(ctx->engine->i915) >= 8) {
> - *cs++ = MI_STORE_DWORD_IMM_GEN4 | 1 << 22;
> + *cs++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT;
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
> *cs++ = lower_32_bits(i915_ggtt_offset(vma) + offset);
> *cs++ = upper_32_bits(i915_ggtt_offset(vma) + offset);
> *cs++ = v;
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-15 11:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-13 12:00 [Intel-gfx] [PATCH] drm/i915/selftests: Remove hardcoded value with a macro Nirmoy Das
2022-12-13 12:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2022-12-13 12:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-15 11:17 ` Das, Nirmoy
2022-12-13 13:04 ` [Intel-gfx] [PATCH] " Matthew Auld
2022-12-13 14:14 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox