* 3.10.0+ laptop resolution problem
@ 2013-07-11 18:04 Hans de Bruin
2013-07-11 18:22 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Hans de Bruin @ 2013-07-11 18:04 UTC (permalink / raw)
To: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
somewhere before commit 496322b (yesterday's kernel) resolution
switching on my laptop broke. The screen switches to the right
resolution but the screen is not horizontally centered. The screen is
aligned left and the last vertical line is repeated until the right side
of the screen. Normally there would be black bars on left and right side.
--
Hans
lspci:
...
00:02.1 Display controller: Intel Corporation Mobile 945GM/GMS/GME,
943/940GML Express Integrated Graphics Controller (rev 03)
...
[-- Attachment #2: xrandr-verbose.txt --]
[-- Type: text/plain, Size: 3224 bytes --]
Screen 0: minimum 320 x 200, current 800 x 600, maximum 4096 x 4096
LVDS1 connected 800x600+0+0 (0x47) normal (normal left inverted right x axis y axis) 261mm x 163mm
Identifier: 0x41
Timestamp: 3327596
Subpixel: horizontal rgb
Gamma: 1.0:1.0:1.0
Brightness: 1.0
Clones:
CRTC: 1
CRTCs: 1
Transform: 1.000000 0.000000 0.000000
0.000000 1.000000 0.000000
0.000000 0.000000 1.000000
filter:
EDID:
00ffffffffffff004ca3415400000000
00110103801a10780a87f594574f8c27
27505400000001010101010101010101
010101010101121b008b502010303020
360005a3100000190000000f00000000
000000000032d2023200000000fe0050
593637350331323141540a20000000fe
00263741496c88b0ff01010a20200084
BACKLIGHT: 0 (0x00000000) range: (0,312)
Backlight: 0 (0x00000000) range: (0,312)
scaling mode: Full aspect
supported: None Full Center Full aspect
1280x800 (0x45) 69.3MHz -HSync -VSync +preferred
h: width 1280 start 1328 end 1360 total 1419 skew 0 clock 48.8KHz
v: height 800 start 803 end 809 total 816 clock 59.8Hz
1024x768 (0x46) 65.0MHz -HSync -VSync
h: width 1024 start 1048 end 1184 total 1344 skew 0 clock 48.4KHz
v: height 768 start 771 end 777 total 806 clock 60.0Hz
800x600 (0x47) 40.0MHz +HSync +VSync *current
h: width 800 start 840 end 968 total 1056 skew 0 clock 37.9KHz
v: height 600 start 601 end 605 total 628 clock 60.3Hz
800x600 (0x48) 36.0MHz +HSync +VSync
h: width 800 start 824 end 896 total 1024 skew 0 clock 35.2KHz
v: height 600 start 601 end 603 total 625 clock 56.2Hz
640x480 (0x49) 25.2MHz -HSync -VSync
h: width 640 start 656 end 752 total 800 skew 0 clock 31.5KHz
v: height 480 start 490 end 492 total 525 clock 59.9Hz
VGA1 disconnected (normal left inverted right x axis y axis)
Identifier: 0x42
Timestamp: 3327596
Subpixel: unknown
Clones:
CRTCs: 0 1
Transform: 1.000000 0.000000 0.000000
0.000000 1.000000 0.000000
0.000000 0.000000 1.000000
filter:
DVI1 disconnected (normal left inverted right x axis y axis)
Identifier: 0x43
Timestamp: 3327596
Subpixel: horizontal rgb
Clones:
CRTCs: 0 1
Transform: 1.000000 0.000000 0.000000
0.000000 1.000000 0.000000
0.000000 0.000000 1.000000
filter:
TV1 disconnected (normal left inverted right x axis y axis)
Identifier: 0x44
Timestamp: 3327596
Subpixel: unknown
Clones:
CRTCs: 0 1
Transform: 1.000000 0.000000 0.000000
0.000000 1.000000 0.000000
0.000000 0.000000 1.000000
filter:
bottom margin: 37 (0x00000025) range: (0,100)
right margin: 46 (0x0000002e) range: (0,100)
top margin: 36 (0x00000024) range: (0,100)
left margin: 54 (0x00000036) range: (0,100)
mode: NTSC-M
supported: NTSC-M NTSC-443 NTSC-J PAL-M
PAL-N PAL 480p 576p
720p@60Hz 720p@50Hz 1080i@50Hz 1080i@60Hz
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: 3.10.0+ laptop resolution problem
2013-07-11 18:04 3.10.0+ laptop resolution problem Hans de Bruin
@ 2013-07-11 18:22 ` Daniel Vetter
2013-07-11 19:05 ` Hans de Bruin
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2013-07-11 18:22 UTC (permalink / raw)
To: Hans de Bruin; +Cc: intel-gfx
On Thu, Jul 11, 2013 at 8:04 PM, Hans de Bruin <jmdebruin@xmsnet.nl> wrote:
> somewhere before commit 496322b (yesterday's kernel) resolution switching on
> my laptop broke. The screen switches to the right resolution but the screen
> is not horizontally centered. The screen is aligned left and the last
> vertical line is repeated until the right side of the screen. Normally there
> would be black bars on left and right side.
Can you please boot with drm.debug=0xe added to your kernel cmdline
and then reply with your complete dmesg?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.10.0+ laptop resolution problem
2013-07-11 18:22 ` Daniel Vetter
@ 2013-07-11 19:05 ` Hans de Bruin
2013-07-11 19:41 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Hans de Bruin @ 2013-07-11 19:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On 07/11/2013 08:22 PM, Daniel Vetter wrote:
> On Thu, Jul 11, 2013 at 8:04 PM, Hans de Bruin <jmdebruin@xmsnet.nl> wrote:
>> somewhere before commit 496322b (yesterday's kernel) resolution switching on
>> my laptop broke. The screen switches to the right resolution but the screen
>> is not horizontally centered. The screen is aligned left and the last
>> vertical line is repeated until the right side of the screen. Normally there
>> would be black bars on left and right side.
>
> Can you please boot with drm.debug=0xe added to your kernel cmdline
> and then reply with your complete dmesg?
>
I have also started a bisect. Is it useful to continue that?
--
Hans
[-- Attachment #2: dmesg.txt.gz --]
[-- Type: application/gzip, Size: 54394 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 3.10.0+ laptop resolution problem
2013-07-11 19:05 ` Hans de Bruin
@ 2013-07-11 19:41 ` Daniel Vetter
2013-07-11 21:14 ` Hans de Bruin
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2013-07-11 19:41 UTC (permalink / raw)
To: Hans de Bruin; +Cc: intel-gfx
On Thu, Jul 11, 2013 at 09:05:45PM +0200, Hans de Bruin wrote:
> On 07/11/2013 08:22 PM, Daniel Vetter wrote:
> >On Thu, Jul 11, 2013 at 8:04 PM, Hans de Bruin <jmdebruin@xmsnet.nl> wrote:
> >>somewhere before commit 496322b (yesterday's kernel) resolution switching on
> >>my laptop broke. The screen switches to the right resolution but the screen
> >>is not horizontally centered. The screen is aligned left and the last
> >>vertical line is repeated until the right side of the screen. Normally there
> >>would be black bars on left and right side.
> >
> >Can you please boot with drm.debug=0xe added to your kernel cmdline
> >and then reply with your complete dmesg?
> >
>
> I have also started a bisect. Is it useful to continue that?
Let's first see whether my bug-spotting skills are still in working order.
Please test the below diff, thanks.
-Daniel
---
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index b0e1088..0536c9b 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -297,14 +297,11 @@ static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
intel_pch_panel_fitting(intel_crtc, pipe_config,
intel_connector->panel.fitting_mode);
- return true;
} else {
intel_gmch_panel_fitting(intel_crtc, pipe_config,
intel_connector->panel.fitting_mode);
- }
- drm_mode_set_crtcinfo(adjusted_mode, 0);
- pipe_config->timings_set = true;
+ }
/*
* XXX: It would be nice to support lower refresh rates on the
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
index 80bea1d..45010bb 100644
--- a/drivers/gpu/drm/i915/intel_panel.c
+++ b/drivers/gpu/drm/i915/intel_panel.c
@@ -194,6 +194,9 @@ void intel_gmch_panel_fitting(struct intel_crtc *intel_crtc,
adjusted_mode->vdisplay == mode->vdisplay)
goto out;
+ drm_mode_set_crtcinfo(adjusted_mode, 0);
+ pipe_config->timings_set = true;
+
switch (fitting_mode) {
case DRM_MODE_SCALE_CENTER:
/*
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: 3.10.0+ laptop resolution problem
2013-07-11 19:41 ` Daniel Vetter
@ 2013-07-11 21:14 ` Hans de Bruin
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Bruin @ 2013-07-11 21:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On 07/11/2013 09:41 PM, Daniel Vetter wrote:
> On Thu, Jul 11, 2013 at 09:05:45PM +0200, Hans de Bruin wrote:
>> On 07/11/2013 08:22 PM, Daniel Vetter wrote:
>>> On Thu, Jul 11, 2013 at 8:04 PM, Hans de Bruin <jmdebruin@xmsnet.nl> wrote:
>>>> somewhere before commit 496322b (yesterday's kernel) resolution switching on
>>>> my laptop broke. The screen switches to the right resolution but the screen
>>>> is not horizontally centered. The screen is aligned left and the last
>>>> vertical line is repeated until the right side of the screen. Normally there
>>>> would be black bars on left and right side.
>>>
>>> Can you please boot with drm.debug=0xe added to your kernel cmdline
>>> and then reply with your complete dmesg?
>>>
>>
>> I have also started a bisect. Is it useful to continue that?
>
> Let's first see whether my bug-spotting skills are still in working order.
> Please test the below diff, thanks.
Apparently the are. The diff fixes my problem.
--
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-11 21:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11 18:04 3.10.0+ laptop resolution problem Hans de Bruin
2013-07-11 18:22 ` Daniel Vetter
2013-07-11 19:05 ` Hans de Bruin
2013-07-11 19:41 ` Daniel Vetter
2013-07-11 21:14 ` Hans de Bruin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox