From: Chad Versace <chad.versace@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] [v3] drm/i915: Make i915 events part of uapi
Date: Fri, 19 Jul 2013 15:35:23 -0700 [thread overview]
Message-ID: <51E9BF2B.1030402@linux.intel.com> (raw)
In-Reply-To: <1374250602-32375-1-git-send-email-ben@bwidawsk.net>
On 07/19/2013 09:16 AM, Ben Widawsky wrote:
> Make the uevent strings part of the user API for people who wish to
> write their own listeners.
>
> v2: Make a space in the string concatenation. (Chad)
> Use the "UEVENT" suffix intead of "EVENT" (Chad)
> Make kernel-doc parseable Docbook comments (Daniel)
>
> v3: Undid reset change introduced in last submission (Daniel)
> Fixed up comments to address removal changes.
>
> Thanks to Daniel Vetter for a majority of the parity error comments.
>
> CC: Chad Versace <chad.versace@linux.intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 8 ++++----
> include/uapi/drm/i915_drm.h | 24 ++++++++++++++++++++++++
> 2 files changed, 28 insertions(+), 4 deletions(-)
For what it's worth,
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>
prev parent reply other threads:[~2013-07-19 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 23:41 [PATCH] drm/i915: Make i915 events part of uapi Ben Widawsky
2013-07-17 5:07 ` Daniel Vetter
2013-07-17 21:12 ` Chad Versace
2013-07-19 5:42 ` [PATCH 1/3] drm/i915: Move error uevent to detection time Ben Widawsky
2013-07-19 5:42 ` [PATCH 2/3] drm/i915: Change uevent for reset completion Ben Widawsky
2013-07-19 6:57 ` Daniel Vetter
2013-07-19 5:42 ` [PATCH 3/3] [v2] drm/i915: Make i915 events part of uapi Ben Widawsky
2013-07-19 8:45 ` [PATCH 1/3] drm/i915: Move error uevent to detection time Chris Wilson
2013-07-19 16:16 ` [PATCH] [v3] drm/i915: Make i915 events part of uapi Ben Widawsky
2013-07-19 16:27 ` Daniel Vetter
2013-07-19 22:35 ` Chad Versace [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E9BF2B.1030402@linux.intel.com \
--to=chad.versace@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox