From: Chad Versace <chad.versace@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3
Date: Thu, 25 Jul 2013 09:55:50 -0700 [thread overview]
Message-ID: <51F15896.3010601@linux.intel.com> (raw)
In-Reply-To: <1374710683-2614-1-git-send-email-jbarnes@virtuousgeek.org>
On 07/24/2013 05:04 PM, Jesse Barnes wrote:
> For use by userspace (at some point in the future) and other kernel code.
>
> v2: move PCI IDs to uabi (Chris)
> move PCI IDs to drm/ (Dave)
> v3: fixup Quanta detection - needs to come first (Daniel)
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 164 +++++++-----------------------
> include/drm/i915_drm.h | 2 +
> include/drm/i915_pciids.h | 208 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 244 insertions(+), 130 deletions(-)
> create mode 100644 include/drm/i915_pciids.h
> +#define INTEL_VGA_DEVICE(id, info) { \
> + .class = PCI_BASE_CLASS_DISPLAY << 16, \
> + .class_mask = 0xff0000, \
> + .vendor = 0x8086, \
> + .device = id, \
> + .subvendor = PCI_ANY_ID, \
> + .subdevice = PCI_ANY_ID, \
> + .driver_data = (unsigned long) info }
I retract my objections from yesterday. I expected the header to define
a static table (like static const struct xxx i915_pci_ids[] = ...), which
I didn't like due its inflexibility. But, this macro I do like. It's
flexible enough.
Acked-by: Chad Versace <chad.versace@linux.intel.com>
next prev parent reply other threads:[~2013-07-25 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 0:04 [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Jesse Barnes
2013-07-25 0:04 ` [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3 Jesse Barnes
2013-07-25 7:41 ` Daniel Vetter
2013-07-25 8:34 ` Chris Wilson
2013-07-25 8:36 ` Daniel Vetter
2013-07-25 10:02 ` [PATCH 1/3] x86: Use a custom name for the Intel Graphics Stolen reservation Chris Wilson
2013-07-25 10:02 ` [PATCH 2/3] resource: Introduce lookup_resource_by_name() Chris Wilson
2013-07-25 10:02 ` [PATCH 3/3] drm/i915: Lookup stolen region reserved during early PCI quirk processing Chris Wilson
2013-07-25 16:55 ` Chad Versace [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 16:37 Ugly patches for stolen reservation Jesse Barnes
2013-07-25 16:37 ` [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Jesse Barnes
2013-07-25 23:06 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F15896.3010601@linux.intel.com \
--to=chad.versace@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox