From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3
Date: Thu, 25 Jul 2013 10:36:33 +0200 [thread overview]
Message-ID: <20130725083633.GF5939@phenom.ffwll.local> (raw)
In-Reply-To: <20130725083405.GA5134@cantiga.alporthouse.com>
On Thu, Jul 25, 2013 at 09:34:05AM +0100, Chris Wilson wrote:
> On Thu, Jul 25, 2013 at 09:41:49AM +0200, Daniel Vetter wrote:
> > On Wed, Jul 24, 2013 at 05:04:43PM -0700, Jesse Barnes wrote:
> > Two bikesheds:
> > - Can't we give the thing a better name like "Intel Graphics Stolen"?
>
> Using a custom type and name seems simple enough and naturally leads it
> to ending up in iomem_resource.
>
> > - Can't we store the iomem region somewhere so that intel-gtt.ko and
> > i915.ko can get at it and we could drop the duplicated stolen detection
> > code?
>
> The choice is then walking the resource list looking for our named
> region or reading a couple of registers. Certainly walking the iomem makes
> everything much clearer.
Oh, I like this ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-07-25 8:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 0:04 [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Jesse Barnes
2013-07-25 0:04 ` [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3 Jesse Barnes
2013-07-25 7:41 ` Daniel Vetter
2013-07-25 8:34 ` Chris Wilson
2013-07-25 8:36 ` Daniel Vetter [this message]
2013-07-25 10:02 ` [PATCH 1/3] x86: Use a custom name for the Intel Graphics Stolen reservation Chris Wilson
2013-07-25 10:02 ` [PATCH 2/3] resource: Introduce lookup_resource_by_name() Chris Wilson
2013-07-25 10:02 ` [PATCH 3/3] drm/i915: Lookup stolen region reserved during early PCI quirk processing Chris Wilson
2013-07-25 16:55 ` [PATCH 1/2] drm/i915: split PCI IDs out into i915_drm.h v3 Chad Versace
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 16:37 Ugly patches for stolen reservation Jesse Barnes
2013-07-25 16:37 ` [PATCH 2/2] x86: add early quirk for reserving Intel graphics stolen memory v3 Jesse Barnes
2013-07-25 22:42 ` Chris Wilson
2013-07-25 22:59 ` Chris Wilson
2013-07-25 23:18 ` Jesse Barnes
2013-07-26 16:58 ` H. Peter Anvin
2013-07-26 17:12 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725083633.GF5939@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox