public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org"
	<xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org>
Cc: Peter Hutterer <peter.hutterer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: What to do with xf86-video-intel backlight control when running Xorg as non root
Date: Thu, 13 Feb 2014 16:52:59 +0100	[thread overview]
Message-ID: <52FCEA5B.9020107@redhat.com> (raw)

Hi All,

Currently xf86-video-intel is unique in that it is the only video driver
which does backlight control inside the driver rather then letting
something else (ie the desktop environment) deal with it.

This is a problem when running the xserver without root rights because
writing /sys/class/backlight/foo/brightness requires root rights.

There are 2 possible (short term) solutions for this:

1) Detect that the xserver is not running as root, and don't register the
backlight property on the connectors, let something else deal with it,
as is done or other xf86-video-* drivers already.

2) Add a little xf86-video-intel-brightness helper on Linux which the driver
execs (through pkexec) each time it needs to set the brightness.


1) of course is very KISS, so I like. 2) is not that hard either, and
1) might cause some regressions in cases where ie gsd-brightness-helper
does not do the right thing, where as the intel driver does. OTOH it seems
that the intel video code is mostly there to deal with older kernels, and
rootless xorg will be used with newer kernels only anyways.

So before I start writing a patch for this I would like to hear which
approach would be acceptable for inclusion into xf86-video-intel.

Regards,

Hans
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

             reply	other threads:[~2014-02-13 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 15:52 Hans de Goede [this message]
2014-02-13 16:40 ` What to do with xf86-video-intel backlight control when running Xorg as non root Chris Wilson
     [not found]   ` <20140213164040.GA30700-aII6DKEyn0pWYbfKqPwjAkR8Iwp7RQ6xAL8bYrjMMd8@public.gmane.org>
2014-02-13 19:37     ` [Intel-gfx] " Hans de Goede
2014-02-13 20:24       ` Mark Kettenis
     [not found]         ` <201402132024.s1DKOdTt007144-5zo/SKdWyaISnfzBdFZQ6Ptv54+FKcWohFar9KRE0fA@public.gmane.org>
2014-02-14  8:48           ` [Intel-gfx] " Hans de Goede
     [not found]       ` <52FD1F0B.9000206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-13 20:51         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52FCEA5B.9020107@redhat.com \
    --to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=peter.hutterer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox