From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Mark Kettenis <mark.kettenis-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
Cc: Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
peter.hutterer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org
Subject: Re: [Intel-gfx] What to do with xf86-video-intel backlight control when running Xorg as non root
Date: Fri, 14 Feb 2014 09:48:08 +0100 [thread overview]
Message-ID: <52FDD848.3040109@redhat.com> (raw)
In-Reply-To: <201402132024.s1DKOdTt007144-5zo/SKdWyaISnfzBdFZQ6Ptv54+FKcWohFar9KRE0fA@public.gmane.org>
Hi,
On 02/13/2014 09:24 PM, Mark Kettenis wrote:
>> Date: Thu, 13 Feb 2014 20:37:47 +0100
>> From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
<snip>
>> Right, that is what I was thinking too, so the question then becomes how
>> hard you will scream at me if I add something like this to xf86-video-intel
>> linux specific backlight code:
>>
>> if (geteuid() == 0) {
>> /* Old write directly to /sys/class/backlight/... code */
>> {
>> else {
>> /* The & is to avoid the xserver blocking */
>> snprintf(command, sizeof(command), "pkexec %s/libexec/xf86-video-intel-backlight-helper %s %d&",
>> PREFIX, sna_output->backlight_iface, level);
>> r = system(command);
>> if (r) {
>> /* complain */
>> }
>> }
>>
>> If you won't scream too much, and more importantly, if you will accept such
>> a patch (including code for the helper), then I'll try to cook up something
>> like this tomorrow.
>
> I don't really care as long as this is #ifdef __linux__, but yeah,
> that's fairly gross. Does the Linux community really think it is a
> good idea that the xserver starts to depend on policykit.
It does not look like policykit will be going away anytime soon.
Also note that this is intended as an interim solution until we sort out the
backlight mess in a better way, see the "Fixing the kernels backlight API"
thread on xorg-devel.
Regards,
Hans
_______________________________________________
xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
next prev parent reply other threads:[~2014-02-14 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 15:52 What to do with xf86-video-intel backlight control when running Xorg as non root Hans de Goede
2014-02-13 16:40 ` Chris Wilson
[not found] ` <20140213164040.GA30700-aII6DKEyn0pWYbfKqPwjAkR8Iwp7RQ6xAL8bYrjMMd8@public.gmane.org>
2014-02-13 19:37 ` [Intel-gfx] " Hans de Goede
2014-02-13 20:24 ` Mark Kettenis
[not found] ` <201402132024.s1DKOdTt007144-5zo/SKdWyaISnfzBdFZQ6Ptv54+FKcWohFar9KRE0fA@public.gmane.org>
2014-02-14 8:48 ` Hans de Goede [this message]
[not found] ` <52FD1F0B.9000206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-02-13 20:51 ` [Intel-gfx] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FDD848.3040109@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=mark.kettenis-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \
--cc=peter.hutterer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox