Re: [PATCH] drm/i915: Use hash tables for the command parser

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

Hi Brad,

On 04/28/2014 04:22 PM, bradley.d.volkin@intel.com wrote:
[snip]
> -	BUG_ON(!validate_cmds_sorted(ring));
> +	BUG_ON(!validate_cmds_sorted(ring, cmd_tables, cmd_table_count));
>   	BUG_ON(!validate_regs_sorted(ring));
> +
> +	BUG_ON(init_hash_table(ring, cmd_tables, cmd_table_count));

Is a BUG_ON a bit harsh since the above fails only on ENOMEM condition?

If the concern is not allowing any command execution if parser setup has 
failed, it would be nicer to the system as whole to just keep rejecting 
everything, but let the rest of the kernel live to enable debug or whatever?

I know it won't happen almost ever so it's a minor point really. I just 
dislike actively hosing the whole system if it is avoidable.

Regards,

Tvrtko