From: "Sun, Daisy" <daisy.sun@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/bdw: BDW Software Turbo
Date: Fri, 25 Jul 2014 08:51:13 -0700 [thread overview]
Message-ID: <53D27CF1.9030209@intel.com> (raw)
In-Reply-To: <20140725072210.GF4747@phenom.ffwll.local>
Yes, timer can be helpful. A revised proposal is that flip trigger +
timer to cover together. I'll come up with more details soon.
- Daisy
On 7/25/2014 12:22 AM, Daniel Vetter wrote:
> On Thu, Jul 24, 2014 at 01:28:21PM -0700, Jesse Barnes wrote:
>> If that won't work, you could just use a timer, or tie into some other
>> event that happens when the GPU is busy (e.g. execbuf or retire) instead
>> of trying to tie into the display side of things.
> Yes, tying into a normal timer is probably best. At least I get the
> impression that we only need something regular. Of course once the gpu is
> idle we need to stop rearming that timer and restart it upon first batch
> when transitioning out of idle.
> -Daniel
>
>> Jesse
>>
>> On Tue, 15 Jul 2014 06:35:20 +0000
>> "Sun, Daisy" <daisy.sun@intel.com> wrote:
>>
>>> Hi Daniel, Chris
>>>
>>> The concern for traditional X and media server do make sense. I'll update the patch with RP_UP_EI_INTERRUPT as trigger instead of the page flip.
>>> Thanks for the valuable input.
>>>
>>> - Daisy
>>>
>>> -----Original Message-----
>>> From: daniel.vetter@ffwll.ch [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
>>> Sent: Monday, July 14, 2014 12:04 AM
>>> To: Sun, Daisy
>>> Cc: Chris Wilson; intel-gfx@lists.freedesktop.org
>>> Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/bdw: BDW Software Turbo
>>>
>>> On Mon, Jul 14, 2014 at 8:59 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
>>>> On Mon, Jul 14, 2014 at 04:22:44AM +0000, Sun, Daisy wrote:
>>>>> 3) The function will be called when flip happened, this should cover
>>>>> most of the cases. One exception is background media process without
>>>>> any display output, it's relatively rare. Please let me know if you
>>>>> have concern on other cases, I will try to cover it definitely.
>>>> Traditional X never flips. And we kinda have to keep this working.
>>>> Instead of checking when flipping we need to check at regular time
>>>> intervals I guess, for as long as the gt is busy.
>>> Oh and transcode servers are a real thing apparently. They also never flip, and we actually care from a business pov ...
>>> -Daniel
>>> --
>>> Daniel Vetter
>>> Software Engineer, Intel Corporation
>>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>>
>>
>> --
>> Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-07-25 15:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 1:00 [PATCH v2] drm/i915/bdw: BDW Software Turbo Daisy Sun
2014-07-10 8:32 ` Chris Wilson
2014-07-10 18:42 ` Sun, Daisy
2014-07-10 19:07 ` Chris Wilson
2014-07-11 2:39 ` Sun, Daisy
2014-07-11 6:15 ` Chris Wilson
2014-07-14 4:22 ` Sun, Daisy
2014-07-14 6:59 ` Daniel Vetter
2014-07-14 7:03 ` Daniel Vetter
2014-07-15 6:35 ` Sun, Daisy
2014-07-24 20:28 ` Jesse Barnes
2014-07-25 7:22 ` Daniel Vetter
2014-07-25 15:51 ` Sun, Daisy [this message]
2014-07-26 0:47 ` Sun, Daisy
2014-07-28 9:17 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D27CF1.9030209@intel.com \
--to=daisy.sun@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox