From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: constify mode in crtc_mode_fixup
Date: Fri, 20 Jul 2012 11:46:21 +0200 [thread overview]
Message-ID: <5505595.GGsCnT1aWL@avalon> (raw)
In-Reply-To: <1342773045-779-1-git-send-email-daniel.vetter@ffwll.ch>
Hi Daniel,
On Friday 20 July 2012 10:30:45 Daniel Vetter wrote:
> Laurent Pinchart missed this when sending in is giant constify patch:
My bad, sorry. I would have sworn I had compiled all the x86 DRM drivers, that
warning must have slipped through the cracks somehow. Thank you for the fix.
> commit e811f5ae19043b2ac2c28e147a4274038e655598
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date: Tue Jul 17 17:56:50 2012 +0200
>
> drm: Make the .mode_fixup() operations mode argument a const pointer
>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 1802c30..fdd7671 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3575,7 +3575,7 @@ void intel_encoder_destroy(struct drm_encoder
> *encoder) }
>
> static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
> - struct drm_display_mode *mode,
> + const struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> {
> struct drm_device *dev = crtc->dev;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-07-20 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 8:30 [PATCH] drm/i915: constify mode in crtc_mode_fixup Daniel Vetter
2012-07-20 9:46 ` Laurent Pinchart [this message]
2012-07-23 9:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5505595.GGsCnT1aWL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox