* [PATCH] drm/i915: constify mode in crtc_mode_fixup
@ 2012-07-20 8:30 Daniel Vetter
2012-07-20 9:46 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2012-07-20 8:30 UTC (permalink / raw)
To: Dave Airlie; +Cc: Daniel Vetter, Intel Graphics Development, DRI Development
Laurent Pinchart missed this when sending in is giant constify patch:
commit e811f5ae19043b2ac2c28e147a4274038e655598
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue Jul 17 17:56:50 2012 +0200
drm: Make the .mode_fixup() operations mode argument a const pointer
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 1802c30..fdd7671 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3575,7 +3575,7 @@ void intel_encoder_destroy(struct drm_encoder *encoder)
}
static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
- struct drm_display_mode *mode,
+ const struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_device *dev = crtc->dev;
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: constify mode in crtc_mode_fixup
2012-07-20 8:30 [PATCH] drm/i915: constify mode in crtc_mode_fixup Daniel Vetter
@ 2012-07-20 9:46 ` Laurent Pinchart
2012-07-23 9:35 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2012-07-20 9:46 UTC (permalink / raw)
To: dri-devel; +Cc: Daniel Vetter, Intel Graphics Development
Hi Daniel,
On Friday 20 July 2012 10:30:45 Daniel Vetter wrote:
> Laurent Pinchart missed this when sending in is giant constify patch:
My bad, sorry. I would have sworn I had compiled all the x86 DRM drivers, that
warning must have slipped through the cracks somehow. Thank you for the fix.
> commit e811f5ae19043b2ac2c28e147a4274038e655598
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date: Tue Jul 17 17:56:50 2012 +0200
>
> drm: Make the .mode_fixup() operations mode argument a const pointer
>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index 1802c30..fdd7671 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3575,7 +3575,7 @@ void intel_encoder_destroy(struct drm_encoder
> *encoder) }
>
> static bool intel_crtc_mode_fixup(struct drm_crtc *crtc,
> - struct drm_display_mode *mode,
> + const struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> {
> struct drm_device *dev = crtc->dev;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: constify mode in crtc_mode_fixup
2012-07-20 9:46 ` Laurent Pinchart
@ 2012-07-23 9:35 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2012-07-23 9:35 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Daniel Vetter, Intel Graphics Development, dri-devel
On Fri, Jul 20, 2012 at 11:46:21AM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Friday 20 July 2012 10:30:45 Daniel Vetter wrote:
> > Laurent Pinchart missed this when sending in is giant constify patch:
>
> My bad, sorry. I would have sworn I had compiled all the x86 DRM drivers, that
> warning must have slipped through the cracks somehow. Thank you for the fix.
>
> > commit e811f5ae19043b2ac2c28e147a4274038e655598
> > Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Date: Tue Jul 17 17:56:50 2012 +0200
> >
> > drm: Make the .mode_fixup() operations mode argument a const pointer
> >
> > Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Acked-by; Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Picked up for -fixes, thanks for the ack.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-23 9:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-20 8:30 [PATCH] drm/i915: constify mode in crtc_mode_fixup Daniel Vetter
2012-07-20 9:46 ` Laurent Pinchart
2012-07-23 9:35 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox