From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Matthew Auld <matthew.william.auld@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: simplify bind_to_vm init code
Date: Thu, 17 Mar 2016 17:36:46 +0000 [thread overview]
Message-ID: <56EAEB2E.4050003@linux.intel.com> (raw)
In-Reply-To: <CAM0jSHMo_hvPn25Fr4zZ=8uKtkP7DhhbfU+xbc4zUz-tstpsYg@mail.gmail.com>
On 17/03/16 13:41, Matthew Auld wrote:
> Hi,
>
> If we don't do any of the fence business for !i915_is_gtt, then will
> this not change the following code:
>
> if (alignment == 0)
> alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment;
>
> Or am I missing something?
No I missed that bit. In which case your cleanup looks OK to me in
principle. I would just not use obj_size since it is not that. Perhaps
just reuse the existing size variable to hold the intermediate result?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-17 17:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 17:07 [PATCH] drm/i915: simplify bind_to_vm init code Matthew Auld
2016-03-17 10:00 ` Tvrtko Ursulin
2016-03-17 13:41 ` Matthew Auld
2016-03-17 13:53 ` Chris Wilson
2016-03-17 17:36 ` Tvrtko Ursulin [this message]
2016-03-17 10:36 ` ✗ Fi.CI.BAT: failure for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2016-03-18 10:46 [PATCH] " Matthew Auld
2016-03-18 11:10 ` Tvrtko Ursulin
2016-03-18 11:26 ` Chris Wilson
2016-03-18 13:54 Matthew Auld
2016-03-22 10:36 ` Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAEB2E.4050003@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.william.auld@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox