[PATCH] drm/i915/BXT: Bug fix for IS_BROXTON usage

[PATCH] drm/i915/BXT: Bug fix for IS_BROXTON usage

[Ramalingam C]

Parameter to IS_BROXTON() is supposed to be dev not dev_priv

If needed this could be squashed to the source of the bug.
	'commit 4d1de9756832 ("drm/i915/bxt: add dsi transcoders")'
	Date:   Fri Mar 18 17:05:42 2016 +0200

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c0627d6..c5c9406 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9988,7 +9988,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
 
 	active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_mask);
 
-	if (IS_BROXTON(dev_priv)) {
+	if (IS_BROXTON(dev)) {
 		bxt_get_dsi_transcoder_state(crtc, pipe_config,
 					     &power_domain_mask);
 		WARN_ON(active && pipe_config->has_dsi_encoder);
-- 
1.7.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/BXT: Bug fix for IS_BROXTON usage

[Chris Wilson]

On Tue, Mar 29, 2016 at 10:57:07PM +0530, Ramalingam C wrote:
> Parameter to IS_BROXTON() is supposed to be dev not dev_priv

You have that backwards. dev_priv is the native pointer that dev is
automagically converted to. INTEL_INFO() takes *drm_i915_private*.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/BXT: Bug fix for IS_BROXTON usage

[Ramalingam C]

On Wednesday 30 March 2016 01:20 AM, Chris Wilson wrote:
> On Tue, Mar 29, 2016 at 10:57:07PM +0530, Ramalingam C wrote:
>> Parameter to IS_BROXTON() is supposed to be dev not dev_priv
> You have that backwards. dev_priv is the native pointer that dev is
> automagically converted to. INTEL_INFO() takes *drm_i915_private*.
> -Chris
Oops. Sorry for unwanted noise.
>

-- 
Thanks,
--Ram

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915/BXT: Bug fix for IS_BROXTON usage

[Patchwork]

== Series Details ==

Series: drm/i915/BXT: Bug fix for IS_BROXTON usage
URL   : https://patchwork.freedesktop.org/series/5004/
State : failure

== Summary ==

Series 5004v1 drm/i915/BXT: Bug fix for IS_BROXTON usage
http://patchwork.freedesktop.org/api/1.0/series/5004/revisions/1/mbox/

Test drv_module_reload_basic:
                dmesg-warn -> DMESG-FAIL (hsw-brixbox)
Test gem_cs_tlb:
        Subgroup basic-default:
                pass       -> DMESG-WARN (ivb-t430s)
Test gem_ctx_switch:
        Subgroup basic-default:
                pass       -> FAIL       (bdw-ultra)
Test gem_exec_nop:
        Subgroup basic:
                fail       -> PASS       (snb-x220t)
                pass       -> FAIL       (bdw-ultra)
Test gem_exec_suspend:
        Subgroup basic-s4:
                skip       -> FAIL       (bdw-ultra)
Test gem_exec_whisper:
        Subgroup basic:
                pass       -> FAIL       (bdw-ultra)
Test gem_mmap_gtt:
        Subgroup basic-read-write-distinct:
                incomplete -> PASS       (snb-x220t)
Test gem_sync:
        Subgroup basic-all:
                fail       -> PASS       (snb-x220t)
                pass       -> FAIL       (bdw-ultra)
        Subgroup basic-blt:
                pass       -> FAIL       (bdw-ultra)
        Subgroup basic-bsd:
                pass       -> FAIL       (bdw-ultra)
        Subgroup basic-default:
                pass       -> FAIL       (bdw-ultra)
        Subgroup basic-render:
                pass       -> FAIL       (bdw-ultra) UNSTABLE
        Subgroup basic-vebox:
                pass       -> FAIL       (bdw-ultra)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-WARN (ilk-hp8440p) UNSTABLE
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (ilk-hp8440p) UNSTABLE
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                dmesg-fail -> SKIP       (snb-x220t)
                pass       -> DMESG-WARN (bsw-nuc-2)
Test pm_rpm:
        Subgroup basic-rte:
                dmesg-warn -> PASS       (byt-nuc) UNSTABLE
Test prime_self_import:
        Subgroup basic-with_fd_dup:
                incomplete -> PASS       (snb-x220t)

bdw-nuci7        total:195  pass:181  dwarn:1   dfail:0   fail:1   skip:12 
bdw-ultra        total:195  pass:162  dwarn:1   dfail:0   fail:12  skip:20 
bsw-nuc-2        total:195  pass:155  dwarn:2   dfail:0   fail:1   skip:37 
byt-nuc          total:195  pass:158  dwarn:1   dfail:0   fail:1   skip:35 
hsw-brixbox      total:195  pass:171  dwarn:0   dfail:1   fail:1   skip:22 
hsw-gt2          total:195  pass:176  dwarn:1   dfail:0   fail:1   skip:17 
ilk-hp8440p      total:195  pass:127  dwarn:2   dfail:0   fail:2   skip:64 
ivb-t430s        total:195  pass:167  dwarn:2   dfail:0   fail:1   skip:25 
skl-i7k-2        total:195  pass:170  dwarn:1   dfail:0   fail:1   skip:23 
snb-dellxps      total:195  pass:159  dwarn:1   dfail:0   fail:1   skip:34 
snb-x220t        total:195  pass:159  dwarn:1   dfail:0   fail:2   skip:33 

Results at /archive/results/CI_IGT_test/Patchwork_1736/

2702045fbd4188c1c26bd890bc43976fd10937ad drm-intel-nightly: 2016y-03m-29d-12h-21m-19s UTC integration manifest
65daa9aec8c89965fa323d5fc34829ecf4865ecd drm/i915/BXT: Bug fix for IS_BROXTON usage

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx