From: Dave Gordon <david.s.gordon@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Do not use a bitfield for INTEL_INFO->num_pipes
Date: Fri, 6 May 2016 20:21:28 +0100 [thread overview]
Message-ID: <572CEEB8.9070601@intel.com> (raw)
In-Reply-To: <1462544186-34818-2-git-send-email-tvrtko.ursulin@linux.intel.com>
On 06/05/16 15:16, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It just makes more work for the compiler and generates more code.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 935e381407ba..f7a156b8d5a1 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -758,7 +758,7 @@ struct intel_csr {
> struct intel_device_info {
> u32 display_mmio_offset;
> u16 device_id;
> - u8 num_pipes:3;
> + u8 num_pipes;
> u8 num_sprites[I915_MAX_PIPES];
> u8 gen;
> u16 gen_mask;
On my build, this saves 322 bytes, which (since it eliminates just ONE
three-byte instruction on each use), suggests it's used quite a lot!
Reviewed-by: Dave Gordon <david.s.gordon@intel.com>
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-05-06 19:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 13:43 [PATCH 1/3] drm/i915: Make IS_GENx macros work on a mask Tvrtko Ursulin
2016-05-06 13:43 ` [PATCH 2/3] drm/i915: Promote IS_BROADWELL to a simple macro Tvrtko Ursulin
2016-05-06 14:00 ` Ville Syrjälä
2016-05-06 14:18 ` Tvrtko Ursulin
2016-05-06 14:29 ` Ville Syrjälä
2016-05-06 14:44 ` Tvrtko Ursulin
2016-05-06 14:51 ` Chris Wilson
2016-05-06 14:58 ` Ville Syrjälä
2016-05-06 13:43 ` [PATCH 3/3] drm/i915: Replace "INTEL_INFO->gen == x" checks with IS_GENx Tvrtko Ursulin
2016-05-06 13:59 ` Chris Wilson
2016-05-06 14:16 ` Tvrtko Ursulin
2016-05-06 14:20 ` Tvrtko Ursulin
2016-05-09 14:18 ` Dave Gordon
2016-05-10 7:47 ` Jani Nikula
2016-05-06 14:16 ` [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro Tvrtko Ursulin
2016-05-06 14:16 ` [PATCH 2/2] drm/i915: Do not use a bitfield for INTEL_INFO->num_pipes Tvrtko Ursulin
2016-05-06 19:21 ` Dave Gordon [this message]
2016-05-06 14:33 ` [PATCH 1/2] drm/i915: Introduce INTEL_GEN_RANGE macro Chris Wilson
2016-05-06 19:11 ` Dave Gordon
2016-05-09 12:32 ` Jani Nikula
2016-05-09 14:26 ` Dave Gordon
2016-05-09 14:40 ` Jani Nikula
2016-05-09 15:23 ` Chris Wilson
2016-05-10 7:54 ` Jani Nikula
2016-05-06 14:28 ` [PATCH 1/3] drm/i915: Make IS_GENx macros work on a mask Chris Wilson
2016-05-06 14:36 ` Tvrtko Ursulin
2016-05-06 14:43 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572CEEB8.9070601@intel.com \
--to=david.s.gordon@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox