* [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr
@ 2023-06-02 13:23 Jani Nikula
2023-06-02 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2023-06-02 13:23 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Only the EDID code and sysfs should look at the EDID property. Stop
using it.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 2a4df62692a6..165e2c7e3126 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -6,6 +6,7 @@
#include <linux/string_helpers.h>
#include <drm/drm_debugfs.h>
+#include <drm/drm_edid.h>
#include <drm/drm_fourcc.h>
#include "hsw_ips.h"
@@ -228,19 +229,18 @@ static void intel_hdcp_info(struct seq_file *m,
seq_puts(m, "\n");
}
-static void intel_dp_info(struct seq_file *m,
- struct intel_connector *intel_connector)
+static void intel_dp_info(struct seq_file *m, struct intel_connector *connector)
{
- struct intel_encoder *intel_encoder = intel_attached_encoder(intel_connector);
+ struct intel_encoder *intel_encoder = intel_attached_encoder(connector);
struct intel_dp *intel_dp = enc_to_intel_dp(intel_encoder);
- const struct drm_property_blob *edid = intel_connector->base.edid_blob_ptr;
+ const struct edid *edid = drm_edid_raw(connector->detect_edid);
seq_printf(m, "\tDPCD rev: %x\n", intel_dp->dpcd[DP_DPCD_REV]);
seq_printf(m, "\taudio support: %s\n",
- str_yes_no(intel_connector->base.display_info.has_audio));
+ str_yes_no(connector->base.display_info.has_audio));
drm_dp_downstream_debug(m, intel_dp->dpcd, intel_dp->downstream_ports,
- edid ? edid->data : NULL, &intel_dp->aux);
+ edid, &intel_dp->aux);
}
static void intel_dp_mst_info(struct seq_file *m,
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: stop using edid_blob_ptr
2023-06-02 13:23 [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr Jani Nikula
@ 2023-06-02 16:57 ` Patchwork
2023-06-04 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 8:25 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-02 16:57 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6687 bytes --]
== Series Details ==
Series: drm/i915/debugfs: stop using edid_blob_ptr
URL : https://patchwork.freedesktop.org/series/118779/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13221 -> Patchwork_118779v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_118779v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0@lmem0:
- bat-dg2-11: [PASS][1] -> [INCOMPLETE][2] ([i915#6311] / [i915#8011])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-dg2-11/igt@gem_exec_suspend@basic-s0@lmem0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-dg2-11/igt@gem_exec_suspend@basic-s0@lmem0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#5334] / [i915#7872])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886] / [i915#7913])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][7] ([i915#6687])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271]) +14 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][9] -> [FAIL][10] ([i915#7932])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][12] ([i915#7699]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-dg2-11/igt@i915_selftest@live@migrate.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- {bat-mtlp-6}: [DMESG-FAIL][14] ([i915#8497]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-mtlp-6/igt@i915_selftest@live@requests.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][16] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-rpls-2/igt@i915_selftest@live@reset.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-rpls-2/igt@i915_selftest@live@reset.html
#### Warnings ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [INCOMPLETE][18] ([i915#8347]) -> [ABORT][19] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/bat-rpls-1/igt@i915_selftest@live@reset.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/bat-rpls-1/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* Linux: CI_DRM_13221 -> Patchwork_118779v1
CI-20190529: 20190529
CI_DRM_13221: 6dfcdb4ed092b70f18dfdc78ace85adeddee5224 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118779v1: 6dfcdb4ed092b70f18dfdc78ace85adeddee5224 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
41c5714dc2dd drm/i915/debugfs: stop using edid_blob_ptr
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/index.html
[-- Attachment #2: Type: text/html, Size: 8064 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/debugfs: stop using edid_blob_ptr
2023-06-02 13:23 [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr Jani Nikula
2023-06-02 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-04 23:37 ` Patchwork
2023-06-07 8:25 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-04 23:37 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14258 bytes --]
== Series Details ==
Series: drm/i915/debugfs: stop using edid_blob_ptr
URL : https://patchwork.freedesktop.org/series/118779/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13221_full -> Patchwork_118779v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (7 -> 8)
------------------------------
Additional (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_118779v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-glk: [PASS][1] -> [ABORT][2] ([i915#6016] / [i915#7349])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-glk8/igt@gem_busy@close-race.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-glk6/igt@gem_busy@close-race.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2846])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-glk4/igt@gem_exec_fair@basic-deadline.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-glk8/igt@gem_exec_fair@basic-deadline.html
* igt@i915_pipe_stress@stress-xrgb8888-ytiled:
- shard-apl: NOTRUN -> [FAIL][5] ([i915#7036])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl3/igt@i915_pipe_stress@stress-xrgb8888-ytiled.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl3/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271]) +23 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-snb6/igt@kms_flip@2x-plain-flip-fb-recreate.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
- shard-apl: NOTRUN -> [FAIL][8] ([i915#79])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2122])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-glk4/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-glk8/igt@kms_flip@plain-flip-ts-check-interruptible@c-hdmi-a2.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +10 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-snb1/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_vrr@flip-suspend:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579]) +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl2/igt@kms_vrr@flip-suspend.html
* igt@v3d/v3d_wait_bo@unused-bo-1ns:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271]) +54 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl2/igt@v3d/v3d_wait_bo@unused-bo-1ns.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][14] ([i915#6268]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-rkl-3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-tglu}: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-tglu-6/igt@gem_exec_fair@basic-throttle@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-tglu-7/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- shard-glk: [DMESG-WARN][20] ([i915#118]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-glk5/igt@gem_exec_suspend@basic-s0@smem.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-glk1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_mmap_offset@clear@smem0:
- {shard-dg1}: [DMESG-WARN][22] ([i915#8304]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-dg1-15/igt@gem_mmap_offset@clear@smem0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-dg1-16/igt@gem_mmap_offset@clear@smem0.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][24] ([i915#5566]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl3/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-dg1}: [FAIL][26] ([i915#3591]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-dg1-14/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-rkl}: [SKIP][28] ([i915#1397]) -> [PASS][29] +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress.html
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-dg1}: [INCOMPLETE][30] ([i915#8174]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-dg1-14/igt@i915_pm_rpm@system-suspend-modeset.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-dg1-14/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-apl: [ABORT][32] ([i915#180]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13221/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6016]: https://gitlab.freedesktop.org/drm/intel/issues/6016
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7349]: https://gitlab.freedesktop.org/drm/intel/issues/7349
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8174]: https://gitlab.freedesktop.org/drm/intel/issues/8174
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
[i915#8381]: https://gitlab.freedesktop.org/drm/intel/issues/8381
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* Linux: CI_DRM_13221 -> Patchwork_118779v1
CI-20190529: 20190529
CI_DRM_13221: 6dfcdb4ed092b70f18dfdc78ace85adeddee5224 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_118779v1: 6dfcdb4ed092b70f18dfdc78ace85adeddee5224 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_118779v1/index.html
[-- Attachment #2: Type: text/html, Size: 10593 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr
2023-06-02 13:23 [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr Jani Nikula
2023-06-02 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-07 8:25 ` Hogander, Jouni
2023-06-07 10:20 ` Jani Nikula
2 siblings, 1 reply; 5+ messages in thread
From: Hogander, Jouni @ 2023-06-07 8:25 UTC (permalink / raw)
To: Nikula, Jani, intel-gfx@lists.freedesktop.org
On Fri, 2023-06-02 at 16:23 +0300, Jani Nikula wrote:
> Only the EDID code and sysfs should look at the EDID property. Stop
> using it.
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++----
> --
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 2a4df62692a6..165e2c7e3126 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -6,6 +6,7 @@
> #include <linux/string_helpers.h>
>
> #include <drm/drm_debugfs.h>
> +#include <drm/drm_edid.h>
> #include <drm/drm_fourcc.h>
>
> #include "hsw_ips.h"
> @@ -228,19 +229,18 @@ static void intel_hdcp_info(struct seq_file *m,
> seq_puts(m, "\n");
> }
>
> -static void intel_dp_info(struct seq_file *m,
> - struct intel_connector *intel_connector)
> +static void intel_dp_info(struct seq_file *m, struct intel_connector
> *connector)
> {
> - struct intel_encoder *intel_encoder =
> intel_attached_encoder(intel_connector);
> + struct intel_encoder *intel_encoder =
> intel_attached_encoder(connector);
> struct intel_dp *intel_dp = enc_to_intel_dp(intel_encoder);
> - const struct drm_property_blob *edid = intel_connector-
> >base.edid_blob_ptr;
> + const struct edid *edid = drm_edid_raw(connector-
> >detect_edid);
>
> seq_printf(m, "\tDPCD rev: %x\n", intel_dp-
> >dpcd[DP_DPCD_REV]);
> seq_printf(m, "\taudio support: %s\n",
> - str_yes_no(intel_connector-
> >base.display_info.has_audio));
> + str_yes_no(connector-
> >base.display_info.has_audio));
>
> drm_dp_downstream_debug(m, intel_dp->dpcd, intel_dp-
> >downstream_ports,
> - edid ? edid->data : NULL, &intel_dp-
> >aux);
> + edid, &intel_dp->aux);
> }
>
> static void intel_dp_mst_info(struct seq_file *m,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr
2023-06-07 8:25 ` [Intel-gfx] [PATCH] " Hogander, Jouni
@ 2023-06-07 10:20 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2023-06-07 10:20 UTC (permalink / raw)
To: Hogander, Jouni, intel-gfx@lists.freedesktop.org
On Wed, 07 Jun 2023, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Fri, 2023-06-02 at 16:23 +0300, Jani Nikula wrote:
>> Only the EDID code and sysfs should look at the EDID property. Stop
>> using it.
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Thanks, pushed to drm-intel-next.
BR,
Jani.
>
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++----
>> --
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> index 2a4df62692a6..165e2c7e3126 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
>> @@ -6,6 +6,7 @@
>> #include <linux/string_helpers.h>
>>
>> #include <drm/drm_debugfs.h>
>> +#include <drm/drm_edid.h>
>> #include <drm/drm_fourcc.h>
>>
>> #include "hsw_ips.h"
>> @@ -228,19 +229,18 @@ static void intel_hdcp_info(struct seq_file *m,
>> seq_puts(m, "\n");
>> }
>>
>> -static void intel_dp_info(struct seq_file *m,
>> - struct intel_connector *intel_connector)
>> +static void intel_dp_info(struct seq_file *m, struct intel_connector
>> *connector)
>> {
>> - struct intel_encoder *intel_encoder =
>> intel_attached_encoder(intel_connector);
>> + struct intel_encoder *intel_encoder =
>> intel_attached_encoder(connector);
>> struct intel_dp *intel_dp = enc_to_intel_dp(intel_encoder);
>> - const struct drm_property_blob *edid = intel_connector-
>> >base.edid_blob_ptr;
>> + const struct edid *edid = drm_edid_raw(connector-
>> >detect_edid);
>>
>> seq_printf(m, "\tDPCD rev: %x\n", intel_dp-
>> >dpcd[DP_DPCD_REV]);
>> seq_printf(m, "\taudio support: %s\n",
>> - str_yes_no(intel_connector-
>> >base.display_info.has_audio));
>> + str_yes_no(connector-
>> >base.display_info.has_audio));
>>
>> drm_dp_downstream_debug(m, intel_dp->dpcd, intel_dp-
>> >downstream_ports,
>> - edid ? edid->data : NULL, &intel_dp-
>> >aux);
>> + edid, &intel_dp->aux);
>> }
>>
>> static void intel_dp_mst_info(struct seq_file *m,
>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-07 10:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 13:23 [Intel-gfx] [PATCH] drm/i915/debugfs: stop using edid_blob_ptr Jani Nikula
2023-06-02 16:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 23:37 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 8:25 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2023-06-07 10:20 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox