From: Chris Wilson <chris@chris-wilson.co.uk>
To: Kenneth Graunke <kenneth@whitecape.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATH v2 6/6] Xv: dont call intel_wait_for_scanline on Sandybridge
Date: Fri, 29 Oct 2010 09:20:11 +0100 [thread overview]
Message-ID: <5b55a1$iglnjn@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <201010282342.05806.kenneth@whitecape.org>
On Thu, 28 Oct 2010 23:42:05 -0700, Kenneth Graunke <kenneth@whitecape.org> wrote:
> On Tuesday 26 October 2010 19:17:33 Xiang, Haihao wrote:
> > MI_LOAD_SCAN_LINE_INCL command is not available on sandybridge.
> >
> > Signed-off-by: Xiang, Haihao <haihao.xiang@intel.com>
> > ---
> > src/intel_video.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/intel_video.c b/src/intel_video.c
> > index afc2405..cdff149 100644
> > --- a/src/intel_video.c
> > +++ b/src/intel_video.c
> > @@ -1578,7 +1578,7 @@ I830PutImageTextured(ScrnInfoPtr scrn,
> > return BadAlloc;
> > }
> >
> > - if (crtc && adaptor_priv->SyncToVblank != 0) {
> > + if (crtc && adaptor_priv->SyncToVblank != 0 && INTEL_INFO(intel)->gen <
> > 60) { intel_wait_for_scanline(scrn, pixmap, crtc, clipBoxes);
> > }
>
> I think you mean < 6 here (not 60)?
No, 60. It's generation*10 + minor revision, just so that g33 and g45
could be easily identified from their gen3 and gen4 brethen.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2010-10-29 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 2:17 [PATH v2 0/6] Xv on Sandybridge Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 1/6] Xv: set the surface state base address Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 2/6] Xv: Send instruction doesn't use implied move when sampling YUV surface Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 3/6] Xv: fragments for xv on Sandybridge Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 4/6] Xv: setup pipeline for Xv " Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 5/6] Xv: enable TextureAdaptor for Sandybridge Xiang, Haihao
2010-10-27 2:17 ` [PATH v2 6/6] Xv: don't call intel_wait_for_scanline on Sandybridge Xiang, Haihao
2010-10-29 6:42 ` Kenneth Graunke
2010-10-29 8:20 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5b55a1$iglnjn@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox