[PATCH] i915: Modify for pineview clock source and lvds sync polarity

[PATCH] i915: Modify for pineview clock source and lvds sync polarity

[Bryan Freed]

[-- Attachment #1.1: Type: text/plain, Size: 3058 bytes --]

The i915 driver normally assumes the video bios has configured several
of the LVDS panel registers, and it just inherits the values. If the
vbios has not run, several of these will need to be setup.

intel_bios.c: default clock source selection on pineview to use the SSC
source
intel_display.c: ensures the sync polarity to the panel is correct.

If these are not correct then although the panel looks ok, output from an
HDMI
encoder (eg, Chrontel CH7036) will be incorrect.

Signed-off-by: Mark Hayter <mdhayter@chromium.org>

Index: drivers/gpu/drm/i915/i915_reg.h
diff --git a/drivers/gpu/drm/i915/i915_reg.h
b/drivers/gpu/drm/i915/i915_reg.h
index
b463a0baa924ff1dee74ca8473b458927cfa0901..e325eaea4bfb289c76a093c5cada026eab6c3983
100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -1056,6 +1056,10 @@
 #define   LVDS_PIPEB_SELECT (1 << 30)
 /* LVDS dithering flag on 965/g4x platform */
 #define   LVDS_ENABLE_DITHER (1 << 25)
+/* LVDS sync polarity flags. Set to invert (i.e. negative) */
+#define   LVDS_VSYNC_POLARITY (1 << 21)
+#define   LVDS_HSYNC_POLARITY (1 << 20)
+
 /* Enable border for unscaled (or aspect-scaled) display */
 #define   LVDS_BORDER_ENABLE (1 << 15)
 /*
Index: drivers/gpu/drm/i915/intel_bios.c
diff --git a/drivers/gpu/drm/i915/intel_bios.c
b/drivers/gpu/drm/i915/intel_bios.c
index
943bbad066af79d6fc62891014f15479213aa34e..e2f3629b46a028077aee214bbc323a1b3ca9ca8f
100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -506,6 +506,14 @@ init_vbt_defaults(struct drm_i915_private *dev_priv)
  dev_priv->int_tv_support = 1;
  dev_priv->int_crt_support = 1;

+ if (IS_PINEVIEW(dev_priv->dev)) {
+ /* On Pineview flip default to use SSC (VBT can override) */
+ dev_priv->lvds_use_ssc = 1;
+ /* The ssc pin gets 100MHz downspread from timing gen */
+ dev_priv->lvds_ssc_freq = 100;
+ } else {
+ dev_priv->lvds_use_ssc = 0;
+ }
  /* Set the Panel Power On/Off timings if uninitialized. */
  if ((I915_READ(PP_ON_DELAYS) == 0) && (I915_READ(PP_OFF_DELAYS) == 0)) {
  /* Set T2 to 40ms and T5 to 200ms */
Index: drivers/gpu/drm/i915/intel_display.c
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index
787e6da01984a2c2296295359250cd436e0cf5fe..48d5994ade661d3213a712512f3e6c96c87dbd1f
100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3334,6 +3334,18 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
  lvds &= ~LVDS_ENABLE_DITHER;
  }
  }
+ /* Only tested on pineview, should work on IS_9XX */
+ if (IS_PINEVIEW(dev)) {
+ /* Set sync polarity for case when vbios did not */
+ if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
+ lvds |= LVDS_HSYNC_POLARITY;
+ if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
+ lvds &= ~LVDS_HSYNC_POLARITY;
+ if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
+ lvds |= LVDS_VSYNC_POLARITY;
+ if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
+ lvds &= ~LVDS_VSYNC_POLARITY;
+ }
  I915_WRITE(lvds_reg, lvds);
  I915_READ(lvds_reg);
  }

[-- Attachment #1.2: Type: text/html, Size: 6225 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] i915: Modify for pineview clock source and lvds sync polarity

[Chris Wilson]

On Wed, 8 Dec 2010 13:46:38 -0800, Bryan Freed <bfreed@chromium.org> wrote:
> The i915 driver normally assumes the video bios has configured several
> of the LVDS panel registers, and it just inherits the values. If the
> vbios has not run, several of these will need to be setup.
> 
> intel_bios.c: default clock source selection on pineview to use the SSC
> source
> intel_display.c: ensures the sync polarity to the panel is correct.

Once again I am astounded that we haven't set the polarities correctly.
Can you split this up into two patches (adjusting the defaults and setting
the sync flags).

> + /* Only tested on pineview, should work on IS_9XX */
> + if (IS_PINEVIEW(dev)) {
> + /* Set sync polarity for case when vbios did not */
> + if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
> + lvds |= LVDS_HSYNC_POLARITY;
> + if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
> + lvds &= ~LVDS_HSYNC_POLARITY;
> + if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
> + lvds |= LVDS_VSYNC_POLARITY;
> + if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
> + lvds &= ~LVDS_VSYNC_POLARITY;
> + }

Aside from being white-space mangled, experience suggests that if we are
going to set some flags, then we should just unconditionally clear them
first. Sooner or later there will be a BIOS that sets conflicting flags.
Furthermore, we should record what the BIOS (as we are currently trusting
the BIOS to set up the internal graphics correctly) set them to and print
a warning if they differ. I forsee bug reports... ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre