Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 1/4] i915/perf: 32bit printf cleanup
Date: Fri, 21 Aug 2020 00:45:23 +0300	[thread overview]
Message-ID: <5bdb17eb-4f92-ac67-5d89-de7b797663f8@intel.com> (raw)
In-Reply-To: <20200820182640.65842-1-chris@chris-wilson.co.uk>

On 20/08/2020 20:26, Chris Wilson wrote:
> Use PRI[du]64 as necessary for 32bit builds.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


Thanks!

-Lionel

> ---
>   tests/i915/perf.c                    | 8 ++++----
>   tools/i915-perf/i915_perf_recorder.c | 2 +-
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 92edc9f1f..a894fd382 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -2077,7 +2077,7 @@ test_blocking(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t ke
>   	user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns;
>   	kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns;
>   
> -	igt_debug("%d blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n",
> +	igt_debug("%d blocking reads during test with %"PRIu64" Hz OA sampling (expect no more than %d)\n",
>   		  n, NSEC_PER_SEC / oa_period, max_iterations);
>   	igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n",
>   		  n_extra_iterations);
> @@ -2265,7 +2265,7 @@ test_polling(uint64_t requested_oa_period, bool set_kernel_hrtimer, uint64_t ker
>   	user_ns = (end_times.tms_utime - start_times.tms_utime) * tick_ns;
>   	kernel_ns = (end_times.tms_stime - start_times.tms_stime) * tick_ns;
>   
> -	igt_debug("%d non-blocking reads during test with %lu Hz OA sampling (expect no more than %d)\n",
> +	igt_debug("%d non-blocking reads during test with %"PRIu64" Hz OA sampling (expect no more than %d)\n",
>   		  n, NSEC_PER_SEC / oa_period, max_iterations);
>   	igt_debug("%d extra iterations seen, not related to periodic sampling (e.g. context switches)\n",
>   		  n_extra_iterations);
> @@ -2357,7 +2357,7 @@ num_valid_reports_captured(struct drm_i915_perf_open_param *param,
>   	int64_t start, end;
>   	int num_reports = 0;
>   
> -	igt_debug("Expected duration = %lu\n", *duration_ns);
> +	igt_debug("Expected duration = %"PRId64"\n", *duration_ns);
>   
>   	stream_fd = __perf_open(drm_fd, param, true);
>   
> @@ -2389,7 +2389,7 @@ num_valid_reports_captured(struct drm_i915_perf_open_param *param,
>   
>   	*duration_ns = end - start;
>   
> -	igt_debug("Actual duration = %lu\n", *duration_ns);
> +	igt_debug("Actual duration = %"PRIu64"\n", *duration_ns);
>   
>   	return num_reports;
>   }
> diff --git a/tools/i915-perf/i915_perf_recorder.c b/tools/i915-perf/i915_perf_recorder.c
> index 7671f39b4..adc41c29f 100644
> --- a/tools/i915-perf/i915_perf_recorder.c
> +++ b/tools/i915-perf/i915_perf_recorder.c
> @@ -1001,7 +1001,7 @@ main(int argc, char *argv[])
>   	}
>   
>   	ctx.oa_exponent = oa_exponent_for_period(ctx.timestamp_frequency, perf_period);
> -	fprintf(stdout, "Opening perf stream with metric_id=%lu oa_exponent=%u\n",
> +	fprintf(stdout, "Opening perf stream with metric_id=%"PRIu64" oa_exponent=%u\n",
>   		ctx.metric_set->perf_oa_metrics_set, ctx.oa_exponent);
>   
>   	ctx.perf_fd = perf_open(&ctx);


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-08-20 21:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 18:26 [Intel-gfx] [PATCH i-g-t 1/4] i915/perf: 32bit printf cleanup Chris Wilson
2020-08-20 18:26 ` [Intel-gfx] [PATCH i-g-t 2/4] i915/gem_exec_fence: Cleanup 32bit printfs Chris Wilson
2020-08-20 18:26 ` [Intel-gfx] [PATCH i-g-t 3/4] i915/bb: " Chris Wilson
2020-08-20 18:26 ` [Intel-gfx] [PATCH i-g-t 4/4] i915/gem_exec_alignment: 32b printf cleanups Chris Wilson
2020-08-20 21:45 ` Lionel Landwerlin [this message]
2020-08-21  7:54   ` [Intel-gfx] [igt-dev] [PATCH i-g-t 1/4] i915/perf: 32bit printf cleanup Petri Latvala
2020-08-21  8:14     ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bdb17eb-4f92-ac67-5d89-de7b797663f8@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox