public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] drm/i915: Simplfy LVDS crtc_mask setup
Date: Thu, 31 Oct 2019 15:34:10 +0200	[thread overview]
Message-ID: <647e333d-64c8-e80f-fe66-f2ee9464179e@gmail.com> (raw)
In-Reply-To: <20191002162505.30716-2-ville.syrjala@linux.intel.com>

 From this set patches 2,5,6 look all ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 2.10.2019 19.25, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We don't need to special case PCH vs. gen4 when setting up the LVDS
> crtc_mask. Just claim pipes A|B|C work and
> intel_encoder_possible_crtcs() will drop out any crtc that doesn't
> exist.
> 
> v2: Put the special case first to match what most other encoders do
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_lvds.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
> index 13841d7c455b..cf1cd2295b9b 100644
> --- a/drivers/gpu/drm/i915/display/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/display/intel_lvds.c
> @@ -899,12 +899,10 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
>   	intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
>   	intel_encoder->port = PORT_NONE;
>   	intel_encoder->cloneable = 0;
> -	if (HAS_PCH_SPLIT(dev_priv))
> -		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
> -	else if (IS_GEN(dev_priv, 4))
> -		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B);
> -	else
> +	if (INTEL_GEN(dev_priv) < 4)
>   		intel_encoder->crtc_mask = BIT(PIPE_B);
> +	else
> +		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
>   
>   	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
>   	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/6] drm/i915: Simplfy LVDS crtc_mask setup
Date: Thu, 31 Oct 2019 15:34:10 +0200	[thread overview]
Message-ID: <647e333d-64c8-e80f-fe66-f2ee9464179e@gmail.com> (raw)
Message-ID: <20191031133410.dSc1Gky03lQW5rTPNjIGimqKom93-Ajm10qPk_mNHuQ@z> (raw)
In-Reply-To: <20191002162505.30716-2-ville.syrjala@linux.intel.com>

 From this set patches 2,5,6 look all ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 2.10.2019 19.25, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We don't need to special case PCH vs. gen4 when setting up the LVDS
> crtc_mask. Just claim pipes A|B|C work and
> intel_encoder_possible_crtcs() will drop out any crtc that doesn't
> exist.
> 
> v2: Put the special case first to match what most other encoders do
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_lvds.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
> index 13841d7c455b..cf1cd2295b9b 100644
> --- a/drivers/gpu/drm/i915/display/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/display/intel_lvds.c
> @@ -899,12 +899,10 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
>   	intel_encoder->power_domain = POWER_DOMAIN_PORT_OTHER;
>   	intel_encoder->port = PORT_NONE;
>   	intel_encoder->cloneable = 0;
> -	if (HAS_PCH_SPLIT(dev_priv))
> -		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
> -	else if (IS_GEN(dev_priv, 4))
> -		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B);
> -	else
> +	if (INTEL_GEN(dev_priv) < 4)
>   		intel_encoder->crtc_mask = BIT(PIPE_B);
> +	else
> +		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
>   
>   	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
>   	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
> 

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-10-31 13:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 16:25 [PATCH 1/6] drm/i915: Polish possible_clones setup Ville Syrjala
2019-10-02 16:25 ` [PATCH 2/6] drm/i915: Simplfy LVDS crtc_mask setup Ville Syrjala
2019-10-31 13:34   ` Juha-Pekka Heikkila [this message]
2019-10-31 13:34     ` [Intel-gfx] " Juha-Pekka Heikkila
2019-10-02 16:25 ` [PATCH 3/6] drm/i915: s/crtc_mask/pipe_mask/ Ville Syrjala
2019-10-02 18:00   ` Lucas De Marchi
2019-10-03 13:47     ` Ville Syrjälä
2019-10-02 16:25 ` [PATCH 4/6] drm/i915: Allow ICL+ DSI on any pipe Ville Syrjala
2019-10-02 16:35   ` Lucas De Marchi
2019-10-02 16:25 ` [PATCH 5/6] drm/i915: Simplify pipe_mask setup even further Ville Syrjala
2019-10-02 16:25 ` [PATCH 6/6] drm/i915/mst: Document the userspace fail with possible_crtcs Ville Syrjala
2019-10-03 15:28   ` Ville Syrjälä
2019-10-02 22:52 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Polish possible_clones setup Patchwork
2019-10-03  7:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-16 20:29 ` [PATCH 1/6] " Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=647e333d-64c8-e80f-fe66-f2ee9464179e@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox