* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove struct_member macro
2022-12-09 12:14 [Intel-gfx] [PATCH] drm/i915: remove struct_member macro Andrzej Hajda
@ 2022-12-09 13:03 ` Patchwork
2022-12-09 13:18 ` [Intel-gfx] [PATCH] " Jani Nikula
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-12-09 13:03 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 3308 bytes --]
== Series Details ==
Series: drm/i915: remove struct_member macro
URL : https://patchwork.freedesktop.org/series/111802/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12489 -> Patchwork_111802v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/index.html
Participating hosts (25 -> 25)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in Patchwork_111802v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: [PASS][1] -> [FAIL][2] ([fdo#103375])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@hangcheck:
- fi-icl-u2: [PASS][3] -> [INCOMPLETE][4] ([i915#5153])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/fi-icl-u2/igt@i915_selftest@live@hangcheck.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/fi-icl-u2/igt@i915_selftest@live@hangcheck.html
* igt@runner@aborted:
- fi-icl-u2: NOTRUN -> [FAIL][5] ([i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/fi-icl-u2/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][6] ([i915#2867]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@hangcheck:
- {fi-jsl-1}: [INCOMPLETE][8] -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/fi-jsl-1/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
Build changes
-------------
* Linux: CI_DRM_12489 -> Patchwork_111802v1
CI-20190529: 20190529
CI_DRM_12489: 88ce885700bc3fad08382b83f408ac47abad7f3b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7089: f8a4a0b59ab9f0e408cb0817e440f63e7859917e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111802v1: 88ce885700bc3fad08382b83f408ac47abad7f3b @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
382a8a8b8fb7 drm/i915: remove struct_member macro
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/index.html
[-- Attachment #2: Type: text/html, Size: 3977 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: remove struct_member macro
2022-12-09 12:14 [Intel-gfx] [PATCH] drm/i915: remove struct_member macro Andrzej Hajda
2022-12-09 13:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-12-09 13:18 ` Jani Nikula
2022-12-09 13:30 ` Tvrtko Ursulin
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2022-12-09 13:18 UTC (permalink / raw)
To: Andrzej Hajda, intel-gfx; +Cc: Andrzej Hajda, Rodrigo Vivi
On Fri, 09 Dec 2022, Andrzej Hajda <andrzej.hajda@intel.com> wrote:
> Since it is used only to get type of member it can be replaced
> with typeof_member.
Yes, please!
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> drivers/gpu/drm/i915/i915_utils.h | 4 +---
> drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 6c14d13364bf78..b64192d9c7daa7 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -149,8 +149,6 @@ bool i915_error_injected(void);
> #define page_pack_bits(ptr, bits) ptr_pack_bits(ptr, bits, PAGE_SHIFT)
> #define page_unpack_bits(ptr, bits) ptr_unpack_bits(ptr, bits, PAGE_SHIFT)
>
> -#define struct_member(T, member) (((T *)0)->member)
> -
> #define fetch_and_zero(ptr) ({ \
> typeof(*ptr) __T = *(ptr); \
> *(ptr) = (typeof(*ptr))0; \
> @@ -170,7 +168,7 @@ static __always_inline ptrdiff_t ptrdiff(const void *a, const void *b)
> */
> #define container_of_user(ptr, type, member) ({ \
> void __user *__mptr = (void __user *)(ptr); \
> - BUILD_BUG_ON_MSG(!__same_type(*(ptr), struct_member(type, member)) && \
> + BUILD_BUG_ON_MSG(!__same_type(*(ptr), typeof_member(type, member)) && \
> !__same_type(*(ptr), void), \
> "pointer type mismatch in container_of()"); \
> ((type __user *)(__mptr - offsetof(type, member))); })
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
> index 98b8b28baaa15e..e592e8d6499a1f 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> @@ -96,7 +96,7 @@ struct intel_runtime_pm {
> };
>
> #define BITS_PER_WAKEREF \
> - BITS_PER_TYPE(struct_member(struct intel_runtime_pm, wakeref_count))
> + BITS_PER_TYPE(typeof_member(struct intel_runtime_pm, wakeref_count))
> #define INTEL_RPM_WAKELOCK_SHIFT (BITS_PER_WAKEREF / 2)
> #define INTEL_RPM_WAKELOCK_BIAS (1 << INTEL_RPM_WAKELOCK_SHIFT)
> #define INTEL_RPM_RAW_WAKEREF_MASK (INTEL_RPM_WAKELOCK_BIAS - 1)
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: remove struct_member macro
2022-12-09 12:14 [Intel-gfx] [PATCH] drm/i915: remove struct_member macro Andrzej Hajda
2022-12-09 13:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-09 13:18 ` [Intel-gfx] [PATCH] " Jani Nikula
@ 2022-12-09 13:30 ` Tvrtko Ursulin
2022-12-09 21:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2022-12-13 15:35 ` [Intel-gfx] [PATCH] " Andi Shyti
4 siblings, 0 replies; 6+ messages in thread
From: Tvrtko Ursulin @ 2022-12-09 13:30 UTC (permalink / raw)
To: Andrzej Hajda, intel-gfx; +Cc: Rodrigo Vivi
On 09/12/2022 12:14, Andrzej Hajda wrote:
> Since it is used only to get type of member it can be replaced
> with typeof_member.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> drivers/gpu/drm/i915/i915_utils.h | 4 +---
> drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 6c14d13364bf78..b64192d9c7daa7 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -149,8 +149,6 @@ bool i915_error_injected(void);
> #define page_pack_bits(ptr, bits) ptr_pack_bits(ptr, bits, PAGE_SHIFT)
> #define page_unpack_bits(ptr, bits) ptr_unpack_bits(ptr, bits, PAGE_SHIFT)
>
> -#define struct_member(T, member) (((T *)0)->member)
> -
> #define fetch_and_zero(ptr) ({ \
> typeof(*ptr) __T = *(ptr); \
> *(ptr) = (typeof(*ptr))0; \
> @@ -170,7 +168,7 @@ static __always_inline ptrdiff_t ptrdiff(const void *a, const void *b)
> */
> #define container_of_user(ptr, type, member) ({ \
> void __user *__mptr = (void __user *)(ptr); \
> - BUILD_BUG_ON_MSG(!__same_type(*(ptr), struct_member(type, member)) && \
> + BUILD_BUG_ON_MSG(!__same_type(*(ptr), typeof_member(type, member)) && \
#define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
#define typeof_member(T, m) typeof(((T*)0)->m)
So expands to:
__builtin_types_compatible_p(typeof(*(ptr)), typeof(typeof(((type*)0)->m)));
I guess that's okay since infinite number of typeofs is still a typeof.
Regards,
Tvrtko
> !__same_type(*(ptr), void), \
> "pointer type mismatch in container_of()"); \
> ((type __user *)(__mptr - offsetof(type, member))); })
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
> index 98b8b28baaa15e..e592e8d6499a1f 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> @@ -96,7 +96,7 @@ struct intel_runtime_pm {
> };
>
> #define BITS_PER_WAKEREF \
> - BITS_PER_TYPE(struct_member(struct intel_runtime_pm, wakeref_count))
> + BITS_PER_TYPE(typeof_member(struct intel_runtime_pm, wakeref_count))
> #define INTEL_RPM_WAKELOCK_SHIFT (BITS_PER_WAKEREF / 2)
> #define INTEL_RPM_WAKELOCK_BIAS (1 << INTEL_RPM_WAKELOCK_SHIFT)
> #define INTEL_RPM_RAW_WAKEREF_MASK (INTEL_RPM_WAKELOCK_BIAS - 1)
^ permalink raw reply [flat|nested] 6+ messages in thread* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: remove struct_member macro
2022-12-09 12:14 [Intel-gfx] [PATCH] drm/i915: remove struct_member macro Andrzej Hajda
` (2 preceding siblings ...)
2022-12-09 13:30 ` Tvrtko Ursulin
@ 2022-12-09 21:02 ` Patchwork
2022-12-13 15:35 ` [Intel-gfx] [PATCH] " Andi Shyti
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-12-09 21:02 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 22699 bytes --]
== Series Details ==
Series: drm/i915: remove struct_member macro
URL : https://patchwork.freedesktop.org/series/111802/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12489_full -> Patchwork_111802v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_111802v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_111802v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 9)
------------------------------
Missing (4): shard-rkl shard-tglu-9 shard-tglu-10 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_111802v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@short-flip-after-cursor@atomic-transitions:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl4/igt@kms_cursor_legacy@short-flip-after-cursor@atomic-transitions.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl2/igt@kms_cursor_legacy@short-flip-after-cursor@atomic-transitions.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_softpin@evict-prime@all}:
- shard-skl: NOTRUN -> [FAIL][3] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl4/igt@gem_softpin@evict-prime@all.html
Known issues
------------
Here are the changes found in Patchwork_111802v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@all-busy-idle-check-all:
- shard-skl: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#5608]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@drm_fdinfo@all-busy-idle-check-all.html
* igt@gem_ctx_persistence@hang:
- shard-skl: NOTRUN -> [SKIP][5] ([fdo#109271]) +433 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@gem_ctx_persistence@hang.html
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb2/igt@gem_exec_balancer@parallel-keep-in-fence.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb3/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- shard-skl: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +5 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@gem_lmem_swapping@random-engines.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-skl: NOTRUN -> [FAIL][11] ([i915#7036])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][12] ([i915#3989] / [i915#454])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_selftest@mock@vma:
- shard-skl: NOTRUN -> [TIMEOUT][13] ([i915#6950])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@i915_selftest@mock@vma.html
* igt@i915_suspend@basic-s3-without-i915:
- shard-iclb: [PASS][14] -> [INCOMPLETE][15] ([i915#7443])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb8/igt@i915_suspend@basic-s3-without-i915.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb3/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#3886]) +15 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271] / [fdo#111827]) +16 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html
* igt@kms_color@ctm-red-to-blue@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-snb5/igt@kms_color@ctm-red-to-blue@pipe-b-vga-1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1:
- shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#2411] / [i915#2867])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-tglb3/igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-tglb2/igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1.html
* igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1:
- shard-skl: NOTRUN -> [INCOMPLETE][21] ([i915#6951])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl4/igt@kms_cursor_crc@cursor-suspend@pipe-c-edp-1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][24] ([i915#6375])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#2672]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#2587] / [i915#2672]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#3555]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-32bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2672] / [i915#3555]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_plane_alpha_blend@constant-alpha-min@pipe-c-edp-1:
- shard-skl: NOTRUN -> [FAIL][29] ([i915#4573]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@kms_plane_alpha_blend@constant-alpha-min@pipe-c-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][30] -> [SKIP][31] ([i915#5235]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#658]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109642] / [fdo#111068] / [i915#658]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb3/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][34] ([i915#5939]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1.html
* igt@kms_psr@dpms:
- shard-skl: [PASS][35] -> [DMESG-WARN][36] ([i915#1982])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl7/igt@kms_psr@dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@kms_psr@dpms.html
* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-tglb: [PASS][37] -> [SKIP][38] ([i915#5519])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-tglb5/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-tglb2/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
- shard-iclb: [PASS][39] -> [SKIP][40] ([i915#5519])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb2/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb7/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2437])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@polling:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#1542])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl1/igt@perf@polling.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@perf@polling.html
* igt@sysfs_clients@split-25:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2994]) +6 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl6/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][45] ([i915#658]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb1/igt@feature_discovery@psr2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][47] ([i915#4525]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb7/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][49] ([i915#2842]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-tglb5/igt@gem_exec_fair@basic-flow@rcs0.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][51] ([i915#2842]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][53] ([i915#2190]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-tglb7/igt@gem_huc_copy@huc-copy.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-tglb5/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][55] ([i915#3989] / [i915#454]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb7/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][57] ([i915#4281]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb5/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][59] ([i915#79]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][61] ([i915#2122]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][63] ([i915#3555]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html
* igt@kms_psr@psr2_sprite_plane_onoff:
- shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb1/igt@kms_psr@psr2_sprite_plane_onoff.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_psr@psr2_sprite_plane_onoff.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][67] ([i915#5519]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-tglb3/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html
* igt@perf@blocking:
- shard-skl: [FAIL][69] ([i915#1542]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl4/igt@perf@blocking.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl7/igt@perf@blocking.html
#### Warnings ####
* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1:
- shard-skl: [DMESG-FAIL][71] ([IGT#6]) -> [FAIL][72] ([i915#4573])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-skl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-skl1/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-iclb: [SKIP][73] ([i915#658]) -> [SKIP][74] ([i915#2920]) +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb1/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-iclb: [SKIP][75] ([i915#2920]) -> [SKIP][76] ([i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb2/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb7/igt@kms_psr2_sf@cursor-plane-move-continuous-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: [SKIP][77] ([i915#2920]) -> [SKIP][78] ([fdo#111068] / [i915#658]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][79] ([fdo#111068] / [i915#658]) -> [SKIP][80] ([i915#2920])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][81], [FAIL][82], [FAIL][83]) ([fdo#109271] / [i915#3002] / [i915#4312]) -> ([FAIL][84], [FAIL][85], [FAIL][86], [FAIL][87]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-apl7/igt@runner@aborted.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-apl8/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12489/shard-apl7/igt@runner@aborted.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl3/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl8/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl1/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/shard-apl8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6950]: https://gitlab.freedesktop.org/drm/intel/issues/6950
[i915#6951]: https://gitlab.freedesktop.org/drm/intel/issues/6951
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12489 -> Patchwork_111802v1
CI-20190529: 20190529
CI_DRM_12489: 88ce885700bc3fad08382b83f408ac47abad7f3b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7089: f8a4a0b59ab9f0e408cb0817e440f63e7859917e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111802v1: 88ce885700bc3fad08382b83f408ac47abad7f3b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111802v1/index.html
[-- Attachment #2: Type: text/html, Size: 27598 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: remove struct_member macro
2022-12-09 12:14 [Intel-gfx] [PATCH] drm/i915: remove struct_member macro Andrzej Hajda
` (3 preceding siblings ...)
2022-12-09 21:02 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
@ 2022-12-13 15:35 ` Andi Shyti
4 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2022-12-13 15:35 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, Rodrigo Vivi
Hi Andrzej,
On Fri, Dec 09, 2022 at 01:14:59PM +0100, Andrzej Hajda wrote:
> Since it is used only to get type of member it can be replaced
> with typeof_member.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
pushed in drm-intel-gt-next.
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/i915_utils.h | 4 +---
> drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index 6c14d13364bf78..b64192d9c7daa7 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -149,8 +149,6 @@ bool i915_error_injected(void);
> #define page_pack_bits(ptr, bits) ptr_pack_bits(ptr, bits, PAGE_SHIFT)
> #define page_unpack_bits(ptr, bits) ptr_unpack_bits(ptr, bits, PAGE_SHIFT)
>
> -#define struct_member(T, member) (((T *)0)->member)
> -
> #define fetch_and_zero(ptr) ({ \
> typeof(*ptr) __T = *(ptr); \
> *(ptr) = (typeof(*ptr))0; \
> @@ -170,7 +168,7 @@ static __always_inline ptrdiff_t ptrdiff(const void *a, const void *b)
> */
> #define container_of_user(ptr, type, member) ({ \
> void __user *__mptr = (void __user *)(ptr); \
> - BUILD_BUG_ON_MSG(!__same_type(*(ptr), struct_member(type, member)) && \
> + BUILD_BUG_ON_MSG(!__same_type(*(ptr), typeof_member(type, member)) && \
> !__same_type(*(ptr), void), \
> "pointer type mismatch in container_of()"); \
> ((type __user *)(__mptr - offsetof(type, member))); })
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.h b/drivers/gpu/drm/i915/intel_runtime_pm.h
> index 98b8b28baaa15e..e592e8d6499a1f 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.h
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.h
> @@ -96,7 +96,7 @@ struct intel_runtime_pm {
> };
>
> #define BITS_PER_WAKEREF \
> - BITS_PER_TYPE(struct_member(struct intel_runtime_pm, wakeref_count))
> + BITS_PER_TYPE(typeof_member(struct intel_runtime_pm, wakeref_count))
> #define INTEL_RPM_WAKELOCK_SHIFT (BITS_PER_WAKEREF / 2)
> #define INTEL_RPM_WAKELOCK_BIAS (1 << INTEL_RPM_WAKELOCK_SHIFT)
> #define INTEL_RPM_RAW_WAKEREF_MASK (INTEL_RPM_WAKELOCK_BIAS - 1)
> --
> 2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread