Re: [PATCH 0/9] drm/i915/casf: Integrate the sharpness filter properly into the scaler code

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Ville,

On 27-03-2026 04:01 am, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The sharpness filter isn't anything special. It's just another
> mode of the pipe scaler, so treat is as such.
>
> This gets rid of tons of special casing all over the place,
> and will allow me to finally land the pending pipe prefill
> series: https://patchwork.freedesktop.org/series/156137/
>
> Note that this will fail some kms_sharpness_filter tests,
> because those tests are basically incorrect. But I couldn't
> decide yet how much of that entire test should be nuked. It
> seems to be doing a *lot* of things, most of which have
> nothing to do with the sharpness filter...

With your series I could see only 1 negative test failing - 
invalid-filter-with-scaling-mode-center

https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163952v1/shards-all.html?testfilter=sharpness

Is it sharpness and scaling-mode-center can work together? Since 
scaler-mode-center doesn't require

scaler.

You rightly said, all tests are not related to sharpness but covering 
valid scenarios for scaler + sharpness.

Apart from invalid-filter-with-scaling-mode-center, which other tests do 
you think are incorrect? We tried covering all valid scenarios as per HAS.

>
> Cc: Nemesa Garg <nemesa.garg@intel.com>
>
> Ville Syrjälä (9):
>    drm/i915/casf: s/casf_enable/enable/
>    drm/i915/casf: Make a proper hw state copy of the sharpness_strength
>    drm/i915/casf: Move the casf state to better place
>    drm/i915/casf: Extract scaler_has_casf()
>    drm/i915/casf: Handle CASF in skl_scaler_get_filter_select()
>    drm/i915/casf: Constify crtc_state
>    drn/i915/casf: Remove redundant argument from
>      intel_casf_filter_lut_load()
>    drm/i915/pfit: Call intel_pfit_compute_config() unconditionally on
>      (e)DP/HDMI
>    drm/i915/casf: Integrate the sharpness filter properly into the scaler
>      code
>
>   drivers/gpu/drm/i915/display/intel_casf.c     | 102 +++++-----------
>   drivers/gpu/drm/i915/display/intel_casf.h     |   6 +-
>   .../drm/i915/display/intel_crtc_state_dump.c  |  11 +-
>   drivers/gpu/drm/i915/display/intel_display.c  |  46 ++------
>   .../drm/i915/display/intel_display_debugfs.c  |   5 +-
>   .../drm/i915/display/intel_display_types.h    |   5 +-
>   drivers/gpu/drm/i915/display/intel_dp.c       |   9 +-
>   drivers/gpu/drm/i915/display/intel_hdmi.c     |   8 +-
>   .../drm/i915/display/intel_modeset_setup.c    |   1 +
>   drivers/gpu/drm/i915/display/intel_pfit.c     |  13 ++-
>   drivers/gpu/drm/i915/display/skl_scaler.c     | 110 +++++++-----------
>   drivers/gpu/drm/i915/display/skl_scaler.h     |   2 -
>   12 files changed, 112 insertions(+), 206 deletions(-)
>