From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add error-capture init warnings when needed
Date: Wed, 19 Oct 2022 05:28:42 +0000 [thread overview]
Message-ID: <6a27f8f979de35861d295dc0bb68ea0b8e1b454a.camel@intel.com> (raw)
In-Reply-To: <bdedca3f-88e3-2da9-cb0e-0a0754621313@linux.intel.com>
> > > Also commit message you can aim to wrap at 75 chars as per submitting-patches.rst.
> > >
> > > > + return -ENODATA;
> > >
> > > Is this a new exit condition or the thing would exit on the !num_regs check below anyway? Just wondering if the series is only about logging changes or there is more to it.
> > Its no different from previous behavior - and yes its about logging the missing reg lists for hw that needs it as we are
> > missing this for DG2 we we didn't notice (we did a previous revert to remove these warnings but that time the warnings
> > was too verbose - even complaining for the intentional empty lists and for VF cases that isnt supported).
>
> Okay think I get it, thanks. If the "positive match" logging of empty
> list is more future proof than "negative - don't log these" you will
> know better.
NOTE: John and I had an offline conversation and we are aware that there will still be a case where
we can miss new-platform updates for guc-error-capture without being alerted by a warning:
Let's take the example of the empty blitter's engine-class-register-list. We dont have such a thing on
today's hardware.. we only have blitter's engine-register-list ... i.e. HEAD, TAIL etc. But if a future
platform were to introduce a blitter engine-class-register-list, we wont get a warning since the empty
list is there to prevent unnecessary warning for today's hardware. But we know this is better than
having to explain unnecessary warnings (which was the reason why a more verbose version of this code
was removed in the past).
I believe we are good with this solution here for now.
next prev parent reply other threads:[~2022-10-19 5:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 3:59 [Intel-gfx] [PATCH 0/2] drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Alan Previn
2022-10-15 3:59 ` [Intel-gfx] [PATCH 1/2] drm/i915/guc: Add error-capture init warnings when needed Alan Previn
2022-10-17 8:42 ` Tvrtko Ursulin
2022-10-17 17:46 ` Teres Alexis, Alan Previn
2022-10-18 8:00 ` Tvrtko Ursulin
2022-10-19 5:14 ` Teres Alexis, Alan Previn
2022-10-19 5:28 ` Teres Alexis, Alan Previn [this message]
2022-10-17 19:33 ` John Harrison
2022-10-17 23:36 ` Teres Alexis, Alan Previn
2022-10-18 0:15 ` John Harrison
2022-10-15 3:59 ` [Intel-gfx] [PATCH 2/2] drm/i915/guc: Add compute reglist for GuC error capture Alan Previn
2022-10-17 8:43 ` Tvrtko Ursulin
2022-10-17 17:32 ` Teres Alexis, Alan Previn
2022-10-18 8:04 ` Tvrtko Ursulin
2022-10-15 4:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types Patchwork
2022-10-15 6:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a27f8f979de35861d295dc0bb68ea0b8e1b454a.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox