Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v3 0/2] drm/i915: Fix timeout handling when retiring requests
@ 2022-11-21 14:56 Janusz Krzysztofik
  2022-11-21 14:56 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time Janusz Krzysztofik
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Janusz Krzysztofik @ 2022-11-21 14:56 UTC (permalink / raw)
  To: Tvrtko Ursulin, Joonas Lahtinen
  Cc: Daniel Vetter, intel-gfx, Chris Wilson, dri-devel, Andrzej Hajda,
	Nirmoy Das

Fixes for issues discovered via code review while working on
https://gitlab.freedesktop.org/drm/intel/issues/7349.

v3:
PATCH 1: don't fail on any error passed back via remaining_timeout,
PATCH 2: use conditional expression, more compact but also better
	 reflecting intention standing behind the change.

v2:
PATCH 1: fix the issue on the caller side, not the provider,
	 reword commit message and description.
PATCH 2: move the added lines down so flush_submission() is not affected,
	 reword commit message and description.
PATCH 3: drop -- controversial, not needed.

Janusz Krzysztofik (2):
  drm/i915: Fix negative value passed as remaining time
  drm/i915: Never return 0 if not all requests retired

 drivers/gpu/drm/i915/gt/intel_gt.c          | 9 +++++++--
 drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-11-24 12:27 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-21 14:56 [Intel-gfx] [PATCH v3 0/2] drm/i915: Fix timeout handling when retiring requests Janusz Krzysztofik
2022-11-21 14:56 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Fix negative value passed as remaining time Janusz Krzysztofik
2022-11-21 17:40   ` Andrzej Hajda
2022-11-21 23:19     ` Janusz Krzysztofik
2022-11-22 10:41       ` Tvrtko Ursulin
2022-11-23 11:29         ` Janusz Krzysztofik
2022-11-21 14:56 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Never return 0 if not all requests retired Janusz Krzysztofik
2022-11-22 10:50   ` Tvrtko Ursulin
2022-11-23  9:28     ` Janusz Krzysztofik
2022-11-23 12:57       ` Tvrtko Ursulin
2022-11-23 16:21         ` Janusz Krzysztofik
2022-11-24 12:27           ` Tvrtko Ursulin
2022-11-23 15:42   ` Andrzej Hajda
2022-11-21 15:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix timeout handling when retiring requests (rev3) Patchwork
2022-11-21 15:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-11-21 18:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox