From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel: fix fullscreen damage posting on pageflip
Date: Thu, 11 Oct 2012 08:53:14 +0100 [thread overview]
Message-ID: <6c3329$6n0p70@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1349929829-25856-1-git-send-email-airlied@gmail.com>
On Thu, 11 Oct 2012 14:30:29 +1000, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> While playing with MPX and sw cursor I noticed page flips won't
> end up misrendering some bits, so the sw cursor was replacing the
> bits on the wrong pixmap.
>
> Fix the damage handling to be correct and append damage before swapping
> the pointers and process damage after.
>
> This fixes misrendering with MPX cursors under a fullscreen compositor,
> that pageflips.
Wow, what magic is this? The created region is the same and
front->drawable left unmodified by the exchange. The exchange only
manipulates the devPrivates and has not other side effects. The only
uncertain quantity there is the intel_glamor_exchange_buffers()...
So the change is that we append the same damage to the same drawable
earlier, yet still process that damage at the same time, with no
apparent side-effects between the two operations. I'm just not
understanding why this has any effect.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-11 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 4:30 [PATCH] intel: fix fullscreen damage posting on pageflip Dave Airlie
2012-10-11 7:53 ` Chris Wilson [this message]
2012-10-11 8:12 ` Dave Airlie
2012-10-11 8:26 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$6n0p70@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox