From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org, daniel@ffwll.ch
Cc: jani.nikula@intel.com
Subject: Re: [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring
Date: Fri, 19 Oct 2012 18:58:56 +0100 [thread overview]
Message-ID: <6c3329$6r5408@orsmga002.jf.intel.com> (raw)
In-Reply-To: <cover.1350644022.git.jani.nikula@intel.com>
On Fri, 19 Oct 2012 14:51:42 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> Hi all, this is some LVDS/eDP panel refactoring and cleanup based on
> Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid
> notifier based on Jesse's comments [2]; more of Jesse's old review is at
> [3].
>
> The main high level difference to Chris' patches is that intel_panel and
> the cached EDID are placed in intel_connector rather than anywhere
> else. This is because Daniel hinted that we might want to do some more
> generic EDID caching (indeed, why keep reading the EDID if the display
> has not been unplugged?). With the EDID and intel_panel in
> intel_connector, we can add functions to query EDID and modes with
> transparent caching and fallback to fixed mode when EDID is not
> available.
Patches look really good, I haven't checked yet to see if there is
anything missing, but I already like the improvement to the code....
So for the series,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-19 17:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 11:51 [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring Jani Nikula
2012-10-19 11:51 ` [PATCH 01/10] drm/i915/lvds: Rename intel_lvds to intel_lvds_encoder Jani Nikula
2012-10-19 16:46 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 02/10] drm/i915/lvds: Introduce intel_lvds_connector Jani Nikula
2012-10-19 16:47 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 03/10] drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to the connector Jani Nikula
2012-10-19 16:48 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 04/10] drm/i915: Backlight setup requires connector so pass it as parameter Jani Nikula
2012-10-19 16:54 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 05/10] drm/i915/lvds: Move some connector specific info across from the encoder Jani Nikula
2012-10-19 16:55 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 06/10] drm/i915/dp: Initialize eDP fixed mode in intel_dp_init Jani Nikula
2012-10-19 17:00 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 07/10] drm/i915: Create generic intel_panel for LVDS and eDP Jani Nikula
2012-10-19 17:04 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 08/10] drm/i915: Move the fixed mode to intel_panel Jani Nikula
2012-10-19 17:09 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 09/10] drm/i915: Do not free the passed EDID in intel_connector_update_modes() Jani Nikula
2012-10-19 17:10 ` Jesse Barnes
2012-10-19 11:51 ` [PATCH 10/10] drm/i915: Move cached EDID to intel_connector Jani Nikula
2012-10-19 17:13 ` Jesse Barnes
2012-10-19 17:58 ` Chris Wilson [this message]
2012-10-22 17:37 ` [PATCH 00/10] drm/i915: LVDS/eDP panel, EDID and fixed mode refactoring Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$6r5408@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox