* [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret
@ 2022-10-07 19:47 Colin Ian King
2022-10-07 20:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin Ian King @ 2022-10-07 19:47 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
The variable ret is being assigned with a value that is never read
both before and after a while-loop. The variable is being re-assigned
inside the while-loop and afterwards on the call to the function
i915_gem_object_lock_interruptible. Remove the redundants assignments.
Cleans up clang scan-build warnings:
warning: Although the value stored to 'ret' is used in the
enclosing expression, the value is never actually read
from 'ret' [deadcode.DeadStores]
warning: Value stored to 'ret' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index d4398948f016..b7e24476a0fd 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj)
if (!i915_gem_object_is_readonly(obj))
gup_flags |= FOLL_WRITE;
- pinned = ret = 0;
+ pinned = 0;
while (pinned < num_pages) {
ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE,
num_pages - pinned, gup_flags,
@@ -302,7 +302,6 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj)
pinned += ret;
}
- ret = 0;
ret = i915_gem_object_lock_interruptible(obj, NULL);
if (ret)
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: remove redundant assignments to variable ret 2022-10-07 19:47 [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret Colin Ian King @ 2022-10-07 20:53 ` Patchwork 2022-10-08 1:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-10-10 8:07 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2022-10-07 20:53 UTC (permalink / raw) To: Colin Ian King; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5545 bytes --] == Series Details == Series: drm/i915/gem: remove redundant assignments to variable ret URL : https://patchwork.freedesktop.org/series/109490/ State : success == Summary == CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109490v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/index.html Participating hosts (44 -> 41) ------------------------------ Additional (1): bat-atsm-1 Missing (4): fi-ctg-p8600 fi-bxt-dsi fi-tgl-dsi fi-hsw-4200u Known issues ------------ Here are the changes found in Patchwork_109490v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_chamelium@common-hpd-after-suspend: - fi-hsw-g3258: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#111827]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html - fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - {bat-adlm-1}: [DMESG-WARN][3] ([i915#2867]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html * igt@gem_exec_suspend@basic-s3@lmem0: - {bat-dg2-11}: [DMESG-WARN][5] ([i915#6816]) -> [PASS][6] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html * igt@i915_selftest@live@gt_pm: - {bat-rpls-2}: [DMESG-FAIL][7] ([i915#4258]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-rpls-2/igt@i915_selftest@live@gt_pm.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@gt_timelines: - fi-hsw-g3258: [INCOMPLETE][9] -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-hsw-g3258/igt@i915_selftest@live@gt_timelines.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/fi-hsw-g3258/igt@i915_selftest@live@gt_timelines.html * igt@i915_selftest@live@guc: - {bat-rpls-2}: [DMESG-WARN][11] ([i915#6471]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-rpls-2/igt@i915_selftest@live@guc.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/bat-rpls-2/igt@i915_selftest@live@guc.html * igt@i915_selftest@live@hangcheck: - {fi-ehl-2}: [INCOMPLETE][13] ([i915#5153]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-ehl-2/igt@i915_selftest@live@hangcheck.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/fi-ehl-2/igt@i915_selftest@live@hangcheck.html * igt@i915_suspend@basic-s3-without-i915: - fi-bdw-5557u: [INCOMPLETE][15] ([i915#146] / [i915#6712]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 [i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471 [i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712 [i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816 [i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818 [i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030 Build changes ------------- * Linux: CI_DRM_12226 -> Patchwork_109490v1 CI-20190529: 20190529 CI_DRM_12226: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_109490v1: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits e3fc6b5b7329 drm/i915/gem: remove redundant assignments to variable ret == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/index.html [-- Attachment #2: Type: text/html, Size: 5964 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: remove redundant assignments to variable ret 2022-10-07 19:47 [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret Colin Ian King 2022-10-07 20:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2022-10-08 1:57 ` Patchwork 2022-10-10 8:07 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2022-10-08 1:57 UTC (permalink / raw) To: Colin Ian King; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 28674 bytes --] == Series Details == Series: drm/i915/gem: remove redundant assignments to variable ret URL : https://patchwork.freedesktop.org/series/109490/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109490v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_109490v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_109490v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (9 -> 12) ------------------------------ Additional (3): shard-rkl shard-dg1 shard-tglu Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_109490v1_full: ### IGT changes ### #### Possible regressions #### * igt@kms_psr@suspend: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-tglb5/igt@kms_psr@suspend.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-tglb8/igt@kms_psr@suspend.html * igt@kms_sequence@queue-idle@edp-1-pipe-c: - shard-skl: [PASS][3] -> [FAIL][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl9/igt@kms_sequence@queue-idle@edp-1-pipe-c.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl4/igt@kms_sequence@queue-idle@edp-1-pipe-c.html #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_suspend@sysfs-reader: - {shard-rkl}: NOTRUN -> [INCOMPLETE][5] [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-rkl-3/igt@i915_suspend@sysfs-reader.html Known issues ------------ Here are the changes found in Patchwork_109490v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_persistence@engines-mixed: - shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-snb6/igt@gem_ctx_persistence@engines-mixed.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html * igt@i915_suspend@sysfs-reader: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl2/igt@i915_suspend@sysfs-reader.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-apl2/igt@i915_suspend@sysfs-reader.html * igt@kms_chamelium@dp-crc-multiple: - shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-snb6/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@vga-edid-read: - shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@kms_chamelium@vga-edid-read.html * igt@kms_color@ctm-0-75@pipe-b-vga-1: - shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +17 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-snb6/igt@kms_color@ctm-0-75@pipe-b-vga-1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [PASS][14] -> [FAIL][15] ([i915#79]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1: - shard-glk: [PASS][16] -> [FAIL][17] ([i915#79]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1: - shard-glk: [PASS][18] -> [FAIL][19] ([i915#2122]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk2/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-glk5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-hdmi-a1.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][20] ([i915#2587] / [i915#2672]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][21] ([i915#3555]) +3 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][22] ([i915#2672]) +4 similar issues [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][23] ([i915#2672] / [i915#3555]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render: - shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271]) +9 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render.html * igt@kms_psr@psr2_primary_mmap_gtt: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb8/igt@kms_psr@psr2_primary_mmap_gtt.html * igt@sysfs_clients@split-50: - shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2994]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@sysfs_clients@split-50.html #### Possible fixes #### * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [SKIP][28] ([i915#4525]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb8/igt@gem_exec_balancer@parallel-bb-first.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb1/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_fair@basic-none@vecs0: - shard-glk: [FAIL][30] ([i915#2842]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk9/igt@gem_exec_fair@basic-none@vecs0.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-glk7/igt@gem_exec_fair@basic-none@vecs0.html * igt@gem_exec_schedule@pi-ringfull@rcs0: - shard-skl: [FAIL][32] -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl9/igt@gem_exec_schedule@pi-ringfull@rcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl4/igt@gem_exec_schedule@pi-ringfull@rcs0.html * igt@i915_selftest@live@hangcheck: - shard-snb: [INCOMPLETE][34] ([i915#6992]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-snb6/igt@i915_selftest@live@hangcheck.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-snb6/igt@i915_selftest@live@hangcheck.html * igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1: - shard-skl: [FAIL][36] ([i915#2521]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][38] ([i915#2346]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor@legacy: - shard-skl: [FAIL][40] ([i915#2346]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor@legacy.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor@legacy.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2: - shard-glk: [FAIL][42] ([i915#79]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html * igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1: - shard-skl: [FAIL][44] ([i915#2122]) -> [PASS][45] +2 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl9/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [SKIP][46] ([i915#5235]) -> [PASS][47] +2 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb7/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_psr@psr2_suspend: - shard-iclb: [SKIP][48] ([fdo#109441]) -> [PASS][49] +2 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb6/igt@kms_psr@psr2_suspend.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb2/igt@kms_psr@psr2_suspend.html * igt@perf@polling-parameterized: - shard-skl: [FAIL][50] ([i915#5639]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl10/igt@perf@polling-parameterized.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl1/igt@perf@polling-parameterized.html * igt@vgem_basic@dmabuf-fence: - shard-skl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@vgem_basic@dmabuf-fence.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@vgem_basic@dmabuf-fence.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [SKIP][54] ([i915#4525]) -> [FAIL][55] ([i915#6117]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb7/igt@gem_exec_balancer@parallel-ordering.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu: - shard-skl: [SKIP][56] ([fdo#109271]) -> [SKIP][57] ([fdo#109271] / [i915#1888]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-skl7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu.html * igt@kms_psr2_sf@cursor-plane-update-sf: - shard-iclb: [SKIP][58] ([i915#2920]) -> [SKIP][59] ([fdo#111068] / [i915#658]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb6/igt@kms_psr2_sf@cursor-plane-update-sf.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb: - shard-iclb: [SKIP][60] ([i915#2920]) -> [SKIP][61] ([i915#658]) [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html * igt@kms_psr2_su@page_flip-p010: - shard-iclb: [SKIP][62] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][63] ([i915#5939]) [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb7/igt@kms_psr2_su@page_flip-p010.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html * igt@runner@aborted: - shard-apl: ([FAIL][64], [FAIL][65]) ([i915#3002] / [i915#4312]) -> ([FAIL][66], [FAIL][67], [FAIL][68], [FAIL][69]) ([i915#180] / [i915#3002] / [i915#4312]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl6/igt@runner@aborted.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl2/igt@runner@aborted.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-apl2/igt@runner@aborted.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-apl3/igt@runner@aborted.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-apl8/igt@runner@aborted.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/shard-apl3/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254 [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155 [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410 [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435 [i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743 [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825 [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854 [i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874 [i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883 [i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884 [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958 [i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6458]: https://gitlab.freedesktop.org/drm/intel/issues/6458 [i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463 [i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6987]: https://gitlab.freedesktop.org/drm/intel/issues/6987 [i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_12226 -> Patchwork_109490v1 CI-20190529: 20190529 CI_DRM_12226: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_109490v1: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109490v1/index.html [-- Attachment #2: Type: text/html, Size: 21264 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret 2022-10-07 19:47 [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret Colin Ian King 2022-10-07 20:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-10-08 1:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2022-10-10 8:07 ` Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Tvrtko Ursulin @ 2022-10-10 8:07 UTC (permalink / raw) To: Colin Ian King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel Cc: kernel-janitors, linux-kernel On 07/10/2022 20:47, Colin Ian King wrote: > The variable ret is being assigned with a value that is never read > both before and after a while-loop. The variable is being re-assigned > inside the while-loop and afterwards on the call to the function > i915_gem_object_lock_interruptible. Remove the redundants assignments. > > Cleans up clang scan-build warnings: > > warning: Although the value stored to 'ret' is used in the > enclosing expression, the value is never actually read > from 'ret' [deadcode.DeadStores] > > warning: Value stored to 'ret' is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c > index d4398948f016..b7e24476a0fd 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c > @@ -292,7 +292,7 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) > if (!i915_gem_object_is_readonly(obj)) > gup_flags |= FOLL_WRITE; > > - pinned = ret = 0; > + pinned = 0; > while (pinned < num_pages) { > ret = pin_user_pages_fast(obj->userptr.ptr + pinned * PAGE_SIZE, > num_pages - pinned, gup_flags, > @@ -302,7 +302,6 @@ int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) > > pinned += ret; > } > - ret = 0; > > ret = i915_gem_object_lock_interruptible(obj, NULL); > if (ret) Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the cleanup, will merge. Regards, Tvrtko ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-10 8:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-10-07 19:47 [Intel-gfx] [PATCH] drm/i915/gem: remove redundant assignments to variable ret Colin Ian King 2022-10-07 20:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-10-08 1:57 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-10-10 8:07 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox