Re: [PATCH] drm/i915/dsb: Remove PIN_MAPPABLE from the DSB object VMA

[Animesh Manna <animesh.manna@intel.com>]

On 10/25/2019 8:52 PM, Animesh Manna wrote:
>
> On 10/17/2019 9:28 PM, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> It sounds like the hardware only needs the DSB object to be in global 
>> GTT
>> and not in the mappable region.
>
> Currently tested and working without any regression, waiting for 
> confirmation from h/w team, will update soon.

Got confirmation from h/w team, changes are ok to me.
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Thanks Chris, Tvrtko for the learning.

Regards,
Animesh

>
> Regards,
> Animesh
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Animesh Manna <animesh.manna@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c 
>> b/drivers/gpu/drm/i915/display/intel_dsb.c
>> index bb5a0e91b370..d8ad5fe1efef 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>> @@ -119,7 +119,7 @@ intel_dsb_get(struct intel_crtc *crtc)
>>           goto err;
>>       }
>>   -    vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, PIN_MAPPABLE);
>> +    vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
>>       if (IS_ERR(vma)) {
>>           DRM_ERROR("Vma creation failed\n");
>>           i915_gem_object_put(obj);
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx