From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com
Subject: Re: [PATCH v3 02/20] drm/panel replay: Add edp1.5 Panel Replay bits and register
Date: Tue, 28 May 2024 15:02:37 +0200 [thread overview]
Message-ID: <76e133e5-2399-4db4-a290-70bc77ca065b@linux.intel.com> (raw)
In-Reply-To: <20240527072220.3294769-3-jouni.hogander@intel.com>
Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Den 2024-05-27 kl. 09:22, skrev Jouni Högander:
> Add PANEL_REPLAY_CONFIGURATION_2 register and some missing Panel Replay
> bits.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
> include/drm/display/drm_dp.h | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 906949ca3cee..79bde372b152 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -544,9 +544,10 @@
> /* DFP Capability Extension */
> #define DP_DFP_CAPABILITY_EXTENSION_SUPPORT 0x0a3 /* 2.0 */
>
> -#define DP_PANEL_REPLAY_CAP 0x0b0 /* DP 2.0 */
> -# define DP_PANEL_REPLAY_SUPPORT (1 << 0)
> -# define DP_PANEL_REPLAY_SU_SUPPORT (1 << 1)
> +#define DP_PANEL_REPLAY_CAP 0x0b0 /* DP 2.0 */
> +# define DP_PANEL_REPLAY_SUPPORT (1 << 0)
> +# define DP_PANEL_REPLAY_SU_SUPPORT (1 << 1)
> +# define DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT (1 << 2) /* eDP 1.5 */
>
> #define DP_PANEL_PANEL_REPLAY_CAPABILITY 0xb1
> # define DP_PANEL_PANEL_REPLAY_SU_GRANULARITY_REQUIRED (1 << 5)
> @@ -734,11 +735,20 @@
>
> #define PANEL_REPLAY_CONFIG 0x1b0 /* DP 2.0 */
> # define DP_PANEL_REPLAY_ENABLE (1 << 0)
> +# define DP_PANEL_REPLAY_VSC_SDP_CRC_EN (1 << 1) /* eDP 1.5 */
> # define DP_PANEL_REPLAY_UNRECOVERABLE_ERROR_EN (1 << 3)
> # define DP_PANEL_REPLAY_RFB_STORAGE_ERROR_EN (1 << 4)
> # define DP_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR_EN (1 << 5)
> # define DP_PANEL_REPLAY_SU_ENABLE (1 << 6)
>
> +#define PANEL_REPLAY_CONFIG2 0x1b1 /* eDP 1.5 */
> +# define DP_PANEL_REPLAY_SINK_REFRESH_RATE_UNLOCK_GRANTED (1 << 0)
> +# define DP_PANEL_REPLAY_CRC_VERIFICATION (1 << 1)
> +# define DP_PANEL_REPLAY_SU_Y_GRANULARITY_EXTENDED_EN (1 << 2)
> +# define DP_PANEL_REPLAY_SU_Y_GRANULARITY_EXTENDED_VAL_SEL_SHIFT 3
> +# define DP_PANEL_REPLAY_SU_Y_GRANULARITY_EXTENDED_VAL_SEL_MASK (0xf << 3)
> +# define DP_PANEL_REPLAY_SU_REGION_SCANLINE_CAPTURE (1 << 7)
> +
> #define DP_PAYLOAD_ALLOCATE_SET 0x1c0
> #define DP_PAYLOAD_ALLOCATE_START_TIME_SLOT 0x1c1
> #define DP_PAYLOAD_ALLOCATE_TIME_SLOT_COUNT 0x1c2
next prev parent reply other threads:[~2024-05-28 13:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 7:22 [PATCH v3 00/20] Panel Replay eDP support Jouni Högander
2024-05-27 7:22 ` [PATCH v3 01/20] drm/i915/psr: Store pr_dpcd in intel_dp Jouni Högander
2024-05-28 6:27 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 02/20] drm/panel replay: Add edp1.5 Panel Replay bits and register Jouni Högander
2024-05-28 6:28 ` Manna, Animesh
2024-05-28 13:02 ` Maarten Lankhorst [this message]
2024-05-27 7:22 ` [PATCH v3 03/20] drm/i915/psr: Move printing sink PSR support to own function Jouni Högander
2024-05-28 6:29 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 04/20] drm/i915/psr: Move printing PSR mode " Jouni Högander
2024-05-28 6:30 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 05/20] drm/i915/psr: modify psr status debugfs to support eDP Panel Replay Jouni Högander
2024-05-28 6:40 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 06/20] drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid Jouni Högander
2024-05-29 7:20 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 07/20] drm/i915/psr: Add Early Transport into psr debugfs interface Jouni Högander
2024-05-29 7:21 ` Manna, Animesh
2024-05-27 7:22 ` [PATCH v3 08/20] drm/display: Add missing aux less alpm wake related bits Jouni Högander
2024-05-27 7:22 ` [PATCH v3 09/20] drm/i915/psr: Check panel ALPM capability for eDP Panel Replay Jouni Högander
2024-05-27 7:22 ` [PATCH v3 10/20] drm/i915/psr: Inform Panel Replay source support on eDP as well Jouni Högander
2024-05-27 7:22 ` [PATCH v3 11/20] drm/i915/psr: enable sink for eDP1.5 Panel Replay Jouni Högander
2024-05-27 7:22 ` [PATCH v3 12/20] drm/i915/psr: Check panel Early Transport capability for eDP PR Jouni Högander
2024-05-27 7:22 ` [PATCH v3 13/20] drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay Jouni Högander
2024-05-27 7:22 ` [PATCH v3 14/20] drm/i915/psr: Add Panel Replay compute_config helper Jouni Högander
2024-05-27 7:22 ` [PATCH v3 15/20] drm/i915/psr: 128b/132b Panel Replay is not supported on eDP Jouni Högander
2024-05-27 7:22 ` [PATCH v3 16/20] drm/i915/psr: HW will not allow PR on eDP when HDCP enabled Jouni Högander
2024-05-27 7:22 ` [PATCH v3 17/20] drm/i915/psr: Check Early Transport for Panel Replay as well Jouni Högander
2024-05-27 7:22 ` [PATCH v3 18/20] drm/i915/psr: Modify dg2_activate_panel_replay to support eDP Jouni Högander
2024-05-27 7:22 ` [PATCH v3 19/20] drm/i915/psr: Add new debug bit to disable Panel Replay Jouni Högander
2024-05-27 7:22 ` [PATCH v3 20/20] Revert "drm/i915/psr: Disable early transport by default" Jouni Högander
2024-05-27 7:50 ` ✗ Fi.CI.CHECKPATCH: warning for Panel Replay eDP support (rev3) Patchwork
2024-05-27 7:50 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-27 8:08 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-27 10:25 ` ✗ Fi.CI.CHECKPATCH: warning for Panel Replay eDP support (rev4) Patchwork
2024-05-27 10:25 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-27 10:35 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-05-27 11:25 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-27 16:15 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e133e5-2399-4db4-a290-70bc77ca065b@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox