Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe: avoid the async_flip update in the initial plane config
@ 2024-04-19 14:09 Vinod Govindapillai
  2024-04-19 17:34 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Vinod Govindapillai @ 2024-04-19 14:09 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: vinod.govindapillai, ville.syrjala, matthew.d.roper

Async flip call is not needed. The updated fb mapping is updated
as part of the fixup_initial_plane_config() call. Otherwise we
end up updating the PLAN_SURF register twice with the same info.

v2: avoid async_flip instead of removing fixup call (Ville)

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 9693c56d386b..b5f8381b593d 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -189,8 +189,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -236,14 +234,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-09-18  9:01 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 14:09 [PATCH v1] drm/xe: avoid the async_flip update in the initial plane config Vinod Govindapillai
2024-04-19 17:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-04-20  1:30 ` ✓ Fi.CI.IGT: " Patchwork
2024-06-14  7:11 ` [PATCH v1] " Hogander, Jouni
2024-06-14  8:23   ` Govindapillai, Vinod
2024-06-14  8:41     ` Hogander, Jouni
2024-09-17 19:37 ` ✓ Fi.CI.BAT: success for drm/xe: avoid the async_flip update in the initial plane config (rev2) Patchwork
2024-09-18  9:01 ` ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox