* Re: [Intel-gfx] [PATCH] drm/i915/gem: remove unused assignments
[not found] <20220620100216.1791284-1-zys.zljxml@gmail.com>
@ 2022-06-20 10:12 ` Jani Nikula
2022-06-20 10:18 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2022-06-20 10:12 UTC (permalink / raw)
To: zys.zljxml, dri-devel, intel-gfx, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: thomas.hellstrom, katrinzhou, linux-kernel, matthew.auld, kernel
On Mon, 20 Jun 2022, zys.zljxml@gmail.com wrote:
> From: katrinzhou <katrinzhou@tencent.com>
>
> The variable ret is reassigned and the value EINVAL is never used.
> Thus, remove the unused assignments.
It's obviously a bug, but it's not obvious just throwing the code away
is the fix. Maybe there's a missing "else" instead.
BR,
Jani.
>
> Addresses-Coverity: ("Unused value")
> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)")
> Signed-off-by: katrinzhou <katrinzhou@tencent.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index ab4c5ab28e4d..d5ef5243673a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -931,8 +931,6 @@ static int set_proto_ctx_param(struct drm_i915_file_private *fpriv,
> break;
>
> case I915_CONTEXT_PARAM_PERSISTENCE:
> - if (args->size)
> - ret = -EINVAL;
> ret = proto_context_set_persistence(fpriv->dev_priv, pc,
> args->value);
> break;
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/gem: remove unused assignments
[not found] <20220620100216.1791284-1-zys.zljxml@gmail.com>
2022-06-20 10:12 ` [Intel-gfx] [PATCH] drm/i915/gem: remove unused assignments Jani Nikula
@ 2022-06-20 10:18 ` Tvrtko Ursulin
[not found] ` <CAOaDN_T_ZVCfhmbqd1AJnt3vhTuxnGhKsxG2fjjF8-u4wXOBcg@mail.gmail.com>
1 sibling, 1 reply; 3+ messages in thread
From: Tvrtko Ursulin @ 2022-06-20 10:18 UTC (permalink / raw)
To: zys.zljxml, dri-devel, intel-gfx, jani.nikula, joonas.lahtinen,
rodrigo.vivi, airlied, daniel
Cc: thomas.hellstrom, katrinzhou, linux-kernel, matthew.auld, kernel
On 20/06/2022 11:02, zys.zljxml@gmail.com wrote:
> From: katrinzhou <katrinzhou@tencent.com>
>
> The variable ret is reassigned and the value EINVAL is never used.
> Thus, remove the unused assignments.
>
> Addresses-Coverity: ("Unused value")
> Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to handle create parameters (v5)")
> Signed-off-by: katrinzhou <katrinzhou@tencent.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index ab4c5ab28e4d..d5ef5243673a 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -931,8 +931,6 @@ static int set_proto_ctx_param(struct drm_i915_file_private *fpriv,
> break;
>
> case I915_CONTEXT_PARAM_PERSISTENCE:
> - if (args->size)
> - ret = -EINVAL;
> ret = proto_context_set_persistence(fpriv->dev_priv, pc,
> args->value);
AFAICT fix should end up with code like this:
if (args->size)
ret = -EINVAL;
else
ret = proto_context_set_persistence(...)
break;
Alternatively move args->size checking into
proto_context_set_persistence to align with set_persistence().
Regards,
Tvrtko
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread