Re: [PATCH v6 5/5] drm/xe: Remove xe_ggtt_node_allocated

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 1/26/2026 11:46 AM, Maarten Lankhorst wrote:
> With the intermediate state gone, no longer useful. Just check against
> NULL where needed.
> 
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
>  drivers/gpu/drm/xe/display/xe_fb_pin.c     |  3 +--
>  drivers/gpu/drm/xe/xe_ggtt.c               | 17 -----------------
>  drivers/gpu/drm/xe/xe_ggtt.h               |  1 -
>  drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 12 ++++++------
>  4 files changed, 7 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 5ff583699325c..e1d29b6ba043e 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -352,8 +352,7 @@ static void __xe_unpin_fb_vma(struct i915_vma *vma)
>  
>  	if (vma->dpt)
>  		xe_bo_unpin_map_no_vm(vma->dpt);
> -	else if (!xe_ggtt_node_allocated(vma->bo->ggtt_node[tile_id]) ||
> -		 vma->bo->ggtt_node[tile_id] != vma->node)
> +	else if (vma->bo->ggtt_node[tile_id] != vma->node)

this isn't 1:1 to what the commit message says, can you explain why?

>  		xe_ggtt_node_remove(vma->node, false);
>  
>  	ttm_bo_reserve(&vma->bo->ttm, false, false, NULL);