From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>,
<intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH v6 3/5] drm/xe: Move struct xe_ggtt to xe_ggtt.c
Date: Mon, 26 Jan 2026 22:06:16 +0100 [thread overview]
Message-ID: <caf65166-e6c9-40c5-8a14-2a34dd747e0d@intel.com> (raw)
In-Reply-To: <20260126104604.988024-4-dev@lankhorst.se>
On 1/26/2026 11:46 AM, Maarten Lankhorst wrote:
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> No users left outside of xe_ggtt.c, so we can make the struct private.
>
> This prevents us from accidentally touching it before init.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
still double s-o-b, but code is fine,
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
...
>
> typedef void (*xe_ggtt_set_pte_fn)(struct xe_ggtt *ggtt, u64 addr, u64 pte);
> typedef void (*xe_ggtt_transform_cb)(struct xe_ggtt *ggtt,
> struct xe_ggtt_node *node,
> u64 pte_flags,
> xe_ggtt_set_pte_fn set_pte, void *arg);
nit: I hope one day we can get rid of these typedefs...
next prev parent reply other threads:[~2026-01-26 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:45 [PATCH v6 0/5] drm/xe: Privatize struct xe_ggtt Maarten Lankhorst
2026-01-26 10:46 ` [PATCH v6 1/5] drm/xe: Make xe_ggtt_node offset relative to starting offset Maarten Lankhorst
2026-01-26 21:01 ` Michal Wajdeczko
2026-01-26 10:46 ` [PATCH v6 2/5] drm/xe: Rewrite GGTT VF initialization Maarten Lankhorst
2026-01-26 21:02 ` Michal Wajdeczko
2026-01-26 10:46 ` [PATCH v6 3/5] drm/xe: Move struct xe_ggtt to xe_ggtt.c Maarten Lankhorst
2026-01-26 21:06 ` Michal Wajdeczko [this message]
2026-01-26 10:46 ` [PATCH v6 4/5] drm/xe: Make xe_ggtt_node_insert return a node Maarten Lankhorst
2026-01-26 21:07 ` Michal Wajdeczko
2026-01-26 10:46 ` [PATCH v6 5/5] drm/xe: Remove xe_ggtt_node_allocated Maarten Lankhorst
2026-01-26 21:13 ` Michal Wajdeczko
2026-01-26 14:26 ` ✓ i915.CI.BAT: success for drm/xe: Privatize struct xe_ggtt Patchwork
2026-01-26 18:16 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf65166-e6c9-40c5-8a14-2a34dd747e0d@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox