* [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" @ 2017-04-18 12:11 Daniel Vetter 2017-04-18 12:29 ` Laurent Pinchart 2017-04-18 12:33 ` ✗ Fi.CI.BAT: failure for " Patchwork 0 siblings, 2 replies; 5+ messages in thread From: Daniel Vetter @ 2017-04-18 12:11 UTC (permalink / raw) To: DRI Development Cc: Daniel Vetter, Intel Graphics Development, Laurent Pinchart, Daniel Vetter All the error codes we (ab)use are strictly not the right ones (since they're all for the vfs, and the only thing we're allowed to do from an ioctl is EINVAL). But ENOENT is the common error code for failed to look up an object throughout drm, so let's use it in the cma helpers, too. Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index d2b77b02830d..53f9bdf470d7 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -189,7 +189,7 @@ struct drm_framebuffer *drm_fb_cma_create_with_funcs(struct drm_device *dev, obj = drm_gem_object_lookup(file_priv, mode_cmd->handles[i]); if (!obj) { dev_err(dev->dev, "Failed to lookup GEM object\n"); - ret = -ENXIO; + ret = -ENOENT; goto err_gem_object_put; } -- 2.11.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" 2017-04-18 12:11 [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" Daniel Vetter @ 2017-04-18 12:29 ` Laurent Pinchart 2017-04-18 14:40 ` Sean Paul 2017-04-18 12:33 ` ✗ Fi.CI.BAT: failure for " Patchwork 1 sibling, 1 reply; 5+ messages in thread From: Laurent Pinchart @ 2017-04-18 12:29 UTC (permalink / raw) To: Daniel Vetter; +Cc: Daniel Vetter, Intel Graphics Development, DRI Development Hi Daniel, Thank you for the patch. On Tuesday 18 Apr 2017 14:11:20 Daniel Vetter wrote: > All the error codes we (ab)use are strictly not the right ones (since > they're all for the vfs, and the only thing we're allowed to do from > an ioctl is EINVAL). But ENOENT is the common error code for failed to > look up an object throughout drm, so let's use it in the cma helpers, > too. Regardless of which is best, it's true that ENOENT is used through the DRM code, so Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Someone should however mention that this changes the userspace API. I'll let you decide whether to ignore that comment :-) > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > b/drivers/gpu/drm/drm_fb_cma_helper.c index d2b77b02830d..53f9bdf470d7 > 100644 > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > @@ -189,7 +189,7 @@ struct drm_framebuffer > *drm_fb_cma_create_with_funcs(struct drm_device *dev, obj = > drm_gem_object_lookup(file_priv, mode_cmd->handles[i]); > if (!obj) { > dev_err(dev->dev, "Failed to lookup GEM object\n"); > - ret = -ENXIO; > + ret = -ENOENT; > goto err_gem_object_put; > } -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" 2017-04-18 12:29 ` Laurent Pinchart @ 2017-04-18 14:40 ` Sean Paul 2017-04-18 15:57 ` Daniel Vetter 0 siblings, 1 reply; 5+ messages in thread From: Sean Paul @ 2017-04-18 14:40 UTC (permalink / raw) To: Laurent Pinchart Cc: Daniel Vetter, Intel Graphics Development, DRI Development, Daniel Vetter On Tue, Apr 18, 2017 at 03:29:29PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Tuesday 18 Apr 2017 14:11:20 Daniel Vetter wrote: > > All the error codes we (ab)use are strictly not the right ones (since > > they're all for the vfs, and the only thing we're allowed to do from > > an ioctl is EINVAL). But ENOENT is the common error code for failed to > > look up an object throughout drm, so let's use it in the cma helpers, > > too. > > Regardless of which is best, it's true that ENOENT is used through the DRM > code, so > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Someone should however mention that this changes the userspace API. I'll let > you decide whether to ignore that comment :-) Yeah, let's make sure we don't break any existing userspaces (a la pulseaudio). Sean > > > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > --- > > drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > > b/drivers/gpu/drm/drm_fb_cma_helper.c index d2b77b02830d..53f9bdf470d7 > > 100644 > > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > > @@ -189,7 +189,7 @@ struct drm_framebuffer > > *drm_fb_cma_create_with_funcs(struct drm_device *dev, obj = > > drm_gem_object_lookup(file_priv, mode_cmd->handles[i]); > > if (!obj) { > > dev_err(dev->dev, "Failed to lookup GEM object\n"); > > - ret = -ENXIO; > > + ret = -ENOENT; > > goto err_gem_object_put; > > } > > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" 2017-04-18 14:40 ` Sean Paul @ 2017-04-18 15:57 ` Daniel Vetter 0 siblings, 0 replies; 5+ messages in thread From: Daniel Vetter @ 2017-04-18 15:57 UTC (permalink / raw) To: Sean Paul Cc: Daniel Vetter, Intel Graphics Development, Laurent Pinchart, DRI Development, Daniel Vetter On Tue, Apr 18, 2017 at 10:40:21AM -0400, Sean Paul wrote: > On Tue, Apr 18, 2017 at 03:29:29PM +0300, Laurent Pinchart wrote: > > Hi Daniel, > > > > Thank you for the patch. > > > > On Tuesday 18 Apr 2017 14:11:20 Daniel Vetter wrote: > > > All the error codes we (ab)use are strictly not the right ones (since > > > they're all for the vfs, and the only thing we're allowed to do from > > > an ioctl is EINVAL). But ENOENT is the common error code for failed to > > > look up an object throughout drm, so let's use it in the cma helpers, > > > too. > > > > Regardless of which is best, it's true that ENOENT is used through the DRM > > code, so > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > Someone should however mention that this changes the userspace API. I'll let > > you decide whether to ignore that comment :-) > > Yeah, let's make sure we don't break any existing userspaces (a la pulseaudio). Good point, but I think this is safe. I augmented the commit message and merged the patch with Sean's irc r-b (plus Laurent's r-b from here). -Daniel > > Sean > > > > > > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > --- > > > drivers/gpu/drm/drm_fb_cma_helper.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c > > > b/drivers/gpu/drm/drm_fb_cma_helper.c index d2b77b02830d..53f9bdf470d7 > > > 100644 > > > --- a/drivers/gpu/drm/drm_fb_cma_helper.c > > > +++ b/drivers/gpu/drm/drm_fb_cma_helper.c > > > @@ -189,7 +189,7 @@ struct drm_framebuffer > > > *drm_fb_cma_create_with_funcs(struct drm_device *dev, obj = > > > drm_gem_object_lookup(file_priv, mode_cmd->handles[i]); > > > if (!obj) { > > > dev_err(dev->dev, "Failed to lookup GEM object\n"); > > > - ret = -ENXIO; > > > + ret = -ENOENT; > > > goto err_gem_object_put; > > > } > > > > -- > > Regards, > > > > Laurent Pinchart > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Sean Paul, Software Engineer, Google / Chromium OS -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/cma-helper: Return ENOENT for "no such gem obj" 2017-04-18 12:11 [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" Daniel Vetter 2017-04-18 12:29 ` Laurent Pinchart @ 2017-04-18 12:33 ` Patchwork 1 sibling, 0 replies; 5+ messages in thread From: Patchwork @ 2017-04-18 12:33 UTC (permalink / raw) To: Daniel Vetter; +Cc: intel-gfx == Series Details == Series: drm/cma-helper: Return ENOENT for "no such gem obj" URL : https://patchwork.freedesktop.org/series/23172/ State : failure == Summary == Series 23172v1 drm/cma-helper: Return ENOENT for "no such gem obj" https://patchwork.freedesktop.org/api/1.0/series/23172/revisions/1/mbox/ Test gem_exec_flush: Subgroup basic-batch-kernel-default-uc: pass -> FAIL (fi-snb-2600) fdo#100007 Test gem_exec_suspend: Subgroup basic-s4-devices: dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125 Test pm_rpm: Subgroup basic-rte: pass -> INCOMPLETE (fi-bsw-n3050) fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007 fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125 fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time:429s fi-bdw-gvtdvm total:278 pass:256 dwarn:8 dfail:0 fail:0 skip:14 time:425s fi-bsw-n3050 total:242 pass:207 dwarn:0 dfail:0 fail:0 skip:34 fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time:517s fi-byt-j1900 total:278 pass:254 dwarn:0 dfail:0 fail:0 skip:24 time:487s fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:410s fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time:402s fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:488s fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7500u total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time:458s fi-kbl-7560u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:594s fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:454s fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time:578s fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time:461s fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time:487s fi-skl-gvtdvm total:278 pass:265 dwarn:0 dfail:0 fail:0 skip:13 time:433s fi-snb-2600 total:278 pass:248 dwarn:0 dfail:0 fail:1 skip:29 time:407s fi-byt-n2820 failed to collect. IGT log at Patchwork_4511/fi-byt-n2820/igt.log fi-snb-2520m failed to collect. IGT log at Patchwork_4511/fi-snb-2520m/igt.log 4d374295ace9e57d83483341e2ad07cad5baf912 drm-tip: 2017y-04m-18d-10h-08m-05s UTC integration manifest 2cf2e53 drm/cma-helper: Return ENOENT for "no such gem obj" == Logs == For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4511/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-18 15:57 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-04-18 12:11 [PATCH] drm/cma-helper: Return ENOENT for "no such gem obj" Daniel Vetter 2017-04-18 12:29 ` Laurent Pinchart 2017-04-18 14:40 ` Sean Paul 2017-04-18 15:57 ` Daniel Vetter 2017-04-18 12:33 ` ✗ Fi.CI.BAT: failure for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox