From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: LVDS fallback to fixed-mode if EDID not present
Date: Thu, 22 Nov 2012 16:36:13 +0000 [thread overview]
Message-ID: <84c8a8$6kpes4@orsmga001.jf.intel.com> (raw)
In-Reply-To: <87k3tdd2yc.fsf@intel.com>
On Thu, 22 Nov 2012 18:20:27 +0200, Jani Nikula <jani.nikula@intel.com> wrote:
> On Wed, 21 Nov 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> >
> > mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
> > if (mode == NULL)
> > @@ -1065,8 +1060,6 @@ bool intel_lvds_init(struct drm_device *dev)
> > kfree(edid);
> > edid = ERR_PTR(-EINVAL);
> > }
> > - } else {
> > - edid = ERR_PTR(-ENOENT);
>
> I'd like to keep this though. I was thinking a more generic, future EDID
> caching feature might use the difference between -EINVAL and -ENOENT,
> NULL being the "we just haven't read it yet" flag, to prevent trying to
> re-read the EDID when it isn't there. *shrug*.
Okay, that's a reasonable argument. Daniel feel free to drop this hunk.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-22 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 16:14 [PATCH 1/2] drm/i915: Report the origin of the LVDS fixed panel mode Chris Wilson
2012-11-21 16:14 ` [PATCH 2/2] drm/i915: LVDS fallback to fixed-mode if EDID not present Chris Wilson
2012-11-22 16:20 ` Jani Nikula
2012-11-22 16:36 ` Chris Wilson [this message]
2012-11-22 16:10 ` [PATCH 1/2] drm/i915: Report the origin of the LVDS fixed panel mode Jani Nikula
2012-11-25 19:00 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='84c8a8$6kpes4@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox