From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Report the origin of the LVDS fixed panel mode
Date: Thu, 22 Nov 2012 18:10:07 +0200 [thread overview]
Message-ID: <87mwy9d3fk.fsf@intel.com> (raw)
In-Reply-To: <1353514444-5771-1-git-send-email-chris@chris-wilson.co.uk>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
On Wed, 21 Nov 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_lvds.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
> index 860fa71..5b38c17 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -1083,6 +1083,9 @@ bool intel_lvds_init(struct drm_device *dev)
>
> list_for_each_entry(scan, &connector->probed_modes, head) {
> if (scan->type & DRM_MODE_TYPE_PREFERRED) {
> + DRM_DEBUG_KMS("using preferred mode from EDID: ");
> + drm_mode_debug_printmodeline(scan);
> +
> fixed_mode = drm_mode_duplicate(dev, scan);
> intel_find_lvds_downclock(dev, fixed_mode, connector);
> goto out;
> @@ -1091,6 +1094,9 @@ bool intel_lvds_init(struct drm_device *dev)
>
> /* Failed to get EDID, what about VBT? */
> if (dev_priv->lfp_lvds_vbt_mode) {
> + DRM_DEBUG_KMS("using mode from VBT: ");
> + drm_mode_debug_printmodeline(dev_priv->lfp_lvds_vbt_mode);
> +
> fixed_mode = drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
> if (fixed_mode) {
> fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
> @@ -1115,8 +1121,11 @@ bool intel_lvds_init(struct drm_device *dev)
> if (crtc && (lvds & LVDS_PORT_EN)) {
> struct drm_display_mode mode;
>
> - if (intel_crtc_get_mode(crtc, &mode))
> + if (intel_crtc_get_mode(crtc, &mode)) {
> + DRM_DEBUG_KMS("using current (BIOS) mode: ");
> + drm_mode_debug_printmodeline(&mode);
> fixed_mode = drm_mode_duplicate(dev, &mode);
> + }
> if (fixed_mode) {
> fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
> fixed_mode->flags = intel_lvds_get_mode_flags(intel_encoder);
> --
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2012-11-22 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 16:14 [PATCH 1/2] drm/i915: Report the origin of the LVDS fixed panel mode Chris Wilson
2012-11-21 16:14 ` [PATCH 2/2] drm/i915: LVDS fallback to fixed-mode if EDID not present Chris Wilson
2012-11-22 16:20 ` Jani Nikula
2012-11-22 16:36 ` Chris Wilson
2012-11-22 16:10 ` Jani Nikula [this message]
2012-11-25 19:00 ` [PATCH 1/2] drm/i915: Report the origin of the LVDS fixed panel mode Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwy9d3fk.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox