From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: fixup sparse warnings
Date: Mon, 03 Dec 2012 21:13:52 +0000 [thread overview]
Message-ID: <84c8a8$6pr9bk@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1354223932-8278-1-git-send-email-daniel.vetter@ffwll.ch>
On Thu, 29 Nov 2012 22:18:51 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> - __iomem where there is none (I love how we mix these things up).
> - Use gfp_t instead of an other plain type.
> - Unconfuse one place about enum pipe vs enum transcoder - for the pch
> transcoder we actually use the pipe enum. Fixup the other cases
> where we assign the pipe to the cpu transcoder with explicit casts.
> - Declare the mch_lock properly in a header.
>
> There is still a decent mess in intel_bios.c about __iomem, but heck,
> this is x86 and we're allowed to do that.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Makes-sparse-happy: Chris Wilson <chris@chris-wilson.co.uk>
How about deciding whether it is '(cast) object' or '(cast)object' and
be consistent.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-03 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 21:18 [PATCH] drm/i915: fixup sparse warnings Daniel Vetter
2012-12-03 21:13 ` Chris Wilson [this message]
2012-12-03 21:35 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='84c8a8$6pr9bk@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox