Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS
@ 2022-03-24 17:21 Matthew Auld
  2022-03-24 17:21 ` [Intel-gfx] [PATCH 2/2] drm/i915/migrate: move the sanity check Matthew Auld
                   ` (10 more replies)
  0 siblings, 11 replies; 19+ messages in thread
From: Matthew Auld @ 2022-03-24 17:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: Thomas Hellström, dri-devel

We only need this when allocating device local-memory, where this
influences the drm_buddy. Currently there is some funny behaviour where
an "in limbo" system memory object is lacking the relevant placement
flags etc. before we first allocate the ttm_tt, leading to ttm
performing a move when not needed, since the current placement is seen
as not compatible.

Suggested-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Fixes: 2ed38cec5606 ("drm/i915: opportunistically apply ALLOC_CONTIGIOUS")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index e4a06fcf741a..97e648fa76bd 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
@@ -133,6 +133,9 @@ i915_ttm_place_from_region(const struct intel_memory_region *mr,
 	memset(place, 0, sizeof(*place));
 	place->mem_type = intel_region_to_ttm_type(mr);
 
+	if (mr->type == INTEL_MEMORY_SYSTEM)
+		return;
+
 	if (flags & I915_BO_ALLOC_CONTIGUOUS)
 		place->flags |= TTM_PL_FLAG_CONTIGUOUS;
 	if (offset != I915_BO_INVALID_OFFSET) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2022-03-29  1:14 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-24 17:21 [Intel-gfx] [PATCH 1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS Matthew Auld
2022-03-24 17:21 ` [Intel-gfx] [PATCH 2/2] drm/i915/migrate: move the sanity check Matthew Auld
2022-03-25  7:17   ` Thomas Hellström
2022-03-24 17:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS Patchwork
2022-03-24 18:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-25  7:16 ` [Intel-gfx] [PATCH 1/2] " Thomas Hellström
2022-03-25 10:03   ` Das, Nirmoy
2022-03-25 10:05     ` Das, Nirmoy
2022-03-25 10:06       ` Das, Nirmoy
2022-03-25 10:09         ` Das, Nirmoy
2022-03-25  8:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS (rev2) Patchwork
2022-03-25  9:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-03-25  9:48   ` Matthew Auld
2022-03-25 15:34     ` Vudum, Lakshminarayana
2022-03-25 15:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-25 17:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-28 22:26 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915/ttm: limit where we apply TTM_PL_FLAG_CONTIGUOUS (rev3) Patchwork
2022-03-28 22:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-29  1:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox