Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT
@ 2023-10-02 14:07 Jonathan Cavitt
  2023-10-02 14:42 ` Nirmoy Das
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Jonathan Cavitt @ 2023-10-02 14:07 UTC (permalink / raw)
  To: intel-gfx
  Cc: andi.shyti, chris.p.wilson, jonathan.cavitt, saurabhg.gupta,
	matthew.d.roper

From: Chris Wilson <chris.p.wilson@intel.com>

With multi-GT devices, the object may have been bound on each GT and so
we need to invalidate the TLBs across all GT before releasing the pages
back to the system.

Fixes: d6c531ab4820 ("drm/i915: Invalidate the TLBs on each GT")
Signed-off-by: Chris Wilson <chris.p.wilson@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
CC: Matt Roper <matthew.d.roper@intel.com>
CC: Andi Shyti <andi.shyti@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_pages.c b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
index 6b6d22c194110..0ba955611dfb5 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_pages.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_pages.c
@@ -198,7 +198,7 @@ static void flush_tlb_invalidate(struct drm_i915_gem_object *obj)
 
 	for_each_gt(gt, i915, id) {
 		if (!obj->mm.tlb[id])
-			return;
+			continue;
 
 		intel_gt_invalidate_tlb_full(gt, obj->mm.tlb[id]);
 		obj->mm.tlb[id] = 0;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-10-03 17:18 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 14:07 [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT Jonathan Cavitt
2023-10-02 14:42 ` Nirmoy Das
2023-10-02 23:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-10-03  0:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-03  9:26   ` Andi Shyti
2023-10-03 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Invalidate the TLBs on each GT (rev2) Patchwork
2023-10-03 15:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-10-03 17:17 ` [Intel-gfx] [PATCH] drm/i915: Invalidate the TLBs on each GT Andi Shyti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox