Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Print debugfs object list sizes in kiB instead of bytes.
@ 2011-12-20 16:54 Eric Anholt
  2011-12-20 16:58 ` David Woodhouse
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Anholt @ 2011-12-20 16:54 UTC (permalink / raw)
  To: intel-gfx

They're all in increments of pages, so this just makes it easier on
the eyes.

Signed-off-by: Eric Anholt <eric@anholt.net>
---

for drm-intel-next

 drivers/gpu/drm/i915/i915_debugfs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 004b048..af7d2ff 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -121,11 +121,11 @@ static const char *cache_level_str(int type)
 static void
 describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
 {
-	seq_printf(m, "%p: %s%s %8zd %04x %04x %d %d%s%s%s",
+	seq_printf(m, "%p: %s%s %8zdKB %04x %04x %d %d%s%s%s",
 		   &obj->base,
 		   get_pin_flag(obj),
 		   get_tiling_flag(obj),
-		   obj->base.size,
+		   obj->base.size / 1024,
 		   obj->base.read_domains,
 		   obj->base.write_domain,
 		   obj->last_rendering_seqno,
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Print debugfs object list sizes in kiB instead of bytes.
  2011-12-20 16:54 [PATCH] drm/i915: Print debugfs object list sizes in kiB instead of bytes Eric Anholt
@ 2011-12-20 16:58 ` David Woodhouse
  2012-01-09 22:09   ` Keith Packard
  0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2011-12-20 16:58 UTC (permalink / raw)
  To: Eric Anholt; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 494 bytes --]

On Tue, 2011-12-20 at 08:54 -0800, Eric Anholt wrote:
> -       seq_printf(m, "%p: %s%s %8zd %04x %04x %d %d%s%s%s",
> +       seq_printf(m, "%p: %s%s %8zdKB %04x %04x %d %d%s%s%s",
>                    &obj->base,
>                    get_pin_flag(obj),
>                    get_tiling_flag(obj),
> -                  obj->base.size,
> +                  obj->base.size / 1024, 

In both the seq_printf, and the subject line, you have different
misspellings of 'KiB'.

-- 
dwmw2

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Print debugfs object list sizes in kiB instead of bytes.
  2011-12-20 16:58 ` David Woodhouse
@ 2012-01-09 22:09   ` Keith Packard
  0 siblings, 0 replies; 3+ messages in thread
From: Keith Packard @ 2012-01-09 22:09 UTC (permalink / raw)
  To: David Woodhouse, Eric Anholt; +Cc: intel-gfx


[-- Attachment #1.1: Type: text/plain, Size: 298 bytes --]

On Tue, 20 Dec 2011 16:58:55 +0000, David Woodhouse <dwmw2@infradead.org> wrote:

> In both the seq_printf, and the subject line, you have different
> misspellings of 'KiB'.

I fixed the misspellings and merged this to my drm-intel-next-fixes
pending branch.

-- 
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-09 22:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-20 16:54 [PATCH] drm/i915: Print debugfs object list sizes in kiB instead of bytes Eric Anholt
2011-12-20 16:58 ` David Woodhouse
2012-01-09 22:09   ` Keith Packard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox