From: Keith Packard <keithp@keithp.com>
To: Takashi Iwai <tiwai@suse.de>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too
Date: Tue, 20 Mar 2012 07:57:14 -0700 [thread overview]
Message-ID: <86mx7bmib9.fsf@sumi.keithp.com> (raw)
In-Reply-To: <s5hehsno4va.wl%tiwai@suse.de>
<#part sign=pgpmime>
On Tue, 20 Mar 2012 13:04:41 +0100, Takashi Iwai <tiwai@suse.de> wrote:
> Since checking the lid state is tricky and unreliable, the practical
> check would be simply reading the first LVDS reg and seeing whether it
> was initialized or not. It seems that it reads to 0x02 when booted
> with the lid close, which is LVDS_DETECTED bit.
Right, lid-detect is not useful, so I suggested using the new code path
only if the LVDS was *not* actually running at startup time. That should
avoid almost all common cases that work correctly today.
--
keith.packard@intel.com
next prev parent reply other threads:[~2012-03-20 14:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 11:07 [PATCH 0/2 v5] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-19 11:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-20 10:01 ` Daniel Vetter
2012-03-20 12:04 ` Takashi Iwai
2012-03-20 14:57 ` Keith Packard [this message]
2012-03-20 18:35 ` Rodrigo Vivi
2012-03-19 11:07 ` [PATCH 2/2] drm/i915: Add lvds_channel module option Takashi Iwai
2012-03-19 13:47 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2012-03-20 12:07 [PATCH 0/2 v6] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-20 12:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-21 22:31 ` Daniel Vetter
2012-03-22 20:57 ` Paulo Zanoni
2012-03-16 21:41 [PATCH 0/2 v4] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-16 21:41 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-16 23:18 ` Keith Packard
2012-03-17 7:59 ` Takashi Iwai
2012-03-17 19:01 ` Keith Packard
2012-03-18 20:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mx7bmib9.fsf@sumi.keithp.com \
--to=keithp@keithp.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox