From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too
Date: Tue, 20 Mar 2012 11:01:22 +0100 [thread overview]
Message-ID: <20120320094114.GA3951@phenom.ffwll.local> (raw)
In-Reply-To: <1332155257-17649-2-git-send-email-tiwai@suse.de>
On Mon, Mar 19, 2012 at 12:07:36PM +0100, Takashi Iwai wrote:
> Currently i915 driver checks [PCH_]LVDS register bits to decide
> whether to set up the dual-link or the single-link mode. This relies
> implicitly on that BIOS initializes the register properly at boot.
> However, BIOS doesn't initialize it always. When the machine is
> booted with the closed lid, BIOS skips the LVDS reg initialization.
> This ends up in blank output on a machine with a dual-link LVDS when
> you open the lid after the boot.
>
> This patch adds a workaround for that problem by checking the initial
> LVDS register value in VBT.
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Reviewed-by: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
If I understand Keith correctly he would like this to only get used when
the lid is closed and the panel is off. But I don't see that mention in
you change log nor can I find how it works in the code. Has this been lost
or am I confused?
Thanks, Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-03-20 10:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 11:07 [PATCH 0/2 v5] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-19 11:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-20 10:01 ` Daniel Vetter [this message]
2012-03-20 12:04 ` Takashi Iwai
2012-03-20 14:57 ` Keith Packard
2012-03-20 18:35 ` Rodrigo Vivi
2012-03-19 11:07 ` [PATCH 2/2] drm/i915: Add lvds_channel module option Takashi Iwai
2012-03-19 13:47 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2012-03-20 12:07 [PATCH 0/2 v6] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-20 12:07 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-21 22:31 ` Daniel Vetter
2012-03-22 20:57 ` Paulo Zanoni
2012-03-16 21:41 [PATCH 0/2 v4] drm/i915: LVDS channel mode fixes Takashi Iwai
2012-03-16 21:41 ` [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too Takashi Iwai
2012-03-16 23:18 ` Keith Packard
2012-03-17 7:59 ` Takashi Iwai
2012-03-17 19:01 ` Keith Packard
2012-03-18 20:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320094114.GA3951@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox