Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up
@ 2024-08-29 14:47 Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 1/6] drm/i915 & drm/xe: save struct drm_device to drvdata Jani Nikula
                   ` (9 more replies)
  0 siblings, 10 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

Follow-up to [1].

BR,
Jani.


[1] https://lore.kernel.org/r/cover.1723129920.git.jani.nikula@intel.com

Jani Nikula (6):
  drm/i915 & drm/xe: save struct drm_device to drvdata
  drm/i915: support struct device and pci_dev in to_intel_display()
  drm/i915/audio: migrate away from kdev_to_i915()
  drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind
  drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915()

 drivers/gpu/drm/i915/display/intel_audio.c    | 34 ++++++----
 .../drm/i915/display/intel_display_types.h    |  8 ++-
 drivers/gpu/drm/i915/display/intel_hdcp.c     | 10 +--
 .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
 drivers/gpu/drm/i915/i915_driver.c            |  2 +-
 drivers/gpu/drm/i915/i915_drv.h               |  8 ++-
 .../gpu/drm/i915/selftests/mock_gem_device.c  |  2 +-
 .../gpu/drm/xe/compat-i915-headers/i915_drv.h |  7 --
 drivers/gpu/drm/xe/xe_device.h                |  8 ++-
 drivers/gpu/drm/xe/xe_pci.c                   |  2 +-
 10 files changed, 94 insertions(+), 54 deletions(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2 1/6] drm/i915 & drm/xe: save struct drm_device to drvdata
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 2/6] drm/i915: support struct device and pci_dev in to_intel_display() Jani Nikula
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

In the future, the display code shall not have any idea about struct
xe_device or struct drm_i915_private, but will need to get at the struct
drm_device via drvdata. Store the struct drm_device pointer to drvdata
instead of the driver specific pointer.

Avoid passing NULL to container_of() via to_i915()/to_xe_device(). (It
does return NULL for NULL pointers when the offset happens to be 0, but
otherwise returns garbage pointers for NULL.)

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_driver.c                | 2 +-
 drivers/gpu/drm/i915/i915_drv.h                   | 8 ++++++--
 drivers/gpu/drm/i915/selftests/mock_gem_device.c  | 2 +-
 drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 4 +++-
 drivers/gpu/drm/xe/xe_device.h                    | 8 ++++++--
 drivers/gpu/drm/xe/xe_pci.c                       | 2 +-
 6 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index ccdd2983cfb5..71ca02f7df9d 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -723,7 +723,7 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (IS_ERR(i915))
 		return i915;
 
-	pci_set_drvdata(pdev, i915);
+	pci_set_drvdata(pdev, &i915->drm);
 
 	/* Device parameters start as a copy of module parameters. */
 	i915_params_copy(&i915->params, &i915_modparams);
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index d772cbe15fec..39f6614a0a99 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -365,12 +365,16 @@ static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
 
 static inline struct drm_i915_private *kdev_to_i915(struct device *kdev)
 {
-	return dev_get_drvdata(kdev);
+	struct drm_device *drm = dev_get_drvdata(kdev);
+
+	return drm ? to_i915(drm) : NULL;
 }
 
 static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)
 {
-	return pci_get_drvdata(pdev);
+	struct drm_device *drm = pci_get_drvdata(pdev);
+
+	return drm ? to_i915(drm) : NULL;
 }
 
 static inline struct intel_gt *to_gt(const struct drm_i915_private *i915)
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 0bd29846873b..91794ca17a58 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -172,7 +172,7 @@ struct drm_i915_private *mock_gem_device(void)
 		return NULL;
 	}
 
-	pci_set_drvdata(pdev, i915);
+	pci_set_drvdata(pdev, &i915->drm);
 
 	/* Device parameters start as a copy of module parameters. */
 	i915_params_copy(&i915->params, &i915_modparams);
diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
index b7b12b20e390..becb6a7ec9d7 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
@@ -23,7 +23,9 @@ static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
 
 static inline struct drm_i915_private *kdev_to_i915(struct device *kdev)
 {
-	return dev_get_drvdata(kdev);
+	struct drm_device *drm = dev_get_drvdata(kdev);
+
+	return drm ? to_i915(drm) : NULL;
 }
 
 #define IS_PLATFORM(xe, x) ((xe)->info.platform == x)
diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
index f052c06a2d2f..894f04770454 100644
--- a/drivers/gpu/drm/xe/xe_device.h
+++ b/drivers/gpu/drm/xe/xe_device.h
@@ -17,12 +17,16 @@ static inline struct xe_device *to_xe_device(const struct drm_device *dev)
 
 static inline struct xe_device *kdev_to_xe_device(struct device *kdev)
 {
-	return dev_get_drvdata(kdev);
+	struct drm_device *drm = dev_get_drvdata(kdev);
+
+	return drm ? to_xe_device(drm) : NULL;
 }
 
 static inline struct xe_device *pdev_to_xe_device(struct pci_dev *pdev)
 {
-	return pci_get_drvdata(pdev);
+	struct drm_device *drm = pci_get_drvdata(pdev);
+
+	return drm ? to_xe_device(drm) : NULL;
 }
 
 static inline struct xe_device *xe_device_const_cast(const struct xe_device *xe)
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 330cd2d785bc..c05ca61787be 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -798,7 +798,7 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (IS_ERR(xe))
 		return PTR_ERR(xe);
 
-	pci_set_drvdata(pdev, xe);
+	pci_set_drvdata(pdev, &xe->drm);
 
 	xe_pm_assert_unbounded_bridge(xe);
 	subplatform_desc = find_subplatform(xe, desc);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 2/6] drm/i915: support struct device and pci_dev in to_intel_display()
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 1/6] drm/i915 & drm/xe: save struct drm_device to drvdata Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 3/6] drm/i915/audio: migrate away from kdev_to_i915() Jani Nikula
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

Now that both xe and i915 store struct drm_device in drvdata, we can
trivially support struct device and struct pci_dev in
to_intel_display().

We do need to check for NULL drvdata before converting it into struct
intel_device pointer, though. Do it in __drm_device_to_intel_display().

v2: Add NULL check in __drm_device_to_intel_display() (Gustavo)

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com> # v1
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_types.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index bd290536a1b7..d43aaf963cb4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -2205,7 +2205,11 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
  * intel_display pointer.
  */
 #define __drm_device_to_intel_display(p) \
-	(&to_i915(p)->display)
+	((p) ? &to_i915(p)->display : NULL)
+#define __device_to_intel_display(p)				\
+	__drm_device_to_intel_display(dev_get_drvdata(p))
+#define __pci_dev_to_intel_display(p)				\
+	__drm_device_to_intel_display(pci_get_drvdata(p))
 #define __intel_atomic_state_to_intel_display(p)	\
 	__drm_device_to_intel_display((p)->base.dev)
 #define __intel_connector_to_intel_display(p)		\
@@ -2231,6 +2235,8 @@ to_intel_frontbuffer(struct drm_framebuffer *fb)
 #define to_intel_display(p)				\
 	_Generic(*p,					\
 		 __assoc(drm_device, p),		\
+		 __assoc(device, p),			\
+		 __assoc(pci_dev, p),			\
 		 __assoc(intel_atomic_state, p),	\
 		 __assoc(intel_connector, p),		\
 		 __assoc(intel_crtc, p),		\
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 3/6] drm/i915/audio: migrate away from kdev_to_i915()
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 1/6] drm/i915 & drm/xe: save struct drm_device to drvdata Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 2/6] drm/i915: support struct device and pci_dev in to_intel_display() Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 4/6] drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind Jani Nikula
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

Use to_intel_display() instead of kdev_to_i915() in the audio component
API hooks. Avoid further drive-by changes at this point, and just
convert the display pointer to i915, and leave the struct intel_display
conversion for later.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_audio.c | 34 +++++++++++++---------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_audio.c b/drivers/gpu/drm/i915/display/intel_audio.c
index 9b8508a503f7..f5e7eefab2f1 100644
--- a/drivers/gpu/drm/i915/display/intel_audio.c
+++ b/drivers/gpu/drm/i915/display/intel_audio.c
@@ -980,7 +980,8 @@ static void glk_force_audio_cdclk(struct drm_i915_private *i915,
 
 static unsigned long i915_audio_component_get_power(struct device *kdev)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	intel_wakeref_t ret;
 
 	/* Catch potential impedance mismatches before they occur! */
@@ -1012,7 +1013,8 @@ static unsigned long i915_audio_component_get_power(struct device *kdev)
 static void i915_audio_component_put_power(struct device *kdev,
 					   unsigned long cookie)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 
 	/* Stop forcing CDCLK to 2*BCLK if no need for audio to be powered. */
 	if (--i915->display.audio.power_refcount == 0)
@@ -1025,7 +1027,8 @@ static void i915_audio_component_put_power(struct device *kdev,
 static void i915_audio_component_codec_wake_override(struct device *kdev,
 						     bool enable)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	unsigned long cookie;
 
 	if (DISPLAY_VER(i915) < 9)
@@ -1053,7 +1056,8 @@ static void i915_audio_component_codec_wake_override(struct device *kdev,
 /* Get CDCLK in kHz  */
 static int i915_audio_component_get_cdclk_freq(struct device *kdev)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 
 	if (drm_WARN_ON_ONCE(&i915->drm, !HAS_DDI(i915)))
 		return -ENODEV;
@@ -1112,7 +1116,8 @@ static struct intel_audio_state *find_audio_state(struct drm_i915_private *i915,
 static int i915_audio_component_sync_audio_rate(struct device *kdev, int port,
 						int cpu_transcoder, int rate)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	struct i915_audio_component *acomp = i915->display.audio.component;
 	const struct intel_audio_state *audio_state;
 	struct intel_encoder *encoder;
@@ -1154,7 +1159,8 @@ static int i915_audio_component_get_eld(struct device *kdev, int port,
 					int cpu_transcoder, bool *enabled,
 					unsigned char *buf, int max_bytes)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(kdev);
+	struct intel_display *display = to_intel_display(kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	const struct intel_audio_state *audio_state;
 	int ret = 0;
 
@@ -1189,24 +1195,25 @@ static const struct drm_audio_component_ops i915_audio_component_ops = {
 	.get_eld	= i915_audio_component_get_eld,
 };
 
-static int i915_audio_component_bind(struct device *i915_kdev,
+static int i915_audio_component_bind(struct device *drv_kdev,
 				     struct device *hda_kdev, void *data)
 {
+	struct intel_display *display = to_intel_display(drv_kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	struct i915_audio_component *acomp = data;
-	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
 	int i;
 
 	if (drm_WARN_ON(&i915->drm, acomp->base.ops || acomp->base.dev))
 		return -EEXIST;
 
 	if (drm_WARN_ON(&i915->drm,
-			!device_link_add(hda_kdev, i915_kdev,
+			!device_link_add(hda_kdev, drv_kdev,
 					 DL_FLAG_STATELESS)))
 		return -ENOMEM;
 
 	drm_modeset_lock_all(&i915->drm);
 	acomp->base.ops = &i915_audio_component_ops;
-	acomp->base.dev = i915_kdev;
+	acomp->base.dev = drv_kdev;
 	BUILD_BUG_ON(MAX_PORTS != I915_MAX_PORTS);
 	for (i = 0; i < ARRAY_SIZE(acomp->aud_sample_rate); i++)
 		acomp->aud_sample_rate[i] = 0;
@@ -1216,11 +1223,12 @@ static int i915_audio_component_bind(struct device *i915_kdev,
 	return 0;
 }
 
-static void i915_audio_component_unbind(struct device *i915_kdev,
+static void i915_audio_component_unbind(struct device *drv_kdev,
 					struct device *hda_kdev, void *data)
 {
+	struct intel_display *display = to_intel_display(drv_kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 	struct i915_audio_component *acomp = data;
-	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
 
 	drm_modeset_lock_all(&i915->drm);
 	acomp->base.ops = NULL;
@@ -1228,7 +1236,7 @@ static void i915_audio_component_unbind(struct device *i915_kdev,
 	i915->display.audio.component = NULL;
 	drm_modeset_unlock_all(&i915->drm);
 
-	device_link_remove(hda_kdev, i915_kdev);
+	device_link_remove(hda_kdev, drv_kdev);
 
 	if (i915->display.audio.power_refcount)
 		drm_err(&i915->drm, "audio power refcount %d after unbind\n",
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 4/6] drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (2 preceding siblings ...)
  2024-08-29 14:47 ` [PATCH v2 3/6] drm/i915/audio: migrate away from kdev_to_i915() Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

Use to_intel_display() instead of kdev_to_i915() in the HDCP component
API hooks. Avoid further drive-by changes at this point, and just
convert the display pointer to i915, and leave the struct intel_display
conversion for later.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdcp.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index 94418f218448..6980b98792c2 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -2181,10 +2181,11 @@ static void intel_hdcp_check_work(struct work_struct *work)
 				   DRM_HDCP_CHECK_PERIOD_MS);
 }
 
-static int i915_hdcp_component_bind(struct device *i915_kdev,
+static int i915_hdcp_component_bind(struct device *drv_kdev,
 				    struct device *mei_kdev, void *data)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
+	struct intel_display *display = to_intel_display(drv_kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 
 	drm_dbg(&i915->drm, "I915 HDCP comp bind\n");
 	mutex_lock(&i915->display.hdcp.hdcp_mutex);
@@ -2195,10 +2196,11 @@ static int i915_hdcp_component_bind(struct device *i915_kdev,
 	return 0;
 }
 
-static void i915_hdcp_component_unbind(struct device *i915_kdev,
+static void i915_hdcp_component_unbind(struct device *drv_kdev,
 				       struct device *mei_kdev, void *data)
 {
-	struct drm_i915_private *i915 = kdev_to_i915(i915_kdev);
+	struct intel_display *display = to_intel_display(drv_kdev);
+	struct drm_i915_private *i915 = to_i915(display->drm);
 
 	drm_dbg(&i915->drm, "I915 HDCP comp unbind\n");
 	mutex_lock(&i915->display.hdcp.hdcp_mutex);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (3 preceding siblings ...)
  2024-08-29 14:47 ` [PATCH v2 4/6] drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-09-02  8:47   ` Nautiyal, Ankit K
                     ` (3 more replies)
  2024-08-29 14:47 ` [PATCH v2 6/6] drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915() Jani Nikula
                   ` (4 subsequent siblings)
  9 siblings, 4 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

Use to_intel_display() instead of kdev_to_i915() in the HDCP component
API hooks. Avoid further drive-by changes at this point, and just
convert the display pointer to i915, and leave the struct intel_display
conversion for later.

The NULL error checking in the hooks make this a bit cumbersome. I'm not
actually sure they're really required, but don't go down that rabbit
hole just now.

Cc: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
 1 file changed, 45 insertions(+), 22 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
index 6548e71b4c49..35bdb532bbb3 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
@@ -7,6 +7,7 @@
 #include <drm/intel/i915_hdcp_interface.h>
 
 #include "i915_drv.h"
+#include "intel_display_types.h"
 #include "intel_hdcp_gsc_message.h"
 
 int
@@ -15,17 +16,19 @@ intel_hdcp_gsc_initiate_session(struct device *dev, struct hdcp_port_data *data,
 {
 	struct wired_cmd_initiate_hdcp2_session_in session_init_in = {};
 	struct wired_cmd_initiate_hdcp2_session_out session_init_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !ake_data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	session_init_in.header.api_version = HDCP_API_VERSION;
 	session_init_in.header.command_id = WIRED_INITIATE_HDCP2_SESSION;
@@ -72,17 +75,19 @@ intel_hdcp_gsc_verify_receiver_cert_prepare_km(struct device *dev,
 {
 	struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = {};
 	struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km || !msg_sz)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	verify_rxcert_in.header.api_version = HDCP_API_VERSION;
 	verify_rxcert_in.header.command_id = WIRED_VERIFY_RECEIVER_CERT;
@@ -135,17 +140,19 @@ intel_hdcp_gsc_verify_hprime(struct device *dev, struct hdcp_port_data *data,
 {
 	struct wired_cmd_ake_send_hprime_in send_hprime_in = {};
 	struct wired_cmd_ake_send_hprime_out send_hprime_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !rx_hprime)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	send_hprime_in.header.api_version = HDCP_API_VERSION;
 	send_hprime_in.header.command_id = WIRED_AKE_SEND_HPRIME;
@@ -183,17 +190,19 @@ intel_hdcp_gsc_store_pairing_info(struct device *dev, struct hdcp_port_data *dat
 {
 	struct wired_cmd_ake_send_pairing_info_in pairing_info_in = {};
 	struct wired_cmd_ake_send_pairing_info_out pairing_info_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !pairing_info)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	pairing_info_in.header.api_version = HDCP_API_VERSION;
 	pairing_info_in.header.command_id = WIRED_AKE_SEND_PAIRING_INFO;
@@ -234,17 +243,19 @@ intel_hdcp_gsc_initiate_locality_check(struct device *dev,
 {
 	struct wired_cmd_init_locality_check_in lc_init_in = {};
 	struct wired_cmd_init_locality_check_out lc_init_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !lc_init_data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	lc_init_in.header.api_version = HDCP_API_VERSION;
 	lc_init_in.header.command_id = WIRED_INIT_LOCALITY_CHECK;
@@ -280,17 +291,19 @@ intel_hdcp_gsc_verify_lprime(struct device *dev, struct hdcp_port_data *data,
 {
 	struct wired_cmd_validate_locality_in verify_lprime_in = {};
 	struct wired_cmd_validate_locality_out verify_lprime_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !rx_lprime)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	verify_lprime_in.header.api_version = HDCP_API_VERSION;
 	verify_lprime_in.header.command_id = WIRED_VALIDATE_LOCALITY;
@@ -330,17 +343,19 @@ int intel_hdcp_gsc_get_session_key(struct device *dev,
 {
 	struct wired_cmd_get_session_key_in get_skey_in = {};
 	struct wired_cmd_get_session_key_out get_skey_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data || !ske_data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	get_skey_in.header.api_version = HDCP_API_VERSION;
 	get_skey_in.header.command_id = WIRED_GET_SESSION_KEY;
@@ -382,17 +397,19 @@ intel_hdcp_gsc_repeater_check_flow_prepare_ack(struct device *dev,
 {
 	struct wired_cmd_verify_repeater_in verify_repeater_in = {};
 	struct wired_cmd_verify_repeater_out verify_repeater_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !rep_topology || !rep_send_ack || !data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	verify_repeater_in.header.api_version = HDCP_API_VERSION;
 	verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
@@ -442,6 +459,7 @@ int intel_hdcp_gsc_verify_mprime(struct device *dev,
 {
 	struct wired_cmd_repeater_auth_stream_req_in *verify_mprime_in;
 	struct wired_cmd_repeater_auth_stream_req_out verify_mprime_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 	size_t cmd_size;
@@ -449,11 +467,12 @@ int intel_hdcp_gsc_verify_mprime(struct device *dev,
 	if (!dev || !stream_ready || !data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	cmd_size = struct_size(verify_mprime_in, streams, data->k);
 	if (cmd_size == SIZE_MAX)
@@ -504,17 +523,19 @@ int intel_hdcp_gsc_enable_authentication(struct device *dev,
 {
 	struct wired_cmd_enable_auth_in enable_auth_in = {};
 	struct wired_cmd_enable_auth_out enable_auth_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	enable_auth_in.header.api_version = HDCP_API_VERSION;
 	enable_auth_in.header.command_id = WIRED_ENABLE_AUTH;
@@ -549,17 +570,19 @@ intel_hdcp_gsc_close_session(struct device *dev, struct hdcp_port_data *data)
 {
 	struct wired_cmd_close_session_in session_close_in = {};
 	struct wired_cmd_close_session_out session_close_out = {};
+	struct intel_display *display;
 	struct drm_i915_private *i915;
 	ssize_t byte;
 
 	if (!dev || !data)
 		return -EINVAL;
 
-	i915 = kdev_to_i915(dev);
-	if (!i915) {
+	display = to_intel_display(dev);
+	if (!display) {
 		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
 		return -ENODEV;
 	}
+	i915 = to_i915(display->drm);
 
 	session_close_in.header.api_version = HDCP_API_VERSION;
 	session_close_in.header.command_id = WIRED_CLOSE_SESSION;
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v2 6/6] drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915()
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (4 preceding siblings ...)
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
@ 2024-08-29 14:47 ` Jani Nikula
  2024-08-29 15:42 ` ✗ Fi.CI.SPARSE: warning for drm/xe & drm/i915: drvdata usage changes follow-up Patchwork
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-08-29 14:47 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: jani.nikula, rodrigo.vivi, lucas.demarchi, Gustavo Sousa

The display code no longer uses kdev_to_i915() or pdev_to_i915()
helpers. Remove them.

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
index becb6a7ec9d7..cd4994ff7503 100644
--- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
+++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
@@ -21,13 +21,6 @@ static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
 	return container_of(dev, struct drm_i915_private, drm);
 }
 
-static inline struct drm_i915_private *kdev_to_i915(struct device *kdev)
-{
-	struct drm_device *drm = dev_get_drvdata(kdev);
-
-	return drm ? to_i915(drm) : NULL;
-}
-
 #define IS_PLATFORM(xe, x) ((xe)->info.platform == x)
 #define INTEL_INFO(dev_priv)	(&((dev_priv)->info))
 #define IS_I830(dev_priv)	(dev_priv && 0)
@@ -112,8 +105,6 @@ struct i915_sched_attr {
 };
 #define i915_gem_fence_wait_priority(fence, attr) do { (void) attr; } while (0)
 
-#define pdev_to_i915 pdev_to_xe_device
-
 #define FORCEWAKE_ALL XE_FORCEWAKE_ALL
 
 #ifdef CONFIG_ARM64
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* ✗ Fi.CI.SPARSE: warning for drm/xe & drm/i915: drvdata usage changes follow-up
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (5 preceding siblings ...)
  2024-08-29 14:47 ` [PATCH v2 6/6] drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915() Jani Nikula
@ 2024-08-29 15:42 ` Patchwork
  2024-08-29 15:50 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2024-08-29 15:42 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

== Series Details ==

Series: drm/xe & drm/i915: drvdata usage changes follow-up
URL   : https://patchwork.freedesktop.org/series/137967/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.



^ permalink raw reply	[flat|nested] 15+ messages in thread

* ✓ Fi.CI.BAT: success for drm/xe & drm/i915: drvdata usage changes follow-up
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (6 preceding siblings ...)
  2024-08-29 15:42 ` ✗ Fi.CI.SPARSE: warning for drm/xe & drm/i915: drvdata usage changes follow-up Patchwork
@ 2024-08-29 15:50 ` Patchwork
  2024-08-31  0:09 ` ✗ Fi.CI.IGT: failure " Patchwork
  2024-09-02 12:20 ` [PATCH v2 0/6] " Jani Nikula
  9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2024-08-29 15:50 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 8731 bytes --]

== Series Details ==

Series: drm/xe & drm/i915: drvdata usage changes follow-up
URL   : https://patchwork.freedesktop.org/series/137967/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_15323 -> Patchwork_137967v1
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/index.html

Participating hosts (38 -> 38)
------------------------------

  Additional (2): bat-kbl-2 bat-arlh-2 
  Missing    (2): bat-dg1-7 fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_137967v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-arlh-2:         NOTRUN -> [SKIP][1] ([i915#9318])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@debugfs_test@basic-hwmon.html

  * igt@fbdev@eof:
    - bat-arlh-2:         NOTRUN -> [SKIP][2] ([i915#11345]) +3 other tests skip
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@fbdev@eof.html

  * igt@fbdev@info:
    - bat-arlh-2:         NOTRUN -> [SKIP][3] ([i915#1849])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@fbdev@info.html
    - bat-kbl-2:          NOTRUN -> [SKIP][4] ([i915#1849])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-kbl-2/igt@fbdev@info.html

  * igt@fbdev@read:
    - bat-arls-1:         [PASS][5] -> [DMESG-WARN][6] ([i915#9157])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/bat-arls-1/igt@fbdev@read.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arls-1/igt@fbdev@read.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-kbl-2:          NOTRUN -> [SKIP][7] +39 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html
    - bat-arlh-2:         NOTRUN -> [SKIP][8] ([i915#10213] / [i915#11671]) +3 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_mmap@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][9] ([i915#11343])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@gem_mmap@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][10] ([i915#10197] / [i915#11725])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_fence_blits@basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][11] ([i915#10196]) +4 other tests skip
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@gem_tiled_fence_blits@basic.html

  * igt@gem_tiled_pread_basic:
    - bat-arlh-2:         NOTRUN -> [SKIP][12] ([i915#10206] / [i915#11724])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-arlh-2:         NOTRUN -> [SKIP][13] ([i915#10209] / [i915#11681])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-2:         NOTRUN -> [ABORT][14] ([i915#12061])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@i915_selftest@live@workarounds.html

  * igt@kms_addfb_basic@basic-x-tiled-legacy:
    - bat-arlh-2:         NOTRUN -> [SKIP][15] ([i915#10200] / [i915#11666]) +9 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@kms_addfb_basic@basic-x-tiled-legacy.html

  * igt@kms_pm_backlight@basic-brightness:
    - bat-arlh-2:         NOTRUN -> [SKIP][16] ([i915#11346]) +32 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-arlh-2:         NOTRUN -> [SKIP][17] ([i915#10208] / [i915#8809])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][18] ([i915#10212] / [i915#11726])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-read:
    - bat-arlh-2:         NOTRUN -> [SKIP][19] ([i915#10214] / [i915#11726])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-write:
    - bat-arlh-2:         NOTRUN -> [SKIP][20] ([i915#10216] / [i915#11723])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-2/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@fbdev@eof:
    - bat-arls-1:         [DMESG-WARN][21] ([i915#9157]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/bat-arls-1/igt@fbdev@eof.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arls-1/igt@fbdev@eof.html

  * igt@i915_selftest@live@hangcheck:
    - bat-arls-2:         [DMESG-WARN][23] ([i915#11349]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/bat-arls-2/igt@i915_selftest@live@hangcheck.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arls-2/igt@i915_selftest@live@hangcheck.html

  * igt@vgem_basic@unload:
    - {bat-arlh-3}:       [INCOMPLETE][25] ([i915#10420]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/bat-arlh-3/igt@vgem_basic@unload.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/bat-arlh-3/igt@vgem_basic@unload.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#10196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10196
  [i915#10197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10197
  [i915#10200]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10200
  [i915#10206]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10206
  [i915#10208]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10208
  [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209
  [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212
  [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213
  [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214
  [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216
  [i915#10420]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10420
  [i915#11343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11343
  [i915#11345]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11345
  [i915#11346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11346
  [i915#11349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11349
  [i915#11666]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11666
  [i915#11671]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11671
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#11723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11723
  [i915#11724]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11724
  [i915#11725]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11725
  [i915#11726]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11726
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
  [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809
  [i915#9157]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9157
  [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318


Build changes
-------------

  * Linux: CI_DRM_15323 -> Patchwork_137967v1

  CI-20190529: 20190529
  CI_DRM_15323: 7ae5f4b6787d6b8a0ca1ab1f3a71d5bb71783fe2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7997: c70810080fa12a37859c45f16445797c5d849d4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_137967v1: 7ae5f4b6787d6b8a0ca1ab1f3a71d5bb71783fe2 @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/index.html

[-- Attachment #2: Type: text/html, Size: 10043 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* ✗ Fi.CI.IGT: failure for drm/xe & drm/i915: drvdata usage changes follow-up
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (7 preceding siblings ...)
  2024-08-29 15:50 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2024-08-31  0:09 ` Patchwork
  2024-09-02 12:20 ` [PATCH v2 0/6] " Jani Nikula
  9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2024-08-31  0:09 UTC (permalink / raw)
  To: Jani Nikula; +Cc: intel-gfx

[-- Attachment #1: Type: text/plain, Size: 78372 bytes --]

== Series Details ==

Series: drm/xe & drm/i915: drvdata usage changes follow-up
URL   : https://patchwork.freedesktop.org/series/137967/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15323_full -> Patchwork_137967v1_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_137967v1_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_137967v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (10 -> 9)
------------------------------

  Missing    (1): shard-snb-0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_137967v1_full:

### IGT changes ###

#### Possible regressions ####

  * igt@gem_ctx_isolation@preservation-s3@rcs0:
    - shard-tglu:         [PASS][1] -> [ABORT][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-3/igt@gem_ctx_isolation@preservation-s3@rcs0.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-3/igt@gem_ctx_isolation@preservation-s3@rcs0.html

  * igt@gem_flink_race@flink_close:
    - shard-mtlp:         NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_flink_race@flink_close.html

  * igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-vga-1:
    - shard-snb:          NOTRUN -> [FAIL][4] +3 other tests fail
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@kms_display_modes@extended-mode-basic@pipe-a-hdmi-a-1-pipe-b-vga-1.html

  
Known issues
------------

  Here are the changes found in Patchwork_137967v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@api_intel_bb@object-reloc-keep-cache:
    - shard-dg1:          NOTRUN -> [SKIP][5] ([i915#8411])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@api_intel_bb@object-reloc-keep-cache.html

  * igt@api_intel_bb@object-reloc-purge-cache:
    - shard-dg2:          NOTRUN -> [SKIP][6] ([i915#8411])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@api_intel_bb@object-reloc-purge-cache.html

  * igt@drm_fdinfo@busy-idle-check-all@vcs1:
    - shard-dg1:          NOTRUN -> [SKIP][7] ([i915#8414]) +6 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@drm_fdinfo@busy-idle-check-all@vcs1.html

  * igt@drm_fdinfo@isolation@rcs0:
    - shard-mtlp:         NOTRUN -> [SKIP][8] ([i915#8414]) +5 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@drm_fdinfo@isolation@rcs0.html

  * igt@drm_fdinfo@most-busy-check-all@rcs0:
    - shard-rkl:          [PASS][9] -> [FAIL][10] ([i915#7742])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-3/igt@drm_fdinfo@most-busy-check-all@rcs0.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html

  * igt@drm_fdinfo@virtual-busy-hang:
    - shard-dg2:          NOTRUN -> [SKIP][11] ([i915#8414])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@drm_fdinfo@virtual-busy-hang.html

  * igt@drm_fdinfo@virtual-idle:
    - shard-rkl:          [PASS][12] -> [FAIL][13] ([i915#11900] / [i915#7742])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-5/igt@drm_fdinfo@virtual-idle.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@drm_fdinfo@virtual-idle.html

  * igt@gem_basic@multigpu-create-close:
    - shard-rkl:          NOTRUN -> [SKIP][14] ([i915#7697]) +1 other test skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_basic@multigpu-create-close.html

  * igt@gem_busy@semaphore:
    - shard-dg2:          NOTRUN -> [SKIP][15] ([i915#3936])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gem_busy@semaphore.html

  * igt@gem_ccs@block-multicopy-inplace:
    - shard-rkl:          NOTRUN -> [SKIP][16] ([i915#3555] / [i915#9323])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@gem_ccs@block-multicopy-inplace.html
    - shard-dg1:          NOTRUN -> [SKIP][17] ([i915#3555] / [i915#9323])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_ccs@block-multicopy-inplace.html

  * igt@gem_ccs@ctrl-surf-copy-new-ctx:
    - shard-dg1:          NOTRUN -> [SKIP][18] ([i915#9323])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@gem_ccs@ctrl-surf-copy-new-ctx.html

  * igt@gem_create@create-ext-set-pat:
    - shard-dg1:          NOTRUN -> [SKIP][19] ([i915#8562])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_create@create-ext-set-pat.html

  * igt@gem_ctx_engines@invalid-engines:
    - shard-rkl:          [PASS][20] -> [FAIL][21] ([i915#12027])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-3/igt@gem_ctx_engines@invalid-engines.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@gem_ctx_engines@invalid-engines.html
    - shard-glk:          [PASS][22] -> [FAIL][23] ([i915#12027])
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-glk8/igt@gem_ctx_engines@invalid-engines.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk6/igt@gem_ctx_engines@invalid-engines.html

  * igt@gem_ctx_persistence@hang:
    - shard-snb:          NOTRUN -> [SKIP][24] ([i915#1099])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@gem_ctx_persistence@hang.html

  * igt@gem_ctx_persistence@heartbeat-many:
    - shard-dg1:          NOTRUN -> [SKIP][25] ([i915#8555])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_ctx_persistence@heartbeat-many.html

  * igt@gem_ctx_persistence@saturated-hostile-nopreempt@vcs0:
    - shard-mtlp:         NOTRUN -> [SKIP][26] ([i915#5882]) +5 other tests skip
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_ctx_persistence@saturated-hostile-nopreempt@vcs0.html

  * igt@gem_ctx_sseu@invalid-args:
    - shard-rkl:          NOTRUN -> [SKIP][27] ([i915#280])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_ctx_sseu@invalid-args.html

  * igt@gem_eio@reset-stress:
    - shard-dg1:          [PASS][28] -> [FAIL][29] ([i915#5784])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg1-16/igt@gem_eio@reset-stress.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_eio@reset-stress.html

  * igt@gem_eio@unwedge-stress:
    - shard-dg2:          [PASS][30] -> [FAIL][31] ([i915#5784])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-5/igt@gem_eio@unwedge-stress.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-10/igt@gem_eio@unwedge-stress.html

  * igt@gem_exec_balancer@parallel-bb-first:
    - shard-rkl:          NOTRUN -> [SKIP][32] ([i915#4525])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_exec_balancer@parallel-bb-first.html

  * igt@gem_exec_balancer@sliced:
    - shard-dg2:          NOTRUN -> [SKIP][33] ([i915#4812]) +1 other test skip
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_exec_balancer@sliced.html

  * igt@gem_exec_capture@capture-invisible@smem0:
    - shard-rkl:          NOTRUN -> [SKIP][34] ([i915#6334])
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_exec_capture@capture-invisible@smem0.html

  * igt@gem_exec_endless@dispatch@bcs0:
    - shard-dg2:          [PASS][35] -> [TIMEOUT][36] ([i915#3778] / [i915#7016])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-4/igt@gem_exec_endless@dispatch@bcs0.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@gem_exec_endless@dispatch@bcs0.html

  * igt@gem_exec_fair@basic-flow:
    - shard-dg2:          NOTRUN -> [SKIP][37] ([i915#3539] / [i915#4852])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gem_exec_fair@basic-flow.html

  * igt@gem_exec_fair@basic-none-vip@rcs0:
    - shard-rkl:          NOTRUN -> [FAIL][38] ([i915#2842])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_exec_fair@basic-none-vip@rcs0.html
    - shard-glk:          NOTRUN -> [FAIL][39] ([i915#2842])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk9/igt@gem_exec_fair@basic-none-vip@rcs0.html

  * igt@gem_exec_fair@basic-pace-solo@rcs0:
    - shard-rkl:          [PASS][40] -> [FAIL][41] ([i915#2842]) +1 other test fail
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@gem_exec_fair@basic-pace-solo@rcs0.html

  * igt@gem_exec_fair@basic-throttle:
    - shard-dg1:          NOTRUN -> [SKIP][42] ([i915#3539])
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_exec_fair@basic-throttle.html

  * igt@gem_exec_flush@basic-batch-kernel-default-wb:
    - shard-dg1:          NOTRUN -> [SKIP][43] ([i915#3539] / [i915#4852]) +1 other test skip
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_exec_flush@basic-batch-kernel-default-wb.html

  * igt@gem_exec_reloc@basic-concurrent0:
    - shard-dg1:          NOTRUN -> [SKIP][44] ([i915#3281]) +9 other tests skip
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_exec_reloc@basic-concurrent0.html

  * igt@gem_exec_reloc@basic-cpu-read:
    - shard-dg2:          NOTRUN -> [SKIP][45] ([i915#3281]) +1 other test skip
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_exec_reloc@basic-cpu-read.html

  * igt@gem_exec_reloc@basic-cpu-wc-active:
    - shard-mtlp:         NOTRUN -> [SKIP][46] ([i915#3281]) +1 other test skip
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_exec_reloc@basic-cpu-wc-active.html

  * igt@gem_exec_reloc@basic-wc-read-noreloc:
    - shard-rkl:          NOTRUN -> [SKIP][47] ([i915#3281]) +6 other tests skip
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_exec_reloc@basic-wc-read-noreloc.html

  * igt@gem_exec_schedule@preempt-queue-chain:
    - shard-dg1:          NOTRUN -> [SKIP][48] ([i915#4812])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_exec_schedule@preempt-queue-chain.html

  * igt@gem_exec_schedule@reorder-wide:
    - shard-dg2:          NOTRUN -> [SKIP][49] ([i915#4537] / [i915#4812]) +1 other test skip
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_exec_schedule@reorder-wide.html

  * igt@gem_fence_thrash@bo-write-verify-y:
    - shard-dg1:          NOTRUN -> [SKIP][50] ([i915#4860]) +1 other test skip
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@gem_fence_thrash@bo-write-verify-y.html

  * igt@gem_fenced_exec_thrash@2-spare-fences:
    - shard-dg2:          NOTRUN -> [SKIP][51] ([i915#4860]) +1 other test skip
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_fenced_exec_thrash@2-spare-fences.html

  * igt@gem_lmem_swapping@heavy-multi:
    - shard-rkl:          NOTRUN -> [SKIP][52] ([i915#4613]) +2 other tests skip
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_lmem_swapping@heavy-multi.html

  * igt@gem_lmem_swapping@parallel-random-verify:
    - shard-glk:          NOTRUN -> [SKIP][53] ([i915#4613]) +2 other tests skip
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk8/igt@gem_lmem_swapping@parallel-random-verify.html

  * igt@gem_lmem_swapping@random-engines:
    - shard-tglu:         NOTRUN -> [SKIP][54] ([i915#4613])
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@gem_lmem_swapping@random-engines.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - shard-dg1:          NOTRUN -> [TIMEOUT][55] ([i915#5493])
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gem_media_fill@media-fill:
    - shard-dg2:          NOTRUN -> [SKIP][56] ([i915#8289])
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gem_media_fill@media-fill.html

  * igt@gem_mmap_gtt@basic-read:
    - shard-dg2:          NOTRUN -> [SKIP][57] ([i915#4077]) +5 other tests skip
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_mmap_gtt@basic-read.html

  * igt@gem_mmap_gtt@close-race:
    - shard-dg1:          NOTRUN -> [SKIP][58] ([i915#4077]) +7 other tests skip
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@gem_mmap_gtt@close-race.html

  * igt@gem_mmap_wc@write-prefaulted:
    - shard-dg2:          NOTRUN -> [SKIP][59] ([i915#4083]) +3 other tests skip
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gem_mmap_wc@write-prefaulted.html

  * igt@gem_mmap_wc@write-read:
    - shard-dg1:          NOTRUN -> [SKIP][60] ([i915#4083]) +2 other tests skip
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_mmap_wc@write-read.html

  * igt@gem_partial_pwrite_pread@write:
    - shard-dg1:          NOTRUN -> [SKIP][61] ([i915#3282]) +1 other test skip
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@gem_partial_pwrite_pread@write.html

  * igt@gem_pwrite@basic-exhaustion:
    - shard-dg2:          NOTRUN -> [SKIP][62] ([i915#3282]) +1 other test skip
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_pwrite@basic-exhaustion.html

  * igt@gem_pxp@create-protected-buffer:
    - shard-rkl:          NOTRUN -> [SKIP][63] ([i915#4270]) +3 other tests skip
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_pxp@create-protected-buffer.html

  * igt@gem_pxp@display-protected-crc:
    - shard-dg2:          NOTRUN -> [SKIP][64] ([i915#4270])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_pxp@display-protected-crc.html

  * igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:
    - shard-mtlp:         NOTRUN -> [SKIP][65] ([i915#4270])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted.html

  * igt@gem_pxp@reject-modify-context-protection-off-3:
    - shard-dg1:          NOTRUN -> [SKIP][66] ([i915#4270]) +1 other test skip
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_pxp@reject-modify-context-protection-off-3.html

  * igt@gem_readwrite@new-obj:
    - shard-mtlp:         NOTRUN -> [SKIP][67] ([i915#3282])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_readwrite@new-obj.html

  * igt@gem_render_copy@y-tiled-ccs-to-y-tiled:
    - shard-dg2:          NOTRUN -> [SKIP][68] ([i915#5190] / [i915#8428]) +3 other tests skip
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_render_copy@y-tiled-ccs-to-y-tiled.html

  * igt@gem_render_copy@yf-tiled-ccs-to-x-tiled:
    - shard-mtlp:         NOTRUN -> [SKIP][69] ([i915#8428])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_render_copy@yf-tiled-ccs-to-x-tiled.html

  * igt@gem_set_tiling_vs_pwrite:
    - shard-rkl:          NOTRUN -> [SKIP][70] ([i915#3282]) +2 other tests skip
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@gem_set_tiling_vs_pwrite.html
    - shard-dg1:          NOTRUN -> [SKIP][71] ([i915#4079])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@gem_set_tiling_vs_pwrite.html

  * igt@gem_softpin@evict-snoop-interruptible:
    - shard-mtlp:         NOTRUN -> [SKIP][72] ([i915#4885])
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_softpin@evict-snoop-interruptible.html

  * igt@gem_tiled_wb:
    - shard-mtlp:         NOTRUN -> [SKIP][73] ([i915#4077]) +2 other tests skip
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_tiled_wb.html

  * igt@gem_unfence_active_buffers:
    - shard-dg2:          NOTRUN -> [SKIP][74] ([i915#4879])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@gem_unfence_active_buffers.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-rkl:          NOTRUN -> [SKIP][75] ([i915#3297])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
    - shard-mtlp:         NOTRUN -> [SKIP][76] ([i915#3297])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html

  * igt@gem_userptr_blits@readonly-pwrite-unsync:
    - shard-dg2:          NOTRUN -> [SKIP][77] ([i915#3297])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gem_userptr_blits@readonly-pwrite-unsync.html

  * igt@gem_userptr_blits@readonly-unsync:
    - shard-dg1:          NOTRUN -> [SKIP][78] ([i915#3297])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@gem_userptr_blits@readonly-unsync.html

  * igt@gem_userptr_blits@relocations:
    - shard-dg1:          NOTRUN -> [SKIP][79] ([i915#3281] / [i915#3297])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gem_userptr_blits@relocations.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-dg2:          NOTRUN -> [SKIP][80] ([i915#2856]) +1 other test skip
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@gen9_exec_parse@allowed-single.html

  * igt@gen9_exec_parse@batch-without-end:
    - shard-dg1:          NOTRUN -> [SKIP][81] ([i915#2527])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@gen9_exec_parse@batch-without-end.html

  * igt@gen9_exec_parse@bb-start-out:
    - shard-mtlp:         NOTRUN -> [SKIP][82] ([i915#2856])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@gen9_exec_parse@bb-start-out.html

  * igt@gen9_exec_parse@unaligned-access:
    - shard-rkl:          NOTRUN -> [SKIP][83] ([i915#2527]) +1 other test skip
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gen9_exec_parse@unaligned-access.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-tglu:         NOTRUN -> [ABORT][84] ([i915#9820])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@i915_module_load@reload-with-fault-injection.html
    - shard-dg2:          [PASS][85] -> [ABORT][86] ([i915#9820])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-5/igt@i915_module_load@reload-with-fault-injection.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-10/igt@i915_module_load@reload-with-fault-injection.html

  * igt@i915_pm_freq_api@freq-reset-multiple:
    - shard-rkl:          NOTRUN -> [SKIP][87] ([i915#8399])
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@i915_pm_freq_api@freq-reset-multiple.html

  * igt@i915_pm_rps@min-max-config-loaded:
    - shard-dg2:          NOTRUN -> [SKIP][88] ([i915#11681] / [i915#6621])
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@i915_pm_rps@min-max-config-loaded.html

  * igt@i915_pm_rps@reset:
    - shard-snb:          [PASS][89] -> [INCOMPLETE][90] ([i915#7790])
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb6/igt@i915_pm_rps@reset.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@i915_pm_rps@reset.html

  * igt@i915_pm_rps@thresholds-idle-park:
    - shard-dg1:          NOTRUN -> [SKIP][91] ([i915#11681])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@i915_pm_rps@thresholds-idle-park.html

  * igt@i915_pm_sseu@full-enable:
    - shard-mtlp:         NOTRUN -> [SKIP][92] ([i915#8437])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@i915_pm_sseu@full-enable.html

  * igt@i915_query@test-query-geometry-subslices:
    - shard-rkl:          NOTRUN -> [SKIP][93] ([i915#5723])
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@i915_query@test-query-geometry-subslices.html

  * igt@kms_addfb_basic@bo-too-small-due-to-tiling:
    - shard-dg1:          NOTRUN -> [SKIP][94] ([i915#4212]) +2 other tests skip
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_addfb_basic@bo-too-small-due-to-tiling.html

  * igt@kms_atomic@plane-primary-overlay-mutable-zpos:
    - shard-rkl:          NOTRUN -> [SKIP][95] ([i915#9531])
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
    - shard-dg2:          NOTRUN -> [SKIP][96] ([i915#1769] / [i915#3555])
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html

  * igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1:
    - shard-snb:          [PASS][97] -> [FAIL][98] ([i915#5956])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb4/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb5/igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-1.html

  * igt@kms_big_fb@4-tiled-16bpp-rotate-0:
    - shard-rkl:          NOTRUN -> [SKIP][99] ([i915#5286]) +4 other tests skip
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_big_fb@4-tiled-16bpp-rotate-0.html

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
    - shard-dg1:          NOTRUN -> [SKIP][100] ([i915#4538] / [i915#5286]) +4 other tests skip
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

  * igt@kms_big_fb@linear-64bpp-rotate-90:
    - shard-rkl:          NOTRUN -> [SKIP][101] ([i915#3638]) +1 other test skip
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_big_fb@linear-64bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-64bpp-rotate-90:
    - shard-dg1:          NOTRUN -> [SKIP][102] ([i915#3638]) +2 other tests skip
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_big_fb@y-tiled-64bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
    - shard-dg1:          NOTRUN -> [SKIP][103] ([i915#4538]) +2 other tests skip
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_big_fb@yf-tiled-16bpp-rotate-270.html

  * igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
    - shard-dg2:          NOTRUN -> [SKIP][104] ([i915#4538] / [i915#5190]) +5 other tests skip
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html

  * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
    - shard-mtlp:         NOTRUN -> [SKIP][105] +3 other tests skip
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

  * igt@kms_big_joiner@basic-force-joiner:
    - shard-dg1:          NOTRUN -> [SKIP][106] ([i915#10656])
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_big_joiner@basic-force-joiner.html

  * igt@kms_big_joiner@invalid-modeset-force-joiner:
    - shard-rkl:          NOTRUN -> [SKIP][107] ([i915#10656])
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_big_joiner@invalid-modeset-force-joiner.html

  * igt@kms_ccs@bad-aux-stride-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][108] ([i915#6095]) +11 other tests skip
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_ccs@bad-aux-stride-4-tiled-mtl-mc-ccs@pipe-a-hdmi-a-2.html

  * igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-a-edp-1:
    - shard-mtlp:         NOTRUN -> [SKIP][109] ([i915#6095]) +7 other tests skip
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-a-edp-1.html

  * igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][110] ([i915#10307] / [i915#10434] / [i915#6095]) +4 other tests skip
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_ccs@bad-rotation-90-y-tiled-gen12-rc-ccs@pipe-d-hdmi-a-1.html

  * igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][111] ([i915#10307] / [i915#6095]) +122 other tests skip
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-b-hdmi-a-1.html

  * igt@kms_ccs@crc-primary-basic-4-tiled-bmg-ccs:
    - shard-dg2:          NOTRUN -> [SKIP][112] ([i915#12042])
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_ccs@crc-primary-basic-4-tiled-bmg-ccs.html

  * igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs:
    - shard-mtlp:         NOTRUN -> [SKIP][113] ([i915#12042])
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_ccs@crc-primary-rotation-180-4-tiled-bmg-ccs.html

  * igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-mc-ccs@pipe-c-hdmi-a-2:
    - shard-glk:          NOTRUN -> [SKIP][114] +100 other tests skip
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk8/igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-mc-ccs@pipe-c-hdmi-a-2.html

  * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
    - shard-dg1:          NOTRUN -> [SKIP][115] ([i915#12042]) +1 other test skip
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs.html

  * igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs:
    - shard-rkl:          NOTRUN -> [SKIP][116] ([i915#12042]) +1 other test skip
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs.html

  * igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-3:
    - shard-dg1:          NOTRUN -> [SKIP][117] ([i915#6095]) +55 other tests skip
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-13/igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs@pipe-b-hdmi-a-3.html

  * igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][118] ([i915#11616] / [i915#7213]) +3 other tests skip
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1.html

  * igt@kms_cdclk@plane-scaling:
    - shard-dg1:          NOTRUN -> [SKIP][119] ([i915#3742])
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_cdclk@plane-scaling.html

  * igt@kms_chamelium_frames@dp-crc-single:
    - shard-dg1:          NOTRUN -> [SKIP][120] ([i915#7828]) +6 other tests skip
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_chamelium_frames@dp-crc-single.html

  * igt@kms_chamelium_frames@hdmi-cmp-planar-formats:
    - shard-tglu:         NOTRUN -> [SKIP][121] ([i915#7828])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@kms_chamelium_frames@hdmi-cmp-planar-formats.html

  * igt@kms_chamelium_frames@hdmi-crc-single:
    - shard-rkl:          NOTRUN -> [SKIP][122] ([i915#7828]) +5 other tests skip
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_chamelium_frames@hdmi-crc-single.html

  * igt@kms_chamelium_hpd@dp-hpd-storm-disable:
    - shard-mtlp:         NOTRUN -> [SKIP][123] ([i915#7828]) +1 other test skip
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html

  * igt@kms_chamelium_hpd@vga-hpd-after-suspend:
    - shard-dg2:          NOTRUN -> [SKIP][124] ([i915#7828]) +3 other tests skip
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_chamelium_hpd@vga-hpd-after-suspend.html

  * igt@kms_content_protection@atomic-dpms:
    - shard-dg2:          NOTRUN -> [SKIP][125] ([i915#7118] / [i915#9424]) +1 other test skip
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_content_protection@atomic-dpms.html

  * igt@kms_content_protection@dp-mst-lic-type-0:
    - shard-rkl:          NOTRUN -> [SKIP][126] ([i915#3116])
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_content_protection@dp-mst-lic-type-0.html
    - shard-dg1:          NOTRUN -> [SKIP][127] ([i915#3299])
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_content_protection@dp-mst-lic-type-0.html

  * igt@kms_content_protection@dp-mst-lic-type-1:
    - shard-dg2:          NOTRUN -> [SKIP][128] ([i915#3299])
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_content_protection@dp-mst-lic-type-1.html

  * igt@kms_content_protection@lic-type-1:
    - shard-rkl:          NOTRUN -> [SKIP][129] ([i915#9424])
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_content_protection@lic-type-1.html

  * igt@kms_content_protection@srm:
    - shard-dg2:          NOTRUN -> [SKIP][130] ([i915#7118])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-8/igt@kms_content_protection@srm.html

  * igt@kms_content_protection@uevent:
    - shard-rkl:          NOTRUN -> [SKIP][131] ([i915#7118] / [i915#9424])
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_content_protection@uevent.html

  * igt@kms_cursor_crc@cursor-offscreen-32x10:
    - shard-mtlp:         NOTRUN -> [SKIP][132] ([i915#3555] / [i915#8814])
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_cursor_crc@cursor-offscreen-32x10.html

  * igt@kms_cursor_crc@cursor-rapid-movement-128x42:
    - shard-mtlp:         NOTRUN -> [SKIP][133] ([i915#8814])
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_cursor_crc@cursor-rapid-movement-128x42.html

  * igt@kms_cursor_crc@cursor-rapid-movement-max-size:
    - shard-dg2:          NOTRUN -> [SKIP][134] ([i915#3555]) +1 other test skip
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html

  * igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy:
    - shard-rkl:          NOTRUN -> [SKIP][135] +19 other tests skip
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_cursor_legacy@2x-flip-vs-cursor-legacy.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size:
    - shard-mtlp:         NOTRUN -> [SKIP][136] ([i915#9809])
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
    - shard-snb:          [PASS][137] -> [SKIP][138]
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb7/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb6/igt@kms_cursor_legacy@cursora-vs-flipb-toggle.html

  * igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot:
    - shard-rkl:          NOTRUN -> [SKIP][139] ([i915#9067])
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot.html

  * igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
    - shard-dg2:          NOTRUN -> [SKIP][140] ([i915#4103] / [i915#4213])
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@torture-move@all-pipes:
    - shard-tglu:         [PASS][141] -> [DMESG-WARN][142] ([i915#10166])
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-3/igt@kms_cursor_legacy@torture-move@all-pipes.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-3/igt@kms_cursor_legacy@torture-move@all-pipes.html

  * igt@kms_dirtyfb@psr-dirtyfb-ioctl:
    - shard-dg1:          NOTRUN -> [SKIP][143] ([i915#9723])
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_dirtyfb@psr-dirtyfb-ioctl.html

  * igt@kms_dp_aux_dev:
    - shard-rkl:          NOTRUN -> [SKIP][144] ([i915#1257])
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_dp_aux_dev.html
    - shard-dg1:          NOTRUN -> [SKIP][145] ([i915#1257])
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_dp_aux_dev.html

  * igt@kms_dsc@dsc-with-bpc:
    - shard-mtlp:         NOTRUN -> [SKIP][146] ([i915#3555] / [i915#3840])
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_dsc@dsc-with-bpc.html

  * igt@kms_fbcon_fbt@psr-suspend:
    - shard-dg2:          NOTRUN -> [SKIP][147] ([i915#3469])
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_fbcon_fbt@psr-suspend.html

  * igt@kms_feature_discovery@display-4x:
    - shard-rkl:          NOTRUN -> [SKIP][148] ([i915#1839])
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_feature_discovery@display-4x.html

  * igt@kms_feature_discovery@psr1:
    - shard-rkl:          NOTRUN -> [SKIP][149] ([i915#658])
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_feature_discovery@psr1.html

  * igt@kms_fence_pin_leak:
    - shard-mtlp:         NOTRUN -> [SKIP][150] ([i915#4881])
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_fence_pin_leak.html

  * igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
    - shard-mtlp:         NOTRUN -> [SKIP][151] ([i915#3637]) +2 other tests skip
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html

  * igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1:
    - shard-snb:          [PASS][152] -> [FAIL][153] ([i915#10826])
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb6/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1.html
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1.html

  * igt@kms_flip@2x-flip-vs-fences:
    - shard-mtlp:         NOTRUN -> [SKIP][154] ([i915#8381])
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_flip@2x-flip-vs-fences.html

  * igt@kms_flip@2x-flip-vs-panning-vs-hang:
    - shard-dg2:          NOTRUN -> [SKIP][155] +9 other tests skip
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_flip@2x-flip-vs-panning-vs-hang.html

  * igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset:
    - shard-dg1:          NOTRUN -> [SKIP][156] ([i915#9934]) +4 other tests skip
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_flip@2x-single-buffer-flip-vs-dpms-off-vs-modeset.html

  * igt@kms_flip@flip-vs-fences-interruptible:
    - shard-dg1:          NOTRUN -> [SKIP][157] ([i915#8381])
   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_flip@flip-vs-fences-interruptible.html

  * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
    - shard-mtlp:         NOTRUN -> [SKIP][158] ([i915#8810])
   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-valid-mode:
    - shard-dg1:          NOTRUN -> [SKIP][159] ([i915#2587] / [i915#2672]) +1 other test skip
   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-valid-mode:
    - shard-dg2:          NOTRUN -> [SKIP][160] ([i915#2672])
   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode:
    - shard-mtlp:         NOTRUN -> [SKIP][161] ([i915#3555] / [i915#8810])
   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode:
    - shard-rkl:          NOTRUN -> [SKIP][162] ([i915#2672]) +1 other test skip
   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-valid-mode.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - shard-dg2:          NOTRUN -> [SKIP][163] ([i915#5274])
   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
    - shard-dg1:          NOTRUN -> [SKIP][164] +26 other tests skip
   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
    - shard-dg2:          NOTRUN -> [SKIP][165] ([i915#5354]) +13 other tests skip
   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-tiling-4:
    - shard-dg1:          NOTRUN -> [SKIP][166] ([i915#5439]) +1 other test skip
   [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbc-tiling-4.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-wc:
    - shard-rkl:          NOTRUN -> [SKIP][167] ([i915#3023]) +17 other tests skip
   [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
    - shard-tglu:         NOTRUN -> [SKIP][168] +3 other tests skip
   [168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
    - shard-dg1:          NOTRUN -> [SKIP][169] ([i915#8708]) +14 other tests skip
   [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc:
    - shard-dg2:          NOTRUN -> [SKIP][170] ([i915#8708]) +8 other tests skip
   [170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
    - shard-mtlp:         NOTRUN -> [SKIP][171] ([i915#1825]) +7 other tests skip
   [171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt:
    - shard-dg1:          NOTRUN -> [SKIP][172] ([i915#3458]) +12 other tests skip
   [172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt:
    - shard-dg2:          NOTRUN -> [SKIP][173] ([i915#3458]) +9 other tests skip
   [173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt:
    - shard-rkl:          NOTRUN -> [SKIP][174] ([i915#1825]) +22 other tests skip
   [174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-msflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
    - shard-snb:          NOTRUN -> [SKIP][175] +63 other tests skip
   [175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt:
    - shard-mtlp:         NOTRUN -> [SKIP][176] ([i915#8708]) +1 other test skip
   [176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt.html

  * igt@kms_hdr@bpc-switch:
    - shard-rkl:          NOTRUN -> [SKIP][177] ([i915#3555] / [i915#8228])
   [177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_hdr@bpc-switch.html

  * igt@kms_hdr@invalid-metadata-sizes:
    - shard-dg1:          NOTRUN -> [SKIP][178] ([i915#3555] / [i915#8228])
   [178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_hdr@invalid-metadata-sizes.html

  * igt@kms_hdr@static-swap:
    - shard-mtlp:         NOTRUN -> [SKIP][179] ([i915#3555] / [i915#8228])
   [179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_hdr@static-swap.html

  * igt@kms_hdr@static-toggle-dpms:
    - shard-dg2:          NOTRUN -> [SKIP][180] ([i915#3555] / [i915#8228])
   [180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_hdr@static-toggle-dpms.html

  * igt@kms_plane_lowres@tiling-yf:
    - shard-mtlp:         NOTRUN -> [SKIP][181] ([i915#3555] / [i915#8821])
   [181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_plane_lowres@tiling-yf.html

  * igt@kms_plane_multiple@tiling-yf:
    - shard-dg1:          NOTRUN -> [SKIP][182] ([i915#3555]) +3 other tests skip
   [182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_plane_multiple@tiling-yf.html

  * igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
    - shard-dg1:          NOTRUN -> [FAIL][183] ([i915#8292])
   [183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html

  * igt@kms_plane_scaling@plane-downscale-factor-0-75-with-rotation@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][184] ([i915#9423]) +1 other test skip
   [184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_plane_scaling@plane-downscale-factor-0-75-with-rotation@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d-hdmi-a-4:
    - shard-dg1:          NOTRUN -> [SKIP][185] ([i915#9423]) +3 other tests skip
   [185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_plane_scaling@plane-upscale-factor-0-25-with-rotation@pipe-d-hdmi-a-4.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-edp-1:
    - shard-mtlp:         NOTRUN -> [SKIP][186] ([i915#5235]) +5 other tests skip
   [186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-edp-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1:
    - shard-dg2:          NOTRUN -> [SKIP][187] ([i915#5235] / [i915#9423]) +2 other tests skip
   [187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-b-hdmi-a-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-hdmi-a-2:
    - shard-rkl:          NOTRUN -> [SKIP][188] ([i915#9728]) +1 other test skip
   [188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-4:
    - shard-dg1:          NOTRUN -> [SKIP][189] ([i915#9728]) +7 other tests skip
   [189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-c-hdmi-a-4.html

  * igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2:
    - shard-dg2:          NOTRUN -> [SKIP][190] ([i915#9423]) +20 other tests skip
   [190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-2.html

  * igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-d-edp-1:
    - shard-mtlp:         NOTRUN -> [SKIP][191] ([i915#3555] / [i915#5235]) +1 other test skip
   [191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-d-edp-1.html

  * igt@kms_pm_backlight@basic-brightness:
    - shard-dg1:          NOTRUN -> [SKIP][192] ([i915#5354])
   [192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_pm_backlight@basic-brightness.html

  * igt@kms_pm_dc@dc6-dpms:
    - shard-rkl:          NOTRUN -> [SKIP][193] ([i915#3361])
   [193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_pm_dc@dc6-dpms.html
    - shard-dg1:          NOTRUN -> [SKIP][194] ([i915#3361])
   [194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_pm_dc@dc6-dpms.html

  * igt@kms_pm_dc@dc6-psr:
    - shard-rkl:          NOTRUN -> [SKIP][195] ([i915#9685])
   [195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_pm_dc@dc6-psr.html

  * igt@kms_pm_lpsp@kms-lpsp:
    - shard-dg1:          NOTRUN -> [SKIP][196] ([i915#9340])
   [196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_pm_lpsp@kms-lpsp.html

  * igt@kms_pm_lpsp@screens-disabled:
    - shard-dg2:          NOTRUN -> [SKIP][197] ([i915#8430])
   [197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_pm_lpsp@screens-disabled.html

  * igt@kms_pm_rpm@dpms-lpsp:
    - shard-dg2:          [PASS][198] -> [SKIP][199] ([i915#9519])
   [198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-2/igt@kms_pm_rpm@dpms-lpsp.html
   [199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@kms_pm_rpm@dpms-lpsp.html
    - shard-rkl:          NOTRUN -> [SKIP][200] ([i915#9519])
   [200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_pm_rpm@dpms-lpsp.html
    - shard-dg1:          NOTRUN -> [SKIP][201] ([i915#9519])
   [201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_pm_rpm@dpms-lpsp.html

  * igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-sf:
    - shard-dg1:          NOTRUN -> [SKIP][202] ([i915#11520]) +2 other tests skip
   [202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-exceed-sf.html

  * igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-sf@psr2-pipe-a-edp-1:
    - shard-mtlp:         NOTRUN -> [SKIP][203] ([i915#9808]) +1 other test skip
   [203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_psr2_sf@fbc-overlay-plane-move-continuous-sf@psr2-pipe-a-edp-1.html

  * igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
    - shard-rkl:          NOTRUN -> [SKIP][204] ([i915#11520]) +3 other tests skip
   [204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html

  * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
    - shard-dg2:          NOTRUN -> [SKIP][205] ([i915#11520]) +1 other test skip
   [205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area.html

  * igt@kms_psr@fbc-psr2-cursor-mmap-gtt:
    - shard-tglu:         NOTRUN -> [SKIP][206] ([i915#9732])
   [206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@kms_psr@fbc-psr2-cursor-mmap-gtt.html

  * igt@kms_psr@fbc-psr2-cursor-render:
    - shard-dg2:          NOTRUN -> [SKIP][207] ([i915#1072] / [i915#9732]) +9 other tests skip
   [207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_psr@fbc-psr2-cursor-render.html

  * igt@kms_psr@pr-cursor-plane-onoff:
    - shard-dg1:          NOTRUN -> [SKIP][208] ([i915#1072] / [i915#9732]) +14 other tests skip
   [208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_psr@pr-cursor-plane-onoff.html

  * igt@kms_psr@pr-primary-render:
    - shard-mtlp:         NOTRUN -> [SKIP][209] ([i915#9688]) +2 other tests skip
   [209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_psr@pr-primary-render.html

  * igt@kms_psr@pr-sprite-render:
    - shard-rkl:          NOTRUN -> [SKIP][210] ([i915#1072] / [i915#9732]) +14 other tests skip
   [210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_psr@pr-sprite-render.html

  * igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
    - shard-mtlp:         NOTRUN -> [SKIP][211] ([i915#4235])
   [211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_rotation_crc@primary-y-tiled-reflect-x-90.html

  * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
    - shard-dg1:          NOTRUN -> [SKIP][212] ([i915#5289])
   [212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-17/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html

  * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
    - shard-rkl:          NOTRUN -> [SKIP][213] ([i915#5289]) +1 other test skip
   [213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180.html

  * igt@kms_scaling_modes@scaling-mode-none:
    - shard-rkl:          NOTRUN -> [SKIP][214] ([i915#3555]) +2 other tests skip
   [214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@kms_scaling_modes@scaling-mode-none.html

  * igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
    - shard-snb:          [PASS][215] -> [FAIL][216] ([i915#9196])
   [215]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb4/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
   [216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb6/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
    - shard-tglu:         [PASS][217] -> [FAIL][218] ([i915#9196])
   [217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-7/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html
   [218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-9/igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1.html

  * igt@kms_vrr@flip-basic-fastset:
    - shard-mtlp:         NOTRUN -> [SKIP][219] ([i915#8808] / [i915#9906])
   [219]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@kms_vrr@flip-basic-fastset.html

  * igt@kms_vrr@max-min:
    - shard-dg1:          NOTRUN -> [SKIP][220] ([i915#9906]) +1 other test skip
   [220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@kms_vrr@max-min.html

  * igt@kms_vrr@seamless-rr-switch-virtual:
    - shard-rkl:          NOTRUN -> [SKIP][221] ([i915#9906])
   [221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_vrr@seamless-rr-switch-virtual.html

  * igt@kms_writeback@writeback-fb-id:
    - shard-glk:          NOTRUN -> [SKIP][222] ([i915#2437])
   [222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk8/igt@kms_writeback@writeback-fb-id.html

  * igt@kms_writeback@writeback-fb-id-xrgb2101010:
    - shard-dg1:          NOTRUN -> [SKIP][223] ([i915#2437] / [i915#9412])
   [223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@kms_writeback@writeback-fb-id-xrgb2101010.html

  * igt@perf_pmu@frequency@gt0:
    - shard-dg1:          NOTRUN -> [FAIL][224] ([i915#6806])
   [224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-18/igt@perf_pmu@frequency@gt0.html

  * igt@prime_vgem@basic-fence-read:
    - shard-dg1:          NOTRUN -> [SKIP][225] ([i915#3708])
   [225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg1-15/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-read:
    - shard-rkl:          NOTRUN -> [SKIP][226] ([i915#3291] / [i915#3708])
   [226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@fence-read-hang:
    - shard-dg2:          NOTRUN -> [SKIP][227] ([i915#3708])
   [227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-5/igt@prime_vgem@fence-read-hang.html

  * igt@sriov_basic@enable-vfs-autoprobe-off:
    - shard-mtlp:         NOTRUN -> [SKIP][228] ([i915#9917])
   [228]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-8/igt@sriov_basic@enable-vfs-autoprobe-off.html

  * igt@sriov_basic@enable-vfs-bind-unbind-each:
    - shard-dg2:          NOTRUN -> [SKIP][229] ([i915#9917])
   [229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@sriov_basic@enable-vfs-bind-unbind-each.html

  * igt@syncobj_timeline@invalid-wait-zero-handles:
    - shard-rkl:          NOTRUN -> [FAIL][230] ([i915#9781])
   [230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@syncobj_timeline@invalid-wait-zero-handles.html

  
#### Possible fixes ####

  * igt@gem_ctx_persistence@hostile:
    - shard-tglu:         [FAIL][231] ([i915#11980]) -> [PASS][232]
   [231]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-9/igt@gem_ctx_persistence@hostile.html
   [232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-6/igt@gem_ctx_persistence@hostile.html

  * igt@gem_eio@reset-stress:
    - shard-dg2:          [FAIL][233] ([i915#5784]) -> [PASS][234]
   [233]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-4/igt@gem_eio@reset-stress.html
   [234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@gem_eio@reset-stress.html

  * igt@gem_exec_endless@dispatch@rcs0:
    - shard-tglu:         [TIMEOUT][235] ([i915#3778]) -> [PASS][236]
   [235]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-6/igt@gem_exec_endless@dispatch@rcs0.html
   [236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-10/igt@gem_exec_endless@dispatch@rcs0.html

  * igt@gem_exec_fair@basic-pace-share@rcs0:
    - shard-rkl:          [FAIL][237] ([i915#2842]) -> [PASS][238]
   [237]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@gem_exec_fair@basic-pace-share@rcs0.html
    - shard-tglu:         [FAIL][239] ([i915#2842]) -> [PASS][240]
   [239]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-tglu-10/igt@gem_exec_fair@basic-pace-share@rcs0.html
   [240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html

  * igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-2:
    - shard-rkl:          [FAIL][241] ([i915#11808]) -> [PASS][242]
   [241]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-3/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-2.html
   [242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-1/igt@kms_atomic_transition@plane-toggle-modeset-transition@pipe-a-hdmi-a-2.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-glk:          [FAIL][243] ([i915#2346]) -> [PASS][244]
   [243]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_dp_aux_dev:
    - shard-dg2:          [SKIP][245] ([i915#1257]) -> [PASS][246]
   [245]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-2/igt@kms_dp_aux_dev.html
   [246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@kms_dp_aux_dev.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-hdmi-a1:
    - shard-snb:          [FAIL][247] ([i915#2122]) -> [PASS][248] +1 other test pass
   [247]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb7/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-hdmi-a1.html
   [248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@b-hdmi-a1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
    - shard-glk:          [FAIL][249] ([i915#79]) -> [PASS][250]
   [249]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
   [250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
    - shard-dg2:          [FAIL][251] ([i915#6880]) -> [PASS][252]
   [251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
   [252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-10/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt:
    - shard-snb:          [SKIP][253] -> [PASS][254] +3 other tests pass
   [253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html
   [254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-mmap-gtt.html

  * igt@kms_pm_rpm@modeset-lpsp:
    - shard-dg2:          [SKIP][255] ([i915#9519]) -> [PASS][256] +1 other test pass
   [255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-7/igt@kms_pm_rpm@modeset-lpsp.html
   [256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_pm_rpm@modeset-lpsp.html

  
#### Warnings ####

  * igt@gem_exec_fair@basic-pace@rcs0:
    - shard-rkl:          [FAIL][257] ([i915#2876]) -> [FAIL][258] ([i915#2842])
   [257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
   [258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@gem_exec_fair@basic-pace@rcs0.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - shard-dg2:          [DMESG-WARN][259] ([i915#4936] / [i915#5493]) -> [TIMEOUT][260] ([i915#5493])
   [259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-2/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@i915_module_load@reload-with-fault-injection:
    - shard-rkl:          [ABORT][261] ([i915#9820]) -> [ABORT][262] ([i915#9697])
   [261]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-1/igt@i915_module_load@reload-with-fault-injection.html
   [262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-5/igt@i915_module_load@reload-with-fault-injection.html

  * igt@kms_cursor_crc@cursor-sliding-512x512:
    - shard-dg2:          [SKIP][263] ([i915#11453] / [i915#3359]) -> [SKIP][264] ([i915#11453])
   [263]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-11/igt@kms_cursor_crc@cursor-sliding-512x512.html
   [264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_cursor_crc@cursor-sliding-512x512.html

  * igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode:
    - shard-mtlp:         [SKIP][265] ([i915#3555] / [i915#8810]) -> [ABORT][266] ([i915#10354])
   [265]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-mtlp-1/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html
   [266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-mtlp-2/igt@kms_flip_scaled_crc@flip-32bpp-linear-to-64bpp-linear-downscaling@pipe-a-default-mode.html

  * igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render:
    - shard-dg2:          [SKIP][267] ([i915#3458]) -> [SKIP][268] ([i915#10433] / [i915#3458]) +3 other tests skip
   [267]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-11/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render.html
   [268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render.html

  * igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
    - shard-rkl:          [SKIP][269] ([i915#4070] / [i915#4816]) -> [SKIP][270] ([i915#4816])
   [269]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-6/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
   [270]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html

  * igt@kms_pm_dc@dc9-dpms:
    - shard-rkl:          [SKIP][271] ([i915#4281]) -> [SKIP][272] ([i915#3361])
   [271]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-rkl-5/igt@kms_pm_dc@dc9-dpms.html
   [272]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-rkl-3/igt@kms_pm_dc@dc9-dpms.html

  * igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
    - shard-dg2:          [TIMEOUT][273] -> [SKIP][274] ([i915#9519])
   [273]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-11/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html
   [274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-8/igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait.html

  * igt@kms_psr@fbc-pr-primary-mmap-gtt:
    - shard-dg2:          [SKIP][275] ([i915#1072] / [i915#9673] / [i915#9732]) -> [SKIP][276] ([i915#1072] / [i915#9732]) +14 other tests skip
   [275]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-11/igt@kms_psr@fbc-pr-primary-mmap-gtt.html
   [276]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-4/igt@kms_psr@fbc-pr-primary-mmap-gtt.html

  * igt@kms_psr@psr2-primary-mmap-gtt:
    - shard-dg2:          [SKIP][277] ([i915#1072] / [i915#9732]) -> [SKIP][278] ([i915#1072] / [i915#9673] / [i915#9732]) +9 other tests skip
   [277]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-2/igt@kms_psr@psr2-primary-mmap-gtt.html
   [278]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-11/igt@kms_psr@psr2-primary-mmap-gtt.html

  * igt@kms_rotation_crc@sprite-rotation-90:
    - shard-dg2:          [SKIP][279] ([i915#11131] / [i915#4235]) -> [SKIP][280] ([i915#11131])
   [279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-dg2-11/igt@kms_rotation_crc@sprite-rotation-90.html
   [280]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-dg2-3/igt@kms_rotation_crc@sprite-rotation-90.html

  * igt@kms_tiled_display@basic-test-pattern:
    - shard-glk:          [SKIP][281] -> [FAIL][282] ([i915#10959])
   [281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15323/shard-glk8/igt@kms_tiled_display@basic-test-pattern.html
   [282]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/shard-glk6/igt@kms_tiled_display@basic-test-pattern.html

  
  [i915#10166]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10166
  [i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
  [i915#10354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10354
  [i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
  [i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
  [i915#10656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10656
  [i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
  [i915#10826]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10826
  [i915#10959]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10959
  [i915#1099]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1099
  [i915#11131]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11131
  [i915#11453]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11453
  [i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
  [i915#11616]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11616
  [i915#11681]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11681
  [i915#11808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11808
  [i915#11900]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11900
  [i915#11980]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11980
  [i915#12027]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12027
  [i915#12042]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12042
  [i915#1257]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1257
  [i915#1769]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1769
  [i915#1825]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1825
  [i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
  [i915#2122]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2122
  [i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
  [i915#2437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2437
  [i915#2527]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2527
  [i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
  [i915#280]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2856
  [i915#2876]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2876
  [i915#3023]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3023
  [i915#3116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3116
  [i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3282
  [i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
  [i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
  [i915#3299]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3299
  [i915#3359]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3359
  [i915#3361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3361
  [i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
  [i915#3469]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3469
  [i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
  [i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
  [i915#3638]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3638
  [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708
  [i915#3742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3742
  [i915#3778]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3778
  [i915#3840]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3840
  [i915#3936]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3936
  [i915#4070]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
  [i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4213
  [i915#4235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4235
  [i915#4270]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4281
  [i915#4525]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4525
  [i915#4537]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4537
  [i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
  [i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
  [i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
  [i915#4816]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4816
  [i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
  [i915#4860]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4860
  [i915#4879]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4879
  [i915#4881]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4881
  [i915#4885]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4885
  [i915#4936]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4936
  [i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
  [i915#5235]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5235
  [i915#5274]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5274
  [i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5289
  [i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
  [i915#5439]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5439
  [i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
  [i915#5723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5723
  [i915#5784]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5784
  [i915#5882]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5882
  [i915#5956]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5956
  [i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
  [i915#6334]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6334
  [i915#658]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/658
  [i915#6621]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6621
  [i915#6806]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6806
  [i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
  [i915#7016]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7016
  [i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
  [i915#7213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7213
  [i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
  [i915#7742]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7742
  [i915#7790]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7790
  [i915#7828]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/79
  [i915#8228]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8228
  [i915#8289]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8289
  [i915#8292]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8292
  [i915#8381]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8381
  [i915#8399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8399
  [i915#8411]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8411
  [i915#8414]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8414
  [i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
  [i915#8430]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8430
  [i915#8437]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8437
  [i915#8555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8555
  [i915#8562]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8562
  [i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
  [i915#8808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8808
  [i915#8810]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8810
  [i915#8814]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8814
  [i915#8821]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8821
  [i915#9067]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9067
  [i915#9196]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9196
  [i915#9323]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9323
  [i915#9340]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9340
  [i915#9412]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9412
  [i915#9423]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9423
  [i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
  [i915#9519]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9519
  [i915#9531]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9531
  [i915#9673]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9673
  [i915#9685]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9685
  [i915#9688]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9688
  [i915#9697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9697
  [i915#9723]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9723
  [i915#9728]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9728
  [i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
  [i915#9781]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9781
  [i915#9808]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9808
  [i915#9809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9809
  [i915#9820]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9820
  [i915#9906]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9906
  [i915#9917]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9917
  [i915#9934]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9934


Build changes
-------------

  * Linux: CI_DRM_15323 -> Patchwork_137967v1

  CI-20190529: 20190529
  CI_DRM_15323: 7ae5f4b6787d6b8a0ca1ab1f3a71d5bb71783fe2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7997: c70810080fa12a37859c45f16445797c5d849d4d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_137967v1: 7ae5f4b6787d6b8a0ca1ab1f3a71d5bb71783fe2 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_137967v1/index.html

[-- Attachment #2: Type: text/html, Size: 95275 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
@ 2024-09-02  8:47   ` Nautiyal, Ankit K
  2024-09-02  8:47   ` Kandpal, Suraj
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 15+ messages in thread
From: Nautiyal, Ankit K @ 2024-09-02  8:47 UTC (permalink / raw)
  To: Jani Nikula, intel-gfx, intel-xe
  Cc: rodrigo.vivi, lucas.demarchi, Gustavo Sousa


On 8/29/2024 8:17 PM, Jani Nikula wrote:
> Use to_intel_display() instead of kdev_to_i915() in the HDCP component
> API hooks. Avoid further drive-by changes at this point, and just
> convert the display pointer to i915, and leave the struct intel_display
> conversion for later.
>
> The NULL error checking in the hooks make this a bit cumbersome. I'm not
> actually sure they're really required, but don't go down that rabbit
> hole just now.
>
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
>   .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
>   1 file changed, 45 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> index 6548e71b4c49..35bdb532bbb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> @@ -7,6 +7,7 @@
>   #include <drm/intel/i915_hdcp_interface.h>
>   
>   #include "i915_drv.h"
> +#include "intel_display_types.h"
>   #include "intel_hdcp_gsc_message.h"
>   
>   int
> @@ -15,17 +16,19 @@ intel_hdcp_gsc_initiate_session(struct device *dev, struct hdcp_port_data *data,
>   {
>   	struct wired_cmd_initiate_hdcp2_session_in session_init_in = {};
>   	struct wired_cmd_initiate_hdcp2_session_out session_init_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !ake_data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	session_init_in.header.api_version = HDCP_API_VERSION;
>   	session_init_in.header.command_id = WIRED_INITIATE_HDCP2_SESSION;
> @@ -72,17 +75,19 @@ intel_hdcp_gsc_verify_receiver_cert_prepare_km(struct device *dev,
>   {
>   	struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = {};
>   	struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km || !msg_sz)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	verify_rxcert_in.header.api_version = HDCP_API_VERSION;
>   	verify_rxcert_in.header.command_id = WIRED_VERIFY_RECEIVER_CERT;
> @@ -135,17 +140,19 @@ intel_hdcp_gsc_verify_hprime(struct device *dev, struct hdcp_port_data *data,
>   {
>   	struct wired_cmd_ake_send_hprime_in send_hprime_in = {};
>   	struct wired_cmd_ake_send_hprime_out send_hprime_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !rx_hprime)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	send_hprime_in.header.api_version = HDCP_API_VERSION;
>   	send_hprime_in.header.command_id = WIRED_AKE_SEND_HPRIME;
> @@ -183,17 +190,19 @@ intel_hdcp_gsc_store_pairing_info(struct device *dev, struct hdcp_port_data *dat
>   {
>   	struct wired_cmd_ake_send_pairing_info_in pairing_info_in = {};
>   	struct wired_cmd_ake_send_pairing_info_out pairing_info_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !pairing_info)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	pairing_info_in.header.api_version = HDCP_API_VERSION;
>   	pairing_info_in.header.command_id = WIRED_AKE_SEND_PAIRING_INFO;
> @@ -234,17 +243,19 @@ intel_hdcp_gsc_initiate_locality_check(struct device *dev,
>   {
>   	struct wired_cmd_init_locality_check_in lc_init_in = {};
>   	struct wired_cmd_init_locality_check_out lc_init_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !lc_init_data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	lc_init_in.header.api_version = HDCP_API_VERSION;
>   	lc_init_in.header.command_id = WIRED_INIT_LOCALITY_CHECK;
> @@ -280,17 +291,19 @@ intel_hdcp_gsc_verify_lprime(struct device *dev, struct hdcp_port_data *data,
>   {
>   	struct wired_cmd_validate_locality_in verify_lprime_in = {};
>   	struct wired_cmd_validate_locality_out verify_lprime_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !rx_lprime)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	verify_lprime_in.header.api_version = HDCP_API_VERSION;
>   	verify_lprime_in.header.command_id = WIRED_VALIDATE_LOCALITY;
> @@ -330,17 +343,19 @@ int intel_hdcp_gsc_get_session_key(struct device *dev,
>   {
>   	struct wired_cmd_get_session_key_in get_skey_in = {};
>   	struct wired_cmd_get_session_key_out get_skey_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data || !ske_data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	get_skey_in.header.api_version = HDCP_API_VERSION;
>   	get_skey_in.header.command_id = WIRED_GET_SESSION_KEY;
> @@ -382,17 +397,19 @@ intel_hdcp_gsc_repeater_check_flow_prepare_ack(struct device *dev,
>   {
>   	struct wired_cmd_verify_repeater_in verify_repeater_in = {};
>   	struct wired_cmd_verify_repeater_out verify_repeater_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !rep_topology || !rep_send_ack || !data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	verify_repeater_in.header.api_version = HDCP_API_VERSION;
>   	verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
> @@ -442,6 +459,7 @@ int intel_hdcp_gsc_verify_mprime(struct device *dev,
>   {
>   	struct wired_cmd_repeater_auth_stream_req_in *verify_mprime_in;
>   	struct wired_cmd_repeater_auth_stream_req_out verify_mprime_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   	size_t cmd_size;
> @@ -449,11 +467,12 @@ int intel_hdcp_gsc_verify_mprime(struct device *dev,
>   	if (!dev || !stream_ready || !data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	cmd_size = struct_size(verify_mprime_in, streams, data->k);
>   	if (cmd_size == SIZE_MAX)
> @@ -504,17 +523,19 @@ int intel_hdcp_gsc_enable_authentication(struct device *dev,
>   {
>   	struct wired_cmd_enable_auth_in enable_auth_in = {};
>   	struct wired_cmd_enable_auth_out enable_auth_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	enable_auth_in.header.api_version = HDCP_API_VERSION;
>   	enable_auth_in.header.command_id = WIRED_ENABLE_AUTH;
> @@ -549,17 +570,19 @@ intel_hdcp_gsc_close_session(struct device *dev, struct hdcp_port_data *data)
>   {
>   	struct wired_cmd_close_session_in session_close_in = {};
>   	struct wired_cmd_close_session_out session_close_out = {};
> +	struct intel_display *display;
>   	struct drm_i915_private *i915;
>   	ssize_t byte;
>   
>   	if (!dev || !data)
>   		return -EINVAL;
>   
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>   		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>   		return -ENODEV;
>   	}
> +	i915 = to_i915(display->drm);
>   
>   	session_close_in.header.api_version = HDCP_API_VERSION;
>   	session_close_in.header.command_id = WIRED_CLOSE_SESSION;

^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
  2024-09-02  8:47   ` Nautiyal, Ankit K
@ 2024-09-02  8:47   ` Kandpal, Suraj
  2024-09-02  8:52   ` Murthy, Arun R
  2024-09-02 10:44   ` Kandpal, Suraj
  3 siblings, 0 replies; 15+ messages in thread
From: Kandpal, Suraj @ 2024-09-02  8:47 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, Vivi, Rodrigo, De Marchi, Lucas, Sousa, Gustavo



> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Thursday, August 29, 2024 8:18 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>; De Marchi, Lucas <lucas.demarchi@intel.com>;
> Sousa, Gustavo <gustavo.sousa@intel.com>
> Subject: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in
> GSC messaging
> 
> Use to_intel_display() instead of kdev_to_i915() in the HDCP component API
> hooks. Avoid further drive-by changes at this point, and just convert the
> display pointer to i915, and leave the struct intel_display conversion for
> later.
> 
> The NULL error checking in the hooks make this a bit cumbersome. I'm not
> actually sure they're really required, but don't go down that rabbit hole just
> now.
> 
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>	

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
>  1 file changed, 45 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> index 6548e71b4c49..35bdb532bbb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> @@ -7,6 +7,7 @@
>  #include <drm/intel/i915_hdcp_interface.h>
> 
>  #include "i915_drv.h"
> +#include "intel_display_types.h"
>  #include "intel_hdcp_gsc_message.h"
> 
>  int
> @@ -15,17 +16,19 @@ intel_hdcp_gsc_initiate_session(struct device *dev,
> struct hdcp_port_data *data,  {
>  	struct wired_cmd_initiate_hdcp2_session_in session_init_in = {};
>  	struct wired_cmd_initiate_hdcp2_session_out session_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ake_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_init_in.header.api_version = HDCP_API_VERSION;
>  	session_init_in.header.command_id =
> WIRED_INITIATE_HDCP2_SESSION; @@ -72,17 +75,19 @@
> intel_hdcp_gsc_verify_receiver_cert_prepare_km(struct device *dev,  {
>  	struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = {};
>  	struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km ||
> !msg_sz)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_rxcert_in.header.api_version = HDCP_API_VERSION;
>  	verify_rxcert_in.header.command_id =
> WIRED_VERIFY_RECEIVER_CERT; @@ -135,17 +140,19 @@
> intel_hdcp_gsc_verify_hprime(struct device *dev, struct hdcp_port_data
> *data,  {
>  	struct wired_cmd_ake_send_hprime_in send_hprime_in = {};
>  	struct wired_cmd_ake_send_hprime_out send_hprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_hprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	send_hprime_in.header.api_version = HDCP_API_VERSION;
>  	send_hprime_in.header.command_id = WIRED_AKE_SEND_HPRIME;
> @@ -183,17 +190,19 @@ intel_hdcp_gsc_store_pairing_info(struct device
> *dev, struct hdcp_port_data *dat  {
>  	struct wired_cmd_ake_send_pairing_info_in pairing_info_in = {};
>  	struct wired_cmd_ake_send_pairing_info_out pairing_info_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !pairing_info)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	pairing_info_in.header.api_version = HDCP_API_VERSION;
>  	pairing_info_in.header.command_id =
> WIRED_AKE_SEND_PAIRING_INFO; @@ -234,17 +243,19 @@
> intel_hdcp_gsc_initiate_locality_check(struct device *dev,  {
>  	struct wired_cmd_init_locality_check_in lc_init_in = {};
>  	struct wired_cmd_init_locality_check_out lc_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !lc_init_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	lc_init_in.header.api_version = HDCP_API_VERSION;
>  	lc_init_in.header.command_id = WIRED_INIT_LOCALITY_CHECK; @@
> -280,17 +291,19 @@ intel_hdcp_gsc_verify_lprime(struct device *dev, struct
> hdcp_port_data *data,  {
>  	struct wired_cmd_validate_locality_in verify_lprime_in = {};
>  	struct wired_cmd_validate_locality_out verify_lprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_lprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_lprime_in.header.api_version = HDCP_API_VERSION;
>  	verify_lprime_in.header.command_id = WIRED_VALIDATE_LOCALITY;
> @@ -330,17 +343,19 @@ int intel_hdcp_gsc_get_session_key(struct device
> *dev,  {
>  	struct wired_cmd_get_session_key_in get_skey_in = {};
>  	struct wired_cmd_get_session_key_out get_skey_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ske_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	get_skey_in.header.api_version = HDCP_API_VERSION;
>  	get_skey_in.header.command_id = WIRED_GET_SESSION_KEY; @@ -
> 382,17 +397,19 @@
> intel_hdcp_gsc_repeater_check_flow_prepare_ack(struct device *dev,  {
>  	struct wired_cmd_verify_repeater_in verify_repeater_in = {};
>  	struct wired_cmd_verify_repeater_out verify_repeater_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !rep_topology || !rep_send_ack || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_repeater_in.header.api_version = HDCP_API_VERSION;
>  	verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
> @@ -442,6 +459,7 @@ int intel_hdcp_gsc_verify_mprime(struct device
> *dev,  {
>  	struct wired_cmd_repeater_auth_stream_req_in
> *verify_mprime_in;
>  	struct wired_cmd_repeater_auth_stream_req_out
> verify_mprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
>  	size_t cmd_size;
> @@ -449,11 +467,12 @@ int intel_hdcp_gsc_verify_mprime(struct device
> *dev,
>  	if (!dev || !stream_ready || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	cmd_size = struct_size(verify_mprime_in, streams, data->k);
>  	if (cmd_size == SIZE_MAX)
> @@ -504,17 +523,19 @@ int intel_hdcp_gsc_enable_authentication(struct
> device *dev,  {
>  	struct wired_cmd_enable_auth_in enable_auth_in = {};
>  	struct wired_cmd_enable_auth_out enable_auth_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	enable_auth_in.header.api_version = HDCP_API_VERSION;
>  	enable_auth_in.header.command_id = WIRED_ENABLE_AUTH; @@ -
> 549,17 +570,19 @@ intel_hdcp_gsc_close_session(struct device *dev, struct
> hdcp_port_data *data)  {
>  	struct wired_cmd_close_session_in session_close_in = {};
>  	struct wired_cmd_close_session_out session_close_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_close_in.header.api_version = HDCP_API_VERSION;
>  	session_close_in.header.command_id = WIRED_CLOSE_SESSION;
> --
> 2.39.2


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
  2024-09-02  8:47   ` Nautiyal, Ankit K
  2024-09-02  8:47   ` Kandpal, Suraj
@ 2024-09-02  8:52   ` Murthy, Arun R
  2024-09-02 10:44   ` Kandpal, Suraj
  3 siblings, 0 replies; 15+ messages in thread
From: Murthy, Arun R @ 2024-09-02  8:52 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, Vivi, Rodrigo, De Marchi, Lucas, Sousa, Gustavo

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Thursday, August 29, 2024 8:18 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> De Marchi, Lucas <lucas.demarchi@intel.com>; Sousa, Gustavo
> <gustavo.sousa@intel.com>
> Subject: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in
> GSC messaging
> 
> Use to_intel_display() instead of kdev_to_i915() in the HDCP component API
> hooks. Avoid further drive-by changes at this point, and just convert the display
> pointer to i915, and leave the struct intel_display conversion for later.
> 
> The NULL error checking in the hooks make this a bit cumbersome. I'm not
> actually sure they're really required, but don't go down that rabbit hole just
> now.
> 
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Looks good to me
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>

Thanks and Regards,
Arun R Murthy
--------------------
> ---
>  .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
>  1 file changed, 45 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> index 6548e71b4c49..35bdb532bbb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> @@ -7,6 +7,7 @@
>  #include <drm/intel/i915_hdcp_interface.h>
> 
>  #include "i915_drv.h"
> +#include "intel_display_types.h"
>  #include "intel_hdcp_gsc_message.h"
> 
>  int
> @@ -15,17 +16,19 @@ intel_hdcp_gsc_initiate_session(struct device *dev,
> struct hdcp_port_data *data,  {
>  	struct wired_cmd_initiate_hdcp2_session_in session_init_in = {};
>  	struct wired_cmd_initiate_hdcp2_session_out session_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ake_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_init_in.header.api_version = HDCP_API_VERSION;
>  	session_init_in.header.command_id =
> WIRED_INITIATE_HDCP2_SESSION; @@ -72,17 +75,19 @@
> intel_hdcp_gsc_verify_receiver_cert_prepare_km(struct device *dev,  {
>  	struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = {};
>  	struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km || !msg_sz)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_rxcert_in.header.api_version = HDCP_API_VERSION;
>  	verify_rxcert_in.header.command_id = WIRED_VERIFY_RECEIVER_CERT;
> @@ -135,17 +140,19 @@ intel_hdcp_gsc_verify_hprime(struct device *dev,
> struct hdcp_port_data *data,  {
>  	struct wired_cmd_ake_send_hprime_in send_hprime_in = {};
>  	struct wired_cmd_ake_send_hprime_out send_hprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_hprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	send_hprime_in.header.api_version = HDCP_API_VERSION;
>  	send_hprime_in.header.command_id = WIRED_AKE_SEND_HPRIME;
> @@ -183,17 +190,19 @@ intel_hdcp_gsc_store_pairing_info(struct device
> *dev, struct hdcp_port_data *dat  {
>  	struct wired_cmd_ake_send_pairing_info_in pairing_info_in = {};
>  	struct wired_cmd_ake_send_pairing_info_out pairing_info_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !pairing_info)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	pairing_info_in.header.api_version = HDCP_API_VERSION;
>  	pairing_info_in.header.command_id =
> WIRED_AKE_SEND_PAIRING_INFO; @@ -234,17 +243,19 @@
> intel_hdcp_gsc_initiate_locality_check(struct device *dev,  {
>  	struct wired_cmd_init_locality_check_in lc_init_in = {};
>  	struct wired_cmd_init_locality_check_out lc_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !lc_init_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	lc_init_in.header.api_version = HDCP_API_VERSION;
>  	lc_init_in.header.command_id = WIRED_INIT_LOCALITY_CHECK; @@ -
> 280,17 +291,19 @@ intel_hdcp_gsc_verify_lprime(struct device *dev, struct
> hdcp_port_data *data,  {
>  	struct wired_cmd_validate_locality_in verify_lprime_in = {};
>  	struct wired_cmd_validate_locality_out verify_lprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_lprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_lprime_in.header.api_version = HDCP_API_VERSION;
>  	verify_lprime_in.header.command_id = WIRED_VALIDATE_LOCALITY;
> @@ -330,17 +343,19 @@ int intel_hdcp_gsc_get_session_key(struct device
> *dev,  {
>  	struct wired_cmd_get_session_key_in get_skey_in = {};
>  	struct wired_cmd_get_session_key_out get_skey_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ske_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	get_skey_in.header.api_version = HDCP_API_VERSION;
>  	get_skey_in.header.command_id = WIRED_GET_SESSION_KEY; @@ -
> 382,17 +397,19 @@ intel_hdcp_gsc_repeater_check_flow_prepare_ack(struct
> device *dev,  {
>  	struct wired_cmd_verify_repeater_in verify_repeater_in = {};
>  	struct wired_cmd_verify_repeater_out verify_repeater_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !rep_topology || !rep_send_ack || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_repeater_in.header.api_version = HDCP_API_VERSION;
>  	verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
> @@ -442,6 +459,7 @@ int intel_hdcp_gsc_verify_mprime(struct device *dev,  {
>  	struct wired_cmd_repeater_auth_stream_req_in *verify_mprime_in;
>  	struct wired_cmd_repeater_auth_stream_req_out verify_mprime_out
> = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
>  	size_t cmd_size;
> @@ -449,11 +467,12 @@ int intel_hdcp_gsc_verify_mprime(struct device
> *dev,
>  	if (!dev || !stream_ready || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	cmd_size = struct_size(verify_mprime_in, streams, data->k);
>  	if (cmd_size == SIZE_MAX)
> @@ -504,17 +523,19 @@ int intel_hdcp_gsc_enable_authentication(struct
> device *dev,  {
>  	struct wired_cmd_enable_auth_in enable_auth_in = {};
>  	struct wired_cmd_enable_auth_out enable_auth_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	enable_auth_in.header.api_version = HDCP_API_VERSION;
>  	enable_auth_in.header.command_id = WIRED_ENABLE_AUTH; @@ -
> 549,17 +570,19 @@ intel_hdcp_gsc_close_session(struct device *dev, struct
> hdcp_port_data *data)  {
>  	struct wired_cmd_close_session_in session_close_in = {};
>  	struct wired_cmd_close_session_out session_close_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_close_in.header.api_version = HDCP_API_VERSION;
>  	session_close_in.header.command_id = WIRED_CLOSE_SESSION;
> --
> 2.39.2


^ permalink raw reply	[flat|nested] 15+ messages in thread

* RE: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
  2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
                     ` (2 preceding siblings ...)
  2024-09-02  8:52   ` Murthy, Arun R
@ 2024-09-02 10:44   ` Kandpal, Suraj
  3 siblings, 0 replies; 15+ messages in thread
From: Kandpal, Suraj @ 2024-09-02 10:44 UTC (permalink / raw)
  To: Nikula, Jani, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
  Cc: Nikula, Jani, Vivi, Rodrigo, De Marchi, Lucas, Sousa, Gustavo



> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Jani
> Nikula
> Sent: Thursday, August 29, 2024 8:18 PM
> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
> Cc: Nikula, Jani <jani.nikula@intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@intel.com>; De Marchi, Lucas <lucas.demarchi@intel.com>;
> Sousa, Gustavo <gustavo.sousa@intel.com>
> Subject: [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in
> GSC messaging
> 
> Use to_intel_display() instead of kdev_to_i915() in the HDCP component API
> hooks. Avoid further drive-by changes at this point, and just convert the
> display pointer to i915, and leave the struct intel_display conversion for
> later.
> 
> The NULL error checking in the hooks make this a bit cumbersome. I'm not
> actually sure they're really required, but don't go down that rabbit hole just
> now.
> 
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
>  1 file changed, 45 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> index 6548e71b4c49..35bdb532bbb3 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp_gsc_message.c
> @@ -7,6 +7,7 @@
>  #include <drm/intel/i915_hdcp_interface.h>
> 
>  #include "i915_drv.h"
> +#include "intel_display_types.h"
>  #include "intel_hdcp_gsc_message.h"
> 
>  int
> @@ -15,17 +16,19 @@ intel_hdcp_gsc_initiate_session(struct device *dev,
> struct hdcp_port_data *data,  {
>  	struct wired_cmd_initiate_hdcp2_session_in session_init_in = {};
>  	struct wired_cmd_initiate_hdcp2_session_out session_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ake_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_init_in.header.api_version = HDCP_API_VERSION;
>  	session_init_in.header.command_id =
> WIRED_INITIATE_HDCP2_SESSION; @@ -72,17 +75,19 @@
> intel_hdcp_gsc_verify_receiver_cert_prepare_km(struct device *dev,  {
>  	struct wired_cmd_verify_receiver_cert_in verify_rxcert_in = {};
>  	struct wired_cmd_verify_receiver_cert_out verify_rxcert_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_cert || !km_stored || !ek_pub_km ||
> !msg_sz)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_rxcert_in.header.api_version = HDCP_API_VERSION;
>  	verify_rxcert_in.header.command_id =
> WIRED_VERIFY_RECEIVER_CERT; @@ -135,17 +140,19 @@
> intel_hdcp_gsc_verify_hprime(struct device *dev, struct hdcp_port_data
> *data,  {
>  	struct wired_cmd_ake_send_hprime_in send_hprime_in = {};
>  	struct wired_cmd_ake_send_hprime_out send_hprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_hprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	send_hprime_in.header.api_version = HDCP_API_VERSION;
>  	send_hprime_in.header.command_id = WIRED_AKE_SEND_HPRIME;
> @@ -183,17 +190,19 @@ intel_hdcp_gsc_store_pairing_info(struct device
> *dev, struct hdcp_port_data *dat  {
>  	struct wired_cmd_ake_send_pairing_info_in pairing_info_in = {};
>  	struct wired_cmd_ake_send_pairing_info_out pairing_info_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !pairing_info)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	pairing_info_in.header.api_version = HDCP_API_VERSION;
>  	pairing_info_in.header.command_id =
> WIRED_AKE_SEND_PAIRING_INFO; @@ -234,17 +243,19 @@
> intel_hdcp_gsc_initiate_locality_check(struct device *dev,  {
>  	struct wired_cmd_init_locality_check_in lc_init_in = {};
>  	struct wired_cmd_init_locality_check_out lc_init_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !lc_init_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	lc_init_in.header.api_version = HDCP_API_VERSION;
>  	lc_init_in.header.command_id = WIRED_INIT_LOCALITY_CHECK; @@
> -280,17 +291,19 @@ intel_hdcp_gsc_verify_lprime(struct device *dev, struct
> hdcp_port_data *data,  {
>  	struct wired_cmd_validate_locality_in verify_lprime_in = {};
>  	struct wired_cmd_validate_locality_out verify_lprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !rx_lprime)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_lprime_in.header.api_version = HDCP_API_VERSION;
>  	verify_lprime_in.header.command_id = WIRED_VALIDATE_LOCALITY;
> @@ -330,17 +343,19 @@ int intel_hdcp_gsc_get_session_key(struct device
> *dev,  {
>  	struct wired_cmd_get_session_key_in get_skey_in = {};
>  	struct wired_cmd_get_session_key_out get_skey_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data || !ske_data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	get_skey_in.header.api_version = HDCP_API_VERSION;
>  	get_skey_in.header.command_id = WIRED_GET_SESSION_KEY; @@ -
> 382,17 +397,19 @@
> intel_hdcp_gsc_repeater_check_flow_prepare_ack(struct device *dev,  {
>  	struct wired_cmd_verify_repeater_in verify_repeater_in = {};
>  	struct wired_cmd_verify_repeater_out verify_repeater_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !rep_topology || !rep_send_ack || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	verify_repeater_in.header.api_version = HDCP_API_VERSION;
>  	verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
> @@ -442,6 +459,7 @@ int intel_hdcp_gsc_verify_mprime(struct device
> *dev,  {
>  	struct wired_cmd_repeater_auth_stream_req_in
> *verify_mprime_in;
>  	struct wired_cmd_repeater_auth_stream_req_out
> verify_mprime_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
>  	size_t cmd_size;
> @@ -449,11 +467,12 @@ int intel_hdcp_gsc_verify_mprime(struct device
> *dev,
>  	if (!dev || !stream_ready || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	cmd_size = struct_size(verify_mprime_in, streams, data->k);
>  	if (cmd_size == SIZE_MAX)
> @@ -504,17 +523,19 @@ int intel_hdcp_gsc_enable_authentication(struct
> device *dev,  {
>  	struct wired_cmd_enable_auth_in enable_auth_in = {};
>  	struct wired_cmd_enable_auth_out enable_auth_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	enable_auth_in.header.api_version = HDCP_API_VERSION;
>  	enable_auth_in.header.command_id = WIRED_ENABLE_AUTH; @@ -
> 549,17 +570,19 @@ intel_hdcp_gsc_close_session(struct device *dev, struct
> hdcp_port_data *data)  {
>  	struct wired_cmd_close_session_in session_close_in = {};
>  	struct wired_cmd_close_session_out session_close_out = {};
> +	struct intel_display *display;
>  	struct drm_i915_private *i915;
>  	ssize_t byte;
> 
>  	if (!dev || !data)
>  		return -EINVAL;
> 
> -	i915 = kdev_to_i915(dev);
> -	if (!i915) {
> +	display = to_intel_display(dev);
> +	if (!display) {
>  		dev_err(dev, "DRM not initialized, aborting HDCP.\n");
>  		return -ENODEV;
>  	}
> +	i915 = to_i915(display->drm);
> 
>  	session_close_in.header.api_version = HDCP_API_VERSION;
>  	session_close_in.header.command_id = WIRED_CLOSE_SESSION;
> --
> 2.39.2


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up
  2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
                   ` (8 preceding siblings ...)
  2024-08-31  0:09 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2024-09-02 12:20 ` Jani Nikula
  9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2024-09-02 12:20 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: rodrigo.vivi, lucas.demarchi, Gustavo Sousa

On Thu, 29 Aug 2024, Jani Nikula <jani.nikula@intel.com> wrote:
> Follow-up to [1].

Thanks for the reviews, pushed to drm-intel-next.

BR,
Jani.

>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/r/cover.1723129920.git.jani.nikula@intel.com
>
> Jani Nikula (6):
>   drm/i915 & drm/xe: save struct drm_device to drvdata
>   drm/i915: support struct device and pci_dev in to_intel_display()
>   drm/i915/audio: migrate away from kdev_to_i915()
>   drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind
>   drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging
>   drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915()
>
>  drivers/gpu/drm/i915/display/intel_audio.c    | 34 ++++++----
>  .../drm/i915/display/intel_display_types.h    |  8 ++-
>  drivers/gpu/drm/i915/display/intel_hdcp.c     | 10 +--
>  .../drm/i915/display/intel_hdcp_gsc_message.c | 67 +++++++++++++------
>  drivers/gpu/drm/i915/i915_driver.c            |  2 +-
>  drivers/gpu/drm/i915/i915_drv.h               |  8 ++-
>  .../gpu/drm/i915/selftests/mock_gem_device.c  |  2 +-
>  .../gpu/drm/xe/compat-i915-headers/i915_drv.h |  7 --
>  drivers/gpu/drm/xe/xe_device.h                |  8 ++-
>  drivers/gpu/drm/xe/xe_pci.c                   |  2 +-
>  10 files changed, 94 insertions(+), 54 deletions(-)

-- 
Jani Nikula, Intel

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-09-02 12:21 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 14:47 [PATCH v2 0/6] drm/xe & drm/i915: drvdata usage changes follow-up Jani Nikula
2024-08-29 14:47 ` [PATCH v2 1/6] drm/i915 & drm/xe: save struct drm_device to drvdata Jani Nikula
2024-08-29 14:47 ` [PATCH v2 2/6] drm/i915: support struct device and pci_dev in to_intel_display() Jani Nikula
2024-08-29 14:47 ` [PATCH v2 3/6] drm/i915/audio: migrate away from kdev_to_i915() Jani Nikula
2024-08-29 14:47 ` [PATCH v2 4/6] drm/i915/hdcp: migrate away from kdev_to_i915() in bind/unbind Jani Nikula
2024-08-29 14:47 ` [PATCH v2 5/6] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging Jani Nikula
2024-09-02  8:47   ` Nautiyal, Ankit K
2024-09-02  8:47   ` Kandpal, Suraj
2024-09-02  8:52   ` Murthy, Arun R
2024-09-02 10:44   ` Kandpal, Suraj
2024-08-29 14:47 ` [PATCH v2 6/6] drm/xe/display: remove unused compat kdev_to_i915() and pdev_to_i915() Jani Nikula
2024-08-29 15:42 ` ✗ Fi.CI.SPARSE: warning for drm/xe & drm/i915: drvdata usage changes follow-up Patchwork
2024-08-29 15:50 ` ✓ Fi.CI.BAT: success " Patchwork
2024-08-31  0:09 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-02 12:20 ` [PATCH v2 0/6] " Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox