From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe
Date: Mon, 02 Oct 2023 10:41:14 +0300 [thread overview]
Message-ID: <871qedii91.fsf@intel.com> (raw)
In-Reply-To: <20230929205023.1202735-1-rodrigo.vivi@intel.com>
On Fri, 29 Sep 2023, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> The goal is to have this function ready for Xe to use
> directly. So, let's use the available macro.
Seesm wrong to use DISPLAY_INFO() as an lvalue, and I'm not sure why
this wouldn't work as-is.
But *shrug*.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
for merging to i915. (xe should come as a backport with cherry-pick -x.)
BR,
Jani
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index a6a18eae7ae8..ce55b968e658 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -926,7 +926,7 @@ void intel_display_device_probe(struct drm_i915_private *i915)
> else
> info = probe_display(i915);
>
> - i915->display.info.__device_info = info;
> + DISPLAY_INFO(i915) = info;
>
> memcpy(DISPLAY_RUNTIME_INFO(i915),
> &DISPLAY_INFO(i915)->__runtime_defaults,
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-10-02 7:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 20:50 [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe Rodrigo Vivi
2023-09-29 22:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-09-30 3:12 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-10-02 7:41 ` Jani Nikula [this message]
2023-10-02 16:13 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2023-10-02 16:58 ` Jani Nikula
2023-10-02 19:46 ` Rodrigo Vivi
2023-10-03 9:04 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qedii91.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox