Re: [Intel-gfx] [PATCH 02/10] drm/i915/dvo/sil164: Nuke pointless return statements

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 22 Nov 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Drop the pointless return statements at the end of void
> functions.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/dvo_sil164.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/dvo_sil164.c b/drivers/gpu/drm/i915/display/dvo_sil164.c
> index 0dfa0a0209ff..32dd3b969946 100644
> --- a/drivers/gpu/drm/i915/display/dvo_sil164.c
> +++ b/drivers/gpu/drm/i915/display/dvo_sil164.c
> @@ -205,7 +205,6 @@ static void sil164_mode_set(struct intel_dvo_device *dvo,
>  	  sil164_writeb(sil, 0x0c, 0x89);
>  	  sil164_writeb(sil, 0x08, 0x31);*/
>  	/* don't do much */
> -	return;
>  }
>  
>  /* set the SIL164 power state */
> @@ -224,7 +223,6 @@ static void sil164_dpms(struct intel_dvo_device *dvo, bool enable)
>  		ch &= ~SIL164_8_PD;
>  
>  	sil164_writeb(dvo, SIL164_REG8, ch);
> -	return;
>  }
>  
>  static bool sil164_get_hw_state(struct intel_dvo_device *dvo)

-- 
Jani Nikula, Intel Open Source Graphics Center