From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Let's avoid even early init if SLPC is used.
Date: Tue, 06 Sep 2022 16:20:47 -0700 [thread overview]
Message-ID: <8735d4rsxc.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220906203349.177989-1-rodrigo.vivi@intel.com>
On Tue, 06 Sep 2022 13:33:49 -0700, Rodrigo Vivi wrote:
>
Hi Rodrigo,
> void intel_rps_init_early(struct intel_rps *rps)
> {
> + if (rps_wants_slpc(rps))
> + return;
> +
So what happens if we "want" SLPC but finally could not enable it (switch
slpc to "in use") and have to fall back to host turbo? If that's a valid
possibility then we can't do the above.
From drivers/gpu/drm/i915/gt/uc/intel_uc.h
* - Not supported: not available in HW and/or firmware not defined.
* - Supported: available in HW and firmware defined.
* - Wanted: supported + enabled in modparam.
* - In use: wanted + firmware found on the system and successfully fetched.
Thanks.
--
Ashutosh
prev parent reply other threads:[~2022-09-06 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 20:33 [Intel-gfx] [PATCH] drm/i915: Let's avoid even early init if SLPC is used Rodrigo Vivi
2022-09-06 22:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-09-06 23:20 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735d4rsxc.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox