From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: fei.yang@intel.com, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/8] drm/i915/mtl: Set has_llc=0
Date: Thu, 20 Apr 2023 12:20:40 +0200 [thread overview]
Message-ID: <874e7aa6-748a-e5f5-6692-c75eda4e963f@linux.intel.com> (raw)
In-Reply-To: <20230419230058.2659455-2-fei.yang@intel.com>
We have multiple bugs that requires this and it can be picked up
irrespective of this series. I have sent a trybot patch for this and
once that passes, I will push this one.
https://patchwork.freedesktop.org/series/116746/
Nirmoy
On 4/20/2023 1:00 AM, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
>
> On MTL, LLC is not shared between GT and CPU, set has_llc=0.
>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index d64e074d7457..272a8ba37b64 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -1147,6 +1147,7 @@ static const struct intel_device_info mtl_info = {
> .has_flat_ccs = 0,
> .has_gmd_id = 1,
> .has_guc_deprivilege = 1,
> + .has_llc = 0,
> .has_mslice_steering = 0,
> .has_snoop = 1,
> .__runtime.memory_regions = REGION_SMEM | REGION_STOLEN_LMEM,
next prev parent reply other threads:[~2023-04-20 10:20 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 23:00 [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 23:00 ` [Intel-gfx] [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-20 10:20 ` Das, Nirmoy [this message]
2023-04-19 23:00 ` [Intel-gfx] [PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-20 20:29 ` Matt Roper
2023-04-19 23:00 ` [Intel-gfx] [PATCH 3/8] drm/i915/mtl: Add PTE encode function fei.yang
2023-04-20 20:40 ` Matt Roper
2023-04-21 17:27 ` Yang, Fei
2023-04-21 17:42 ` Matt Roper
2023-04-23 7:37 ` Yang, Fei
2023-04-24 17:20 ` Matt Roper
2023-04-24 18:41 ` Yang, Fei
2023-04-19 23:00 ` [Intel-gfx] [PATCH 4/8] drm/i915/mtl: workaround coherency issue for Media fei.yang
2023-04-20 8:26 ` Andrzej Hajda
2023-04-20 11:36 ` Das, Nirmoy
2023-04-20 20:52 ` Matt Roper
2023-04-19 23:00 ` [Intel-gfx] [PATCH 5/8] drm/i915/mtl: end support for set caching ioctl fei.yang
2023-04-20 21:05 ` Matt Roper
2023-04-19 23:00 ` [Intel-gfx] [PATCH 6/8] drm/i915: preparation for using PAT index fei.yang
2023-04-20 8:45 ` Andrzej Hajda
2023-04-20 21:14 ` Matt Roper
2023-04-19 23:00 ` [Intel-gfx] [PATCH 7/8] drm/i915: use pat_index instead of cache_level fei.yang
2023-04-20 10:13 ` Andrzej Hajda
2023-04-20 12:39 ` Tvrtko Ursulin
2023-04-20 20:34 ` Yang, Fei
2023-04-21 8:43 ` Tvrtko Ursulin
2023-04-21 10:17 ` Tvrtko Ursulin
2023-04-23 6:12 ` Yang, Fei
2023-04-24 8:41 ` Tvrtko Ursulin
2023-04-21 11:39 ` Tvrtko Ursulin
2023-04-23 6:52 ` Yang, Fei
2023-04-24 9:22 ` Tvrtko Ursulin
2023-04-19 23:00 ` [Intel-gfx] [PATCH 8/8] drm/i915: Allow user to set cache at BO creation fei.yang
2023-04-20 11:39 ` Andi Shyti
2023-04-20 13:06 ` Tvrtko Ursulin
2023-04-20 16:11 ` Yang, Fei
2023-04-20 16:29 ` Andi Shyti
2023-04-21 20:48 ` Jordan Justen
[not found] ` <BYAPR11MB2567F03AD43D7E2DE2628D5D9A669@BYAPR11MB2567.namprd11.prod.outlook.com>
[not found] ` <168232538771.392286.3227368099155268955@jljusten-skl>
2023-04-24 9:08 ` Tvrtko Ursulin
2023-04-24 17:13 ` Jordan Justen
2023-04-25 13:41 ` [Intel-gfx] IOCTL feature detection (Was: Re: [PATCH 8/8] drm/i915: Allow user to set cache at BO creation) Joonas Lahtinen
2023-04-25 17:21 ` Teres Alexis, Alan Previn
2023-04-25 18:19 ` Jordan Justen
2023-04-26 11:52 ` Daniel Vetter
2023-04-26 16:48 ` Teres Alexis, Alan Previn
2023-04-26 18:10 ` Ceraolo Spurio, Daniele
2023-04-26 20:04 ` Jordan Justen
2023-04-19 23:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/mtl: Define MOCS and PAT tables for MTL (rev8) Patchwork
2023-04-19 23:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-04-20 11:30 ` [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-04-19 21:12 fei.yang
2023-04-19 21:12 ` [Intel-gfx] [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-19 21:56 ` Andi Shyti
2023-04-19 22:10 ` Yang, Fei
2023-04-19 22:11 ` Andi Shyti
2023-04-19 18:09 [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-19 18:09 ` [Intel-gfx] [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-17 6:24 [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL fei.yang
2023-04-17 6:24 ` [Intel-gfx] [PATCH 1/8] drm/i915/mtl: Set has_llc=0 fei.yang
2023-04-19 10:59 ` Andi Shyti
2023-04-19 12:50 ` Andrzej Hajda
2023-04-19 14:10 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874e7aa6-748a-e5f5-6692-c75eda4e963f@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.yang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox