* [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915)
@ 2023-07-25 10:33 Andi Shyti
2023-07-25 11:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Andi Shyti @ 2023-07-25 10:33 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx, dri-devel
Quite surprised to see that around i915 there are still i915->gt0
references. Replace them with the to_gt() helper.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++----
drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 3b094d36a0b04..5b0a5cf9a98a8 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -892,7 +892,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
} else {
resource_size_t lmem_range;
- lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
+ lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
lmem_size *= SZ_1G;
}
diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
index 9f64d61dd5fcd..02886c1eb0f17 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt.c
@@ -887,7 +887,7 @@ static int intel_gt_tile_setup(struct intel_gt *gt, phys_addr_t phys_addr)
int intel_gt_probe_all(struct drm_i915_private *i915)
{
struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
- struct intel_gt *gt = &i915->gt0;
+ struct intel_gt *gt = to_gt(i915);
const struct intel_gt_definition *gtdef;
phys_addr_t phys_addr;
unsigned int mmio_bar;
diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
index 2a3217e2890fc..f8512aee58a83 100644
--- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
+++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
@@ -220,7 +220,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
resource_size_t lmem_range;
u64 tile_stolen, flat_ccs_base;
- lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
+ lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
lmem_size *= SZ_1G;
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c
index bb2e15329f346..38ec754d0ec8e 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c
@@ -162,8 +162,8 @@ static struct intel_gt *find_gt_for_required_teelink(struct drm_i915_private *i9
* for HuC authentication. For now, its limited to DG2.
*/
if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && IS_ENABLED(CONFIG_INTEL_MEI_GSC) &&
- intel_huc_is_loaded_by_gsc(&i915->gt0.uc.huc) && intel_uc_uses_huc(&i915->gt0.uc))
- return &i915->gt0;
+ intel_huc_is_loaded_by_gsc(&to_gt(i915)->uc.huc) && intel_uc_uses_huc(&to_gt(i915)->uc))
+ return to_gt(i915);
return NULL;
}
@@ -188,8 +188,8 @@ static struct intel_gt *find_gt_for_required_protected_content(struct drm_i915_p
* Else we rely on mei-pxp module but only on legacy platforms
* prior to having separate media GTs and has a valid VDBOX.
*/
- if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(&i915->gt0))
- return &i915->gt0;
+ if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(to_gt(i915)))
+ return to_gt(i915);
return NULL;
}
diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
index 12aa7fbb07481..da0b269606c51 100644
--- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
+++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
@@ -114,7 +114,7 @@ static struct dev_pm_domain pm_domain = {
static void mock_gt_probe(struct drm_i915_private *i915)
{
- i915->gt[0] = &i915->gt0;
+ i915->gt[0] = to_gt(i915);
i915->gt[0]->name = "Mock GT";
}
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Replace i915->gt0 with to_gt(i915)
2023-07-25 10:33 [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915) Andi Shyti
@ 2023-07-25 11:41 ` Patchwork
2023-07-25 13:41 ` [Intel-gfx] [PATCH] " Andrzej Hajda
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-07-25 11:41 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8631 bytes --]
== Series Details ==
Series: drm/i915: Replace i915->gt0 with to_gt(i915)
URL : https://patchwork.freedesktop.org/series/121302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13419 -> Patchwork_121302v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/index.html
Participating hosts (43 -> 42)
------------------------------
Missing (1): fi-apl-guc
Known issues
------------
Here are the changes found in Patchwork_121302v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_auth@basic-auth:
- bat-adlp-11: NOTRUN -> [ABORT][1] ([i915#8011])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-adlp-11/igt@core_auth@basic-auth.html
* igt@i915_pm_rpm@module-reload:
- fi-tgl-1115g4: [PASS][2] -> [FAIL][3] ([i915#7940])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][4] -> [DMESG-FAIL][5] ([i915#5334] / [i915#7872])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [PASS][6] -> [ABORT][7] ([i915#4983])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][8] -> [DMESG-WARN][9] ([i915#7699])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-dg2-11/igt@i915_selftest@live@migrate.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-rpls-2: NOTRUN -> [SKIP][10] ([i915#7828])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-rpls-2/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
- bat-jsl-3: NOTRUN -> [SKIP][11] ([i915#7828])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-jsl-3/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: NOTRUN -> [SKIP][12] ([i915#1845] / [i915#5354]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc:
- bat-rpls-2: NOTRUN -> [SKIP][13] ([i915#1845])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-rpls-2/igt@kms_pipe_crc_basic@suspend-read-crc.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- bat-jsl-3: [ABORT][14] ([i915#5122]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-jsl-3/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: [INCOMPLETE][16] ([i915#7156] / [i915#7913]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-8: [DMESG-FAIL][18] ([i915#7059]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@migrate:
- bat-mtlp-6: [DMESG-FAIL][20] ([i915#7699]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-mtlp-6/igt@i915_selftest@live@migrate.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-mtlp-6/igt@i915_selftest@live@migrate.html
- bat-rpls-2: [DMESG-FAIL][22] ([i915#7699] / [i915#7913]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-rpls-2/igt@i915_selftest@live@migrate.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-rpls-2/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: [ABORT][24] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#8347]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-rpls-2/igt@i915_selftest@live@reset.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-jsl-3: [FAIL][26] ([fdo#103375]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-jsl-3/igt@i915_suspend@basic-s3-without-i915.html
#### Warnings ####
* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][28] ([i915#4423]) -> [DMESG-WARN][29] ([i915#4423])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-adlp-11/igt@i915_module_load@load.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-cfl-guc: [FAIL][30] ([i915#7940]) -> [FAIL][31] ([i915#7691])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/fi-cfl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/fi-cfl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rplp-1: [SKIP][32] ([i915#1072]) -> [ABORT][33] ([i915#8712])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/bat-rplp-1/igt@kms_psr@sprite_plane_onoff.html
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7156]: https://gitlab.freedesktop.org/drm/intel/issues/7156
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8712]: https://gitlab.freedesktop.org/drm/intel/issues/8712
Build changes
-------------
* Linux: CI_DRM_13419 -> Patchwork_121302v1
CI-20190529: 20190529
CI_DRM_13419: 495f70657aa5f5302a5f6f27321c09fc51b60b77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7401: 0c66a6560eda687effa9088659577a520d913908 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_121302v1: 495f70657aa5f5302a5f6f27321c09fc51b60b77 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
159425a213b5 drm/i915: Replace i915->gt0 with to_gt(i915)
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/index.html
[-- Attachment #2: Type: text/html, Size: 10291 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915)
2023-07-25 10:33 [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915) Andi Shyti
2023-07-25 11:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-07-25 13:41 ` Andrzej Hajda
2023-07-25 16:36 ` Andi Shyti
2023-07-25 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-07-31 11:06 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 1 reply; 6+ messages in thread
From: Andrzej Hajda @ 2023-07-25 13:41 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx, dri-devel
On 25.07.2023 12:33, Andi Shyti wrote:
> Quite surprised to see that around i915 there are still i915->gt0
> references. Replace them with the to_gt() helper.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
> drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++----
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
> 5 files changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> index 3b094d36a0b04..5b0a5cf9a98a8 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> @@ -892,7 +892,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
> } else {
> resource_size_t lmem_range;
>
> - lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> + lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
> lmem_size *= SZ_1G;
> }
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> index 9f64d61dd5fcd..02886c1eb0f17 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -887,7 +887,7 @@ static int intel_gt_tile_setup(struct intel_gt *gt, phys_addr_t phys_addr)
> int intel_gt_probe_all(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> - struct intel_gt *gt = &i915->gt0;
> + struct intel_gt *gt = to_gt(i915);
> const struct intel_gt_definition *gtdef;
> phys_addr_t phys_addr;
> unsigned int mmio_bar;
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 2a3217e2890fc..f8512aee58a83 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -220,7 +220,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
> resource_size_t lmem_range;
> u64 tile_stolen, flat_ccs_base;
>
> - lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> + lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
> lmem_size *= SZ_1G;
>
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c
> index bb2e15329f346..38ec754d0ec8e 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c
> @@ -162,8 +162,8 @@ static struct intel_gt *find_gt_for_required_teelink(struct drm_i915_private *i9
> * for HuC authentication. For now, its limited to DG2.
> */
> if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && IS_ENABLED(CONFIG_INTEL_MEI_GSC) &&
> - intel_huc_is_loaded_by_gsc(&i915->gt0.uc.huc) && intel_uc_uses_huc(&i915->gt0.uc))
> - return &i915->gt0;
> + intel_huc_is_loaded_by_gsc(&to_gt(i915)->uc.huc) && intel_uc_uses_huc(&to_gt(i915)->uc))
> + return to_gt(i915);
>
> return NULL;
> }
> @@ -188,8 +188,8 @@ static struct intel_gt *find_gt_for_required_protected_content(struct drm_i915_p
> * Else we rely on mei-pxp module but only on legacy platforms
> * prior to having separate media GTs and has a valid VDBOX.
> */
> - if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(&i915->gt0))
> - return &i915->gt0;
> + if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(to_gt(i915)))
> + return to_gt(i915);
>
> return NULL;
> }
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index 12aa7fbb07481..da0b269606c51 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -114,7 +114,7 @@ static struct dev_pm_domain pm_domain = {
>
> static void mock_gt_probe(struct drm_i915_private *i915)
> {
> - i915->gt[0] = &i915->gt0;
> + i915->gt[0] = to_gt(i915);
> i915->gt[0]->name = "Mock GT";
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Replace i915->gt0 with to_gt(i915)
2023-07-25 10:33 [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915) Andi Shyti
2023-07-25 11:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-25 13:41 ` [Intel-gfx] [PATCH] " Andrzej Hajda
@ 2023-07-25 16:05 ` Patchwork
2023-07-31 11:06 ` [Intel-gfx] [PATCH] " Jani Nikula
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-07-25 16:05 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 31023 bytes --]
== Series Details ==
Series: drm/i915: Replace i915->gt0 with to_gt(i915)
URL : https://patchwork.freedesktop.org/series/121302/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13419_full -> Patchwork_121302v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-rkl0
Known issues
------------
Here are the changes found in Patchwork_121302v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-queued:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-snb7/igt@gem_ctx_persistence@engines-queued.html
* igt@gem_eio@unwedge-stress:
- shard-dg1: [PASS][2] -> [FAIL][3] ([i915#5784]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-13/igt@gem_eio@unwedge-stress.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-19/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][4] -> [FAIL][5] ([i915#2842]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-apl3/igt@gem_exec_fair@basic-none-solo@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-4/igt@gem_exec_fair@basic-none@bcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-2/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_flush@basic-wb-ro-default:
- shard-dg2: NOTRUN -> [SKIP][8] ([i915#3539] / [i915#4852])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-6/igt@gem_exec_flush@basic-wb-ro-default.html
* igt@gem_exec_reloc@basic-wc:
- shard-mtlp: NOTRUN -> [SKIP][9] ([i915#3281])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gem_exec_reloc@basic-wc.html
* igt@gem_exec_schedule@preempt-queue:
- shard-mtlp: NOTRUN -> [SKIP][10] ([i915#4812])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gem_exec_schedule@preempt-queue.html
* igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][11] ([i915#4860])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible.html
* igt@gem_mmap_gtt@basic-read-write:
- shard-mtlp: NOTRUN -> [SKIP][12] ([i915#4077])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gem_mmap_gtt@basic-read-write.html
* igt@gem_mmap_wc@read-write:
- shard-mtlp: NOTRUN -> [SKIP][13] ([i915#4083]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gem_mmap_wc@read-write.html
* igt@gem_pxp@protected-raw-src-copy-not-readible:
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#4270])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-4/igt@gem_pxp@protected-raw-src-copy-not-readible.html
* igt@gen3_render_tiledx_blits:
- shard-mtlp: NOTRUN -> [SKIP][15] ([fdo#109289])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@gen3_render_tiledx_blits.html
* igt@i915_pm_rpm@debugfs-forcewake-user:
- shard-tglu: [PASS][16] -> [FAIL][17] ([i915#7940])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-tglu-3/igt@i915_pm_rpm@debugfs-forcewake-user.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-tglu-5/igt@i915_pm_rpm@debugfs-forcewake-user.html
* igt@i915_pm_rpm@dpms-lpsp:
- shard-dg1: [PASS][18] -> [SKIP][19] ([i915#1397]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-19/igt@i915_pm_rpm@dpms-lpsp.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-14/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [PASS][20] -> [SKIP][21] ([i915#1397])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-8/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-12/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- shard-dg1: [PASS][22] -> [FAIL][23] ([i915#7940]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-15/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-18/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-rkl: [PASS][24] -> [SKIP][25] ([i915#1397]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@i915_pm_rpm@system-suspend-devices:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +102 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-snb7/igt@i915_pm_rpm@system-suspend-devices.html
* igt@i915_selftest@live@slpc:
- shard-mtlp: [PASS][27] -> [DMESG-WARN][28] ([i915#6367])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-mtlp-8/igt@i915_selftest@live@slpc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-3/igt@i915_selftest@live@slpc.html
* igt@kms_addfb_basic@bo-too-small-due-to-tiling:
- shard-dg2: NOTRUN -> [SKIP][29] ([i915#4212])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-6/igt@kms_addfb_basic@bo-too-small-due-to-tiling.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs:
- shard-dg1: NOTRUN -> [SKIP][30] ([i915#8502]) +7 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-19/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-d-hdmi-a-1-y-rc_ccs.html
* igt@kms_async_flips@crc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][31] ([i915#8247]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-1/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html
* igt@kms_async_flips@crc@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [FAIL][32] ([i915#8247]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-10/igt@kms_async_flips@crc@pipe-b-hdmi-a-1.html
* igt@kms_big_fb@y-tiled-addfb:
- shard-mtlp: NOTRUN -> [SKIP][33] ([i915#6187])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_big_fb@y-tiled-addfb.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-mtlp: NOTRUN -> [SKIP][34] ([fdo#111615]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs:
- shard-mtlp: NOTRUN -> [SKIP][35] ([i915#6095]) +4 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-5/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][36] ([i915#3886] / [i915#6095])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#7213]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-2/igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-2.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- shard-mtlp: NOTRUN -> [SKIP][38] ([i915#7828]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_content_protection@srm@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [TIMEOUT][39] ([i915#7173]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-12/igt@kms_content_protection@srm@pipe-a-dp-2.html
* igt@kms_content_protection@uevent:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#7118]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-10/igt@kms_content_protection@uevent.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [PASS][41] -> [FAIL][42] ([i915#2346])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-dg2: NOTRUN -> [SKIP][43] ([i915#3555]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-2/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111767])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-snb7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][45] -> [FAIL][46] ([i915#79])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][47] ([i915#2672]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-dg2: [PASS][48] -> [FAIL][49] ([i915#6880])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#8708])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff:
- shard-mtlp: NOTRUN -> [SKIP][51] ([i915#1825]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_hdr@bpc-switch:
- shard-rkl: NOTRUN -> [SKIP][52] ([i915#3555] / [i915#8228]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-6/igt@kms_hdr@bpc-switch.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#3555] / [i915#8228]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-8/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][54] ([i915#8292])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-1/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4:
- shard-dg1: NOTRUN -> [FAIL][55] ([i915#8292])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-18/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-4.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#5176]) +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-12/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-a-dp-2.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg1: NOTRUN -> [SKIP][57] ([i915#5176]) +19 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-19/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][58] ([i915#5176]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-7/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#5235]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-5/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-d-hdmi-a-3.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg1: NOTRUN -> [SKIP][60] ([i915#5235]) +11 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-19/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][61] ([i915#5235]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-4/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- shard-snb: NOTRUN -> [DMESG-WARN][62] ([i915#8841]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-snb7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-dg2: [PASS][63] -> [FAIL][64] ([fdo#103375])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-1/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-11/igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend.html
* igt@v3d/v3d_submit_csd@bad-perfmon:
- shard-mtlp: NOTRUN -> [SKIP][65] ([i915#2575])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-4/igt@v3d/v3d_submit_csd@bad-perfmon.html
* igt@vc4/vc4_purgeable_bo@access-purged-bo-mem:
- shard-mtlp: NOTRUN -> [SKIP][66] ([i915#7711])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@vc4/vc4_purgeable_bo@access-purged-bo-mem.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [FAIL][67] ([i915#6268]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_endless@dispatch@rcs0:
- shard-dg2: [TIMEOUT][69] ([i915#3778] / [i915#7016] / [i915#7921]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-1/igt@gem_exec_endless@dispatch@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-11/igt@gem_exec_endless@dispatch@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][71] ([i915#2842]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-rkl: [FAIL][73] ([i915#2842]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-dg2: [SKIP][75] ([i915#1937]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-10/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-dg1: [FAIL][77] ([i915#7691]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-18/igt@i915_pm_rpm@basic-pci-d3-state.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-15/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [SKIP][79] ([i915#1397]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-2/igt@i915_pm_rpm@dpms-lpsp.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-7/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [FAIL][81] ([i915#7940]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-tglu-2/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-tglu-7/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-dg1: [SKIP][83] ([i915#1397]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][85] ([i915#7790]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-snb4/igt@i915_pm_rps@reset.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-snb7/igt@i915_pm_rps@reset.html
* igt@i915_pm_rps@waitboost:
- shard-glk: [FAIL][87] ([i915#8229]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-glk7/igt@i915_pm_rps@waitboost.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-glk4/igt@i915_pm_rps@waitboost.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [FAIL][89] ([i915#5138]) -> [PASS][90] +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-2/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-mtlp: [FAIL][91] ([i915#3743]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-mtlp-5/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][93] ([i915#2346]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-dg2: [FAIL][95] ([i915#6880]) -> [PASS][96] +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_sysfs_edid_timing:
- shard-dg2: [FAIL][97] ([IGT#2]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-3/igt@kms_sysfs_edid_timing.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-11/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-dg2: [FAIL][99] ([fdo#103375]) -> [PASS][100] +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-1/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@kms_content_protection@content_type_change:
- shard-dg2: [SKIP][101] ([i915#7118]) -> [SKIP][102] ([i915#7118] / [i915#7162])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-1/igt@kms_content_protection@content_type_change.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-11/igt@kms_content_protection@content_type_change.html
* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][103] ([i915#7118] / [i915#7162]) -> [SKIP][104] ([i915#7118])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg2-11/igt@kms_content_protection@mei_interface.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg2-7/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-mtlp: [FAIL][105] ([i915#2346]) -> [DMESG-FAIL][106] ([i915#1982] / [i915#2017] / [i915#5954])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-mtlp-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-mtlp-8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][107] ([fdo#110189] / [i915#3955]) -> [SKIP][108] ([i915#3955])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-2/igt@kms_fbcon_fbt@psr.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-7/igt@kms_fbcon_fbt@psr.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][109] ([fdo#109285]) -> [SKIP][110] ([fdo#109285] / [i915#4098])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-7/igt@kms_force_connector_basic@force-load-detect.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-1/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][111] ([i915#4816]) -> [SKIP][112] ([i915#4070] / [i915#4816])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_psr@cursor_plane_move:
- shard-dg1: [SKIP][113] ([i915#1072] / [i915#4078]) -> [SKIP][114] ([i915#1072])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-18/igt@kms_psr@cursor_plane_move.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-14/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@sprite_plane_onoff:
- shard-dg1: [SKIP][115] ([i915#1072]) -> [SKIP][116] ([i915#1072] / [i915#4078]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13419/shard-dg1-14/igt@kms_psr@sprite_plane_onoff.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/shard-dg1-13/igt@kms_psr@sprite_plane_onoff.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6187]: https://gitlab.freedesktop.org/drm/intel/issues/6187
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7016]: https://gitlab.freedesktop.org/drm/intel/issues/7016
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7921]: https://gitlab.freedesktop.org/drm/intel/issues/7921
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8229]: https://gitlab.freedesktop.org/drm/intel/issues/8229
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8708]: https://gitlab.freedesktop.org/drm/intel/issues/8708
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13419 -> Patchwork_121302v1
CI-20190529: 20190529
CI_DRM_13419: 495f70657aa5f5302a5f6f27321c09fc51b60b77 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7401: 0c66a6560eda687effa9088659577a520d913908 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_121302v1: 495f70657aa5f5302a5f6f27321c09fc51b60b77 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_121302v1/index.html
[-- Attachment #2: Type: text/html, Size: 35948 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915)
2023-07-25 13:41 ` [Intel-gfx] [PATCH] " Andrzej Hajda
@ 2023-07-25 16:36 ` Andi Shyti
0 siblings, 0 replies; 6+ messages in thread
From: Andi Shyti @ 2023-07-25 16:36 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, dri-devel
Hi,
On Tue, Jul 25, 2023 at 03:41:31PM +0200, Andrzej Hajda wrote:
> On 25.07.2023 12:33, Andi Shyti wrote:
> > Quite surprised to see that around i915 there are still i915->gt0
> > references. Replace them with the to_gt() helper.
> >
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> > drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
> > drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
> > drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++----
> > drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
> > 5 files changed, 8 insertions(+), 8 deletions(-)
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Thanks for your review! Pushed in drm-intel-gt-next.
Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915)
2023-07-25 10:33 [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915) Andi Shyti
` (2 preceding siblings ...)
2023-07-25 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
@ 2023-07-31 11:06 ` Jani Nikula
3 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2023-07-31 11:06 UTC (permalink / raw)
To: Andi Shyti, Andi Shyti; +Cc: intel-gfx, dri-devel
On Tue, 25 Jul 2023, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Quite surprised to see that around i915 there are still i915->gt0
> references. Replace them with the to_gt() helper.
Please remind me why we still have i915->gt0 at all. Why aren't we just
using i915->gt[0] instead?
BR,
Jani.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
> drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +-
> drivers/gpu/drm/i915/pxp/intel_pxp.c | 8 ++++----
> drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +-
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> index 3b094d36a0b04..5b0a5cf9a98a8 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> @@ -892,7 +892,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
> } else {
> resource_size_t lmem_range;
>
> - lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> + lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
> lmem_size *= SZ_1G;
> }
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c
> index 9f64d61dd5fcd..02886c1eb0f17 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -887,7 +887,7 @@ static int intel_gt_tile_setup(struct intel_gt *gt, phys_addr_t phys_addr)
> int intel_gt_probe_all(struct drm_i915_private *i915)
> {
> struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
> - struct intel_gt *gt = &i915->gt0;
> + struct intel_gt *gt = to_gt(i915);
> const struct intel_gt_definition *gtdef;
> phys_addr_t phys_addr;
> unsigned int mmio_bar;
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 2a3217e2890fc..f8512aee58a83 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -220,7 +220,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt)
> resource_size_t lmem_range;
> u64 tile_stolen, flat_ccs_base;
>
> - lmem_range = intel_gt_mcr_read_any(&i915->gt0, XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> + lmem_range = intel_gt_mcr_read_any(to_gt(i915), XEHP_TILE0_ADDR_RANGE) & 0xFFFF;
> lmem_size = lmem_range >> XEHP_TILE_LMEM_RANGE_SHIFT;
> lmem_size *= SZ_1G;
>
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.c b/drivers/gpu/drm/i915/pxp/intel_pxp.c
> index bb2e15329f346..38ec754d0ec8e 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.c
> @@ -162,8 +162,8 @@ static struct intel_gt *find_gt_for_required_teelink(struct drm_i915_private *i9
> * for HuC authentication. For now, its limited to DG2.
> */
> if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && IS_ENABLED(CONFIG_INTEL_MEI_GSC) &&
> - intel_huc_is_loaded_by_gsc(&i915->gt0.uc.huc) && intel_uc_uses_huc(&i915->gt0.uc))
> - return &i915->gt0;
> + intel_huc_is_loaded_by_gsc(&to_gt(i915)->uc.huc) && intel_uc_uses_huc(&to_gt(i915)->uc))
> + return to_gt(i915);
>
> return NULL;
> }
> @@ -188,8 +188,8 @@ static struct intel_gt *find_gt_for_required_protected_content(struct drm_i915_p
> * Else we rely on mei-pxp module but only on legacy platforms
> * prior to having separate media GTs and has a valid VDBOX.
> */
> - if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(&i915->gt0))
> - return &i915->gt0;
> + if (IS_ENABLED(CONFIG_INTEL_MEI_PXP) && !i915->media_gt && VDBOX_MASK(to_gt(i915)))
> + return to_gt(i915);
>
> return NULL;
> }
> diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> index 12aa7fbb07481..da0b269606c51 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c
> @@ -114,7 +114,7 @@ static struct dev_pm_domain pm_domain = {
>
> static void mock_gt_probe(struct drm_i915_private *i915)
> {
> - i915->gt[0] = &i915->gt0;
> + i915->gt[0] = to_gt(i915);
> i915->gt[0]->name = "Mock GT";
> }
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-31 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 10:33 [Intel-gfx] [PATCH] drm/i915: Replace i915->gt0 with to_gt(i915) Andi Shyti
2023-07-25 11:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-25 13:41 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2023-07-25 16:36 ` Andi Shyti
2023-07-25 16:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-07-31 11:06 ` [Intel-gfx] [PATCH] " Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox